Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp826283rwd; Tue, 13 Jun 2023 00:27:33 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Mw9sAc2+oDFEalYehsSbJ71Qs+qcrAGv7K+NOEqQLPWIrpDWB0bmhanIarx/yQ0bMplm7 X-Received: by 2002:a05:6a00:a01:b0:636:f899:46a0 with SMTP id p1-20020a056a000a0100b00636f89946a0mr17436561pfh.15.1686641253266; Tue, 13 Jun 2023 00:27:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686641253; cv=none; d=google.com; s=arc-20160816; b=nTGy3fShitQJIAUduijRoQyjBXdy0koX4pg70qY4qYmx+X4HICLT3X5mT4pJsGKcPH s9WhBXnmvqN5AVxFtbGdAz1+rtzN4MlDR+jJ17FM0sYiHy1t6v5ToTuELFaa++ggOckH b34+PfXGybUr2Nj6mOwAHXYudh/h6TE4fid/DcoQUlLAl9ITDVc49/0wOa2ZRl6+s3s5 LVWKXp1cyRly3R8QzvvXNEFguNfD3SoqFrkZU2Mr//B+hkv4QANylcn2izoTmf8aK53/ WMid60VccVTQPUF8p7PI+5pURFxsP+94mowEor11dHbFov04s/HQ5wJrBUDZcUHgETiH zR3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=N/wlUBkEwgr5eLaMoxO9Mu5KBKJON7zjaoclqydTonU=; b=BM/ec6SNZIG4vC0iZI4DH+9h0mDMLR6FFrpS4/TiGaaV0np9ZVWlKi3garrAMFotsK Vz0P2FHSJ0U32Ic/pi/IqM0TMBhBwGe4HGx15nW0L96HmEELbOaQ14gnISeoUZZF7ycA p6XRdX4PCsR4ua4izJaGhrTmsA8AewtIPPyqh2vAKviH4wafZ+CH+gy8+uCcocVWXY2Q 1MUIHXy5t7uj3QViMibSgZaHjMSRK8slNaAGxpDNwdfbuJqJjrhuu+ciY96d3jYuW897 6HS0/XFrR++GVYsSugUeYIFLMucFij2dobrZMKapw9ddduqJ2AXu8yAu10FEIFfCWH48 YTmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BWbka8Dn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s192-20020a6377c9000000b00534e310d0d3si5630442pgc.588.2023.06.13.00.27.20; Tue, 13 Jun 2023 00:27:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BWbka8Dn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240285AbjFMHAo (ORCPT + 99 others); Tue, 13 Jun 2023 03:00:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240373AbjFMHAg (ORCPT ); Tue, 13 Jun 2023 03:00:36 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8AF61730 for ; Tue, 13 Jun 2023 00:00:27 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-4f620583bc2so6156357e87.1 for ; Tue, 13 Jun 2023 00:00:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686639626; x=1689231626; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N/wlUBkEwgr5eLaMoxO9Mu5KBKJON7zjaoclqydTonU=; b=BWbka8DnbzJWXRnq1wydHCY2Zd8Enj9c5X4EA/Zc53VMiM6amzlRsGK3qa54mK3mPu x+FJU2DOiTKVenYgWfL1yf7xU5R859nJE2sLd5V6WXIZGd3/ZqF5GLLHccsCiwShdmXe LMsJ9RsxDnyKim+9qckRnb4fY05Zt0FRbcrxC+tOsOWEAwXxOwiXOKVSvqorsydju/uH GeVuJNww6lGNWSB9oE6x/OBVBx73/av7//qn6Bg9mG8Ws4TlupKFD9x3mWUSLiD+4a3x 95rkK6ypdgQKc7gF4K2/nAUs+ONiCIciwG/WN/QPDvcpQ8F0JKyouxRDd4BXx0ZZiVWk Oyrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686639626; x=1689231626; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N/wlUBkEwgr5eLaMoxO9Mu5KBKJON7zjaoclqydTonU=; b=Ue1SPBhPJJGi9rFLbaYNpmA2g9TJfR4WMwcxpoD+iG5bA/OQPFQoGQZxQ3+dig2op/ MjUIs2PHDHD2mGsJCbWFzzoLi7aWphpAVQebX+POvUVb8TiWTJ9+EICVzv/k9gtwl5GE X+znh4d1jpy1Wpwa36nGgOui3pxC+SiVL8GkjogIrEN4gwD3WbBaLis1Aq55Y2YCIRN4 dwixtxZu63C3r9pzGUYa+i3YA8Qtmt4Mrhpgjhw/5ohysF2rHxX1wmzI2jv0eLn3BhS0 3exlaETwuOvB4nlVPx1tmMH9saCBOOodmWokNDYGz/wV/kAx3eK9TyfraFeU79vDOZZg 7nLw== X-Gm-Message-State: AC+VfDz8XfiXojZy26+C+YT7uHNUZQ8voV0vKHqVF3mSmlZ7jTuaSSgz fwf+T00h/Lj/oESFn9uWxfszeA== X-Received: by 2002:a05:6512:ea7:b0:4f4:b397:ebda with SMTP id bi39-20020a0565120ea700b004f4b397ebdamr5164640lfb.56.1686639625978; Tue, 13 Jun 2023 00:00:25 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:b5a8:28ff:af00:a97f? ([2a05:6e02:1041:c10:b5a8:28ff:af00:a97f]) by smtp.googlemail.com with ESMTPSA id 11-20020a05600c228b00b003f7361ca753sm13360118wmf.24.2023.06.13.00.00.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 00:00:25 -0700 (PDT) Message-ID: <575f0538-1963-59fa-582f-6686f67b2f29@linaro.org> Date: Tue, 13 Jun 2023 09:00:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] thermal: Allow selecting the bang-bang governor as default Content-Language: en-US To: Thierry Reding , "Rafael J . Wysocki" Cc: Amit Kucheria , Zhang Rui , linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230609124408.3788680-1-thierry.reding@gmail.com> From: Daniel Lezcano In-Reply-To: <20230609124408.3788680-1-thierry.reding@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/2023 14:44, Thierry Reding wrote: > From: Thierry Reding > > For many setups the bang-bang governor is exactly what we want. Many > ARM SoC-based devices use fans to cool down the entire SoC and that > works well only with the bang-bang governor because it uses the > hysteresis in order to let the fan run for a while to cool the SoC > down below the trip point before switching it off again. > > The step-wise governor will behave strangely in these situations. It > doesn't use the hysteresis, so it can lead to situations where the fan > is turned on for only a very brief period and then is switched back off, > only to get switched back on again very quickly because the SoC hasn't > cooled down very much. Applied, thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog