Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
To:     Frederic Weisbecker <frederic@kernel.org>,
        "Paul E . McKenney" <paulmck@kernel.org>
CC:     LKML <linux-kernel@vger.kernel.org>, rcu <rcu@vger.kernel.org>,
        "Uladzislau Rezki" <urezki@gmail.com>,
        Neeraj Upadhyay <quic_neeraju@quicinc.com>,
        "Joel Fernandes" <joel@joelfernandes.org>,
        Giovanni Gherdovich <ggherdovich@suse.cz>
Subject: RE: [PATCH 5/9] rcu: Add rcutree.lazy_enabled boot parameter
Thread-Topic: [PATCH 5/9] rcu: Add rcutree.lazy_enabled boot parameter
Thread-Index: AQHZk6lClEakYUGB6E+RTFZhv5r1b6+IXt9g
Date:   Tue, 13 Jun 2023 06:57:25 +0000
Message-ID: <CY8PR11MB71346F0DFCA82A7501DA0A4E8955A@CY8PR11MB7134.namprd11.prod.outlook.com>
References: <20230531101736.12981-1-frederic@kernel.org>
 <20230531101736.12981-6-frederic@kernel.org>
In-Reply-To: <20230531101736.12981-6-frederic@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?R58/wvKKUHkOjL7gtu04DrFY+/ZNQOFgan7+7k49YUAkYAu9cZHXNyjDKM55?=
 =?us-ascii?Q?uDcY9kHwQQd7q2RwJnbqAuTm9qUN/BSywk5jR7VFgxo/QEasH4KuAp4Tku6X?=
 =?us-ascii?Q?9UuTNV47bRx11S2bgy4GlP6QiqUu4HPagCrEZGauJ3p1eeti/91DVDeVcGMN?=
 =?us-ascii?Q?8aSFOcpj2Bo0QOrtoG7SXTPA4IbU+IrulhXQ6RMe2kjD15rYqOTz0hFwpGe0?=
 =?us-ascii?Q?/bg4JmyLdXOfoDdBmGXbNa8Q8nAB9eV0UOHyeD6DKVy3LRF7oYTp+IruDOGy?=
 =?us-ascii?Q?Vg8QkznuzfiwcWl8m9aPBAklzIwD8KFCJpCs2heqdWk5ww8w5NUWzri024fB?=
 =?us-ascii?Q?UuJp/8TWMXpw47WNsHWpDahDyFyMxcRECID9hK+kCtGtsqLH9FBVeWYEf63E?=
 =?us-ascii?Q?JhnZ4CuulrfDu2OXWCzrGdu4VaID+buOD6Ye1SS4g+Wn547QJlgH3bU4b1Jy?=
 =?us-ascii?Q?LccDQkc03jUZ82HsHy4Al/HkzNPu9ivCCFe/AMkE0GMNQwhglkp40ShctTux?=
 =?us-ascii?Q?wRMmPvuYN6CAO75eW8vCdP/UJIh5u51ei05BYANJQrxHWXd22/xW+ycPVPjP?=
 =?us-ascii?Q?tKsut3g4kfN04mvp+bZ9KRHkV6rQNZ8nrK9DuvWSIrqt7+rFGYUrgoVkuFCR?=
 =?us-ascii?Q?jRr9ntU6elgl0g5m94enC/qo54TONEgyZmvMOMTy2IkB5mfNNXUvo75yqxM1?=
 =?us-ascii?Q?MawDoc1wJ9a6M2/xNUZMShH6U5Xx7JzzrlnrsdBvRhuxIYBIZ/Gp3yTt8Yg/?=
 =?us-ascii?Q?tv1yaWxgoedS3U4KZmRW9bCBLqGjHHhQ7wbg29dwtVsA69h9+k7F0wN9HHCa?=
 =?us-ascii?Q?M16nIKpsWhLWchsLPTkqorDRPICLNlIys6NyPi8mHwAvZXVLzmOKhhoNZ8Pg?=
 =?us-ascii?Q?UmNSZqIRFKlDirnkY30md2ot611NW7SvaK+9sQAjviB+MMlQ//CR6p+oqwlY?=
 =?us-ascii?Q?XJryzPE0pvwt+4rYwvtj1dNo3qfaAgoRCLnOV6e8Z4zJ/MQKhHiHyBMH4Ygw?=
 =?us-ascii?Q?9Q7xk4Y/hRnkyvN6J4tXZiF4rMFhNVFogt+W5O7m3ldOIZwidhO9tAKCiTub?=
 =?us-ascii?Q?fCqYUvNNhxBnAub6+u7zwu/HUowEZ3J5gpbqaWlYlltMvxlB8RiOvBlkzwpY?=
 =?us-ascii?Q?lagtSQrDu4/VYgCzhdNkKHQvTYZNNyNkKPwH+1MoDVQbbORyfTKrQrAnFeHS?=
 =?us-ascii?Q?UpNOLuToabpB0JEeFM/nmnvDp/ddMtgMrXy7n7FU5AAXof6lffdDkDnpouEM?=
 =?us-ascii?Q?a2GGkTINBd4UB0iNf6X1dlxv9oPi9zUbXaPpreGPIkFxsq6EuzGKXYVPas23?=
 =?us-ascii?Q?LGzk7yq9WJKzUISgHF6l3xyFQnbbDvhgIavdwyjS7sJD2v2m7JSBmMwT0qrq?=
 =?us-ascii?Q?TxgWpyDvl1gOOs+Eki5u7jJwVspX3eRgpSQBxuv3hW5rO3bUde0iRgK4IhxM?=
 =?us-ascii?Q?NNpHwV6ji4g0+Dxva8Z6Ktr9COEDZ7fSQzFl45gehkHQo4kMGswqEp5lhjrs?=
 =?us-ascii?Q?nQSGcfoK1X+jwlQwgZ6Yu9HrvqXtY1CIwp567hBDgudvujRQb+j35GxnC01X?=
 =?us-ascii?Q?YKSqcGc4WXETdIYZjkHSHa7uLif0kuA+aOh3I4+a?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7134.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dbedb84a-640b-4680-6ff5-08db6bdb71b6
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jun 2023 06:57:25.2349
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4XqgUR2xnxNLuNGvO+dIIZfWCXWiD2DSSS9D3xak3sqcyou+TK5d7f6EzXq6KSkkMNI4TcAB8hBRq+GBCJzQKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4704
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Frederic Weisbecker <frederic@kernel.org>
> Sent: Wednesday, May 31, 2023 6:18 PM
> ...
> Subject: [PATCH 5/9] rcu: Add rcutree.lazy_enabled boot parameter

I didn't find the 'lazy_enabled' variable in the patch series.
Did you say rcutree. qhimark_lazy?

-Qiuxu

> Allow to overwrite the arbitrary default number of lazy callbacks thresho=
ld
> that is currently set to 100. This allows for tuning between powersaving,
> throughtput and memory consumption expectations. As a bonus, setting this
> value to 0 disables lazy callbacks.
>=20
> Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 5 +++++
>  kernel/rcu/tree.c                               | 3 ++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
>=20
> diff --git a/Documentation/admin-guide/kernel-parameters.txt
> b/Documentation/admin-guide/kernel-parameters.txt
> index 505978cfb548..dd2be4249061 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -4798,6 +4798,11 @@
>  			Set threshold of queued RCU callbacks beyond which
>  			batch limiting is disabled.
>=20
> +	rcutree.qhimark_lazy =3D [KNL]
> +			Set threshold of queued lazy RCU callbacks beyond
> which
> +			batch must be flushed to the main queue. If set to 0,
> +			disable lazy queue.
> +
>  	rcutree.qlowmark=3D [KNL]
>  			Set threshold of queued RCU callbacks below which
>  			batch limiting is re-enabled.
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index
> 9b98d87fa22e..e33c0d889216 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -390,6 +390,7 @@ static long qovld_calc =3D -1;	  // No pre-
> initialization lock acquisitions!
>=20
>  module_param(blimit, long, 0444);
>  module_param(qhimark, long, 0444);
> +module_param(qhimark_lazy, long, 0444);
>  module_param(qlowmark, long, 0444);
>  module_param(qovld, long, 0444);
>=20
> @@ -2655,7 +2656,7 @@ __call_rcu_common(struct rcu_head *head,
> rcu_callback_t func, bool lazy_in)
>  	kasan_record_aux_stack_noalloc(head);
>  	local_irq_save(flags);
>  	rdp =3D this_cpu_ptr(&rcu_data);
> -	lazy =3D lazy_in && !rcu_async_should_hurry();
> +	lazy =3D lazy_in && qhimark_lazy && !rcu_async_should_hurry();
>=20
>  	/* Add the callback to our list. */
>  	if (unlikely(!rcu_segcblist_is_enabled(&rdp->cblist))) {
> --
> 2.40.1