Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d8a09620-9891-8072-8602-403128ba8d30@linaro.org>
Date:   Tue, 13 Jun 2023 08:59:16 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v3 3/8] dt-bindings: leds: leds-mt6323: Support WLED
 output
Content-Language: en-US
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>, pavel@ucw.cz
Cc:     lee@kernel.org, sean.wang@mediatek.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
        linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel@collabora.com
References: <20230601110813.2373764-1-angelogioacchino.delregno@collabora.com>
 <20230601110813.2373764-4-angelogioacchino.delregno@collabora.com>
 <75d78713-fc8f-24a9-a422-2b4d57c5d488@linaro.org>
 <88f37d33-6545-d307-17a9-896e86d0ed50@collabora.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <88f37d33-6545-d307-17a9-896e86d0ed50@collabora.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 09/06/2023 09:51, AngeloGioacchino Del Regno wrote:
> Il 02/06/23 10:32, Krzysztof Kozlowski ha scritto:
>> On 01/06/2023 13:08, AngeloGioacchino Del Regno wrote:
>>> Some PMICs have a separated WLED string output: add a property
>>> `mediatek,is-wled` to indicate which LED string is a WLED.
>>>
>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>> ---
>>>   Documentation/devicetree/bindings/leds/leds-mt6323.txt | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/leds/leds-mt6323.txt b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
>>> index 052dccb8f2ce..904b2222a5fe 100644
>>> --- a/Documentation/devicetree/bindings/leds/leds-mt6323.txt
>>> +++ b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
>>> @@ -30,6 +30,7 @@ Optional properties for the LED child node:
>>>   - label : See Documentation/devicetree/bindings/leds/common.txt
>>>   - linux,default-trigger : See Documentation/devicetree/bindings/leds/common.txt
>>>   - default-state: See Documentation/devicetree/bindings/leds/common.txt
>>> +- mediatek,is-wled: LED string is connected to WLED output
>>
>> Why would it matter to what the output is connected to?
> 
> When this property is present, the MT6323 LEDs are managed through different
> hardware registers which are specific to WLEDs: if we have no indication of
> whether this is a WLED or a LED, we would program the wrong registers.
> 

OK, so it is rather the choice of output in the device? What is "LED
string" in this context?


Best regards,
Krzysztof