Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <19745770-0a63-dfeb-741f-5bfe2ed11b1c@loongson.cn>
Date:   Tue, 13 Jun 2023 15:31:58 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
From:   Sui Jingfeng <suijingfeng@loongson.cn>
To:     Paul Cercueil <paul@crapouillou.net>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20230607110650.569522-1-suijingfeng@loongson.cn>
Content-Language: en-US
Organization: Loongson
In-Reply-To: <20230607110650.569522-1-suijingfeng@loongson.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,


Humble ping ?


On 2023/6/7 19:06, Sui Jingfeng wrote:
> Otherwise its failed to pass basic compile test on platform without
> REGMAP_MMIO selected by defconfig
>
> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
>
>    SYNC    include/config/auto.conf.cmd
>    Checking missing-syscalls for N32
>    CALL    scripts/checksyscalls.sh
>    Checking missing-syscalls for O32
>    CALL    scripts/checksyscalls.sh
>    CALL    scripts/checksyscalls.sh
>    MODPOST Module.symvers
> ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
> make: *** [Makefile:1978: modpost] Error 2
>
> V2: Order alphabetically
>
> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
> ---
>   drivers/gpu/drm/ingenic/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/ingenic/Kconfig b/drivers/gpu/drm/ingenic/Kconfig
> index a53f475d33df..b440e0cdc057 100644
> --- a/drivers/gpu/drm/ingenic/Kconfig
> +++ b/drivers/gpu/drm/ingenic/Kconfig
> @@ -9,6 +9,8 @@ config DRM_INGENIC
>   	select DRM_PANEL_BRIDGE
>   	select DRM_KMS_HELPER
>   	select DRM_GEM_DMA_HELPER
> +	select REGMAP
> +	select REGMAP_MMIO
>   	select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE
>   	help
>   	  Choose this option for DRM support for the Ingenic SoCs.

-- 
Jingfeng