Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Jun 2023 09:40:32 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Abhijit Gangurde <abhijit.gangurde@amd.com>
Cc:     nikhil.agarwal@amd.com, Nipun.Gupta@amd.com, geert@linux-m68k.org,
        linux-kernel@vger.kernel.org, git@amd.com, michal.simek@amd.com
Subject: Re: [PATCH v4] cdx: Replace custom mcdi logging with
 print_hex_dump_debug()
Message-ID: <2023061300-mouth-suffering-8c20@gregkh>
References: <20230613065231.19932-1-abhijit.gangurde@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230613065231.19932-1-abhijit.gangurde@amd.com>
Precedence: bulk

On Tue, Jun 13, 2023 at 12:22:31PM +0530, Abhijit Gangurde wrote:
> Replace custom mcdi logging for send and receive requests
> with dynamic debug method print_hex_dump_debug().
> 
> Fixes: eb96b740192b ("cdx: add MCDI protocol interface for firmware interaction")

This isn't a "fix", right?

> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
> Closes: https://lore.kernel.org/lkml/CAMuHMdWTCdQagFFANygMgA8D0sWaoGxWv2AjibC3vwSd0UxuRw@mail.gmail.com/

This wasn't a "bug report" this was a "the code should be changed to not
do this" type of thing.  Part of normal development.

Other than those nits, looks good, want to fix this up and resend a v5?

thanks,

greg k-h