Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2b73ec3e-43e6-4fd0-034c-7541b6f53443@linaro.org>
Date:   Tue, 13 Jun 2023 10:40:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] lvts_thermal.c: Drop error checking for
 debugfs_create_dir
Content-Language: en-US
To:     Osama Muhammad <osmtendev@gmail.com>, rafael@kernel.org,
        rui.zhang@intel.com, angelogioacchino.delregno@collabora.com,
        DLG-Adam.Ward.opensource@dm.renesas.com, amitk@kernel.org,
        wenst@chromium.org
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230530172439.13683-1-osmtendev@gmail.com>
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
In-Reply-To: <20230530172439.13683-1-osmtendev@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 30/05/2023 19:24, Osama Muhammad wrote:
> This patch removes the error checking for debugfs_create_dir
> in lvts_thermal.c. This is because the debugfs_create_dir()
> does not return NULL but an ERR_PTR after an error.
> The DebugFS kernel API is developed in a way that the
> caller can safely ignore the errors that occur during
> the creation of DebugFS nodes.The debugfs Api handles
> it gracefully. The check is unnecessary.
> 
> Link to the comment above debugfs_create_dir:
> https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L451
> 
> Signed-off-by: Osama Muhammad <osmtendev@gmail.com>

Is this patch tested ?


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog