Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935912AbXJPUNA (ORCPT ); Tue, 16 Oct 2007 16:13:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S935613AbXJPUMq (ORCPT ); Tue, 16 Oct 2007 16:12:46 -0400 Received: from nf-out-0910.google.com ([64.233.182.187]:30428 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935867AbXJPUMo (ORCPT ); Tue, 16 Oct 2007 16:12:44 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=F/jlnDE97XscnUwdJIGsH1cVNF8skQeNM13rui+PetcYkdyRJhh4KZyikmrRznj7Ot+bljT2jAjJhN1cTaIsj+8NOaLt7kZA9wze3JoOcP6roOZ93WgPfxxjWNnGv00TUyRTPZvwwLsuKQ6+LgpNpsXGXsmG5Yt0l3jvXQyouZA= Message-ID: Date: Tue, 16 Oct 2007 16:12:41 -0400 From: "Dmitry Torokhov" To: "Linus Torvalds" Subject: Re: [PATCH] Map volume and brightness events on thinkpads Cc: "Matthew Garrett" , "Henrique de Moraes Holschuh" , "Jeremy Katz" , linux-kernel@vger.kernel.org, davej@redhat.com In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1192481110-9299-1-git-send-email-katzj@redhat.com> <20071015210737.GA15293@khazad-dum.debian.net> <20071016130053.GA20010@srcf.ucam.org> <20071016141153.GA3237@khazad-dum.debian.net> <20071016142121.GA21431@srcf.ucam.org> <20071016143124.GB3237@khazad-dum.debian.net> <20071016144016.GA21749@srcf.ucam.org> <20071016165623.GA13643@khazad-dum.debian.net> <20071016184606.GB25181@srcf.ucam.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1597 Lines: 39 On 10/16/07, Linus Torvalds wrote: > > > On Tue, 16 Oct 2007, Matthew Garrett wrote: > > > > > > It still doesn't mean it belongs inside the stream of data for the keyboard, > > > maskerading as a key press. > > > > But it *is* a key press! > > To get somewhat back on track: volume and brightness (and similar - lid > close etc) events clearly are keypresses. > > However, I would also argue that a keypress that is acted on by the > firmware automatically is *different* from a keypress that hasn't been > acted on: one is a "key was pressed *and* hardware did something > automatically", and the other is just a "key was pressed" event. > > IOW, I think the thinkpad issue (and others like it) should be fixed by > splitting up the KEY_VOLUMEUP "key" into separate KEY_VOLUMEUP and > KEY_VOLUMEUP_NOTIFY key events, so that downstream user mode (and the > kernel itself, for that matter) can know whether it's a informational > message or whether it should be acted upon. I agree that these are 2 different events. My argument is that "VOLUME_UP_NOTIFY" event is similar to "BATTERY_OUT_NOTIFY", "DOCK_UNDOCK_NOTIFY", etc, etc and should be sent not through input layer but through a generic (yet to be designed) notification mechanism. Something lighter than input. Something like uevents over netlink. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/