Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Tue, 13 Jun 2023 11:16:24 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     =?utf-8?Q?Ond=C5=99ej?= Jirman <megi@xff.cz>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Vasily Khoruzhick <anarsoul@gmail.com>,
        Yangtao Li <tiny.windzz@gmail.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>, Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v2] thermal/drivers/sun8i: Fix some error handling paths
 in sun8i_ths_probe()
Message-ID: <4j74jv53tdf4n6txibl6xjh63dzzjr3ku3uoxhv3rzodthqbqy@25eho3f7wh6y>
References: <a8ae84bd2dc4b55fe428f8e20f31438bf8bb6762.1684089931.git.christophe.jaillet@wanadoo.fr>
 <ucnnixemxbpkjlbyenboydicslozt5jpyjjfbd4gjk4oye52et@fgyd3zqdqsh2>
 <u7mmywm63bm5q4zlsbnooeplscn4rrd3qnslkfq2xnquxgnkkd@n3tsnrutmfjp>
 <ad78c18e-13dd-fca3-1aff-5b8e68a91c90@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cjtzgc4xxdlkdkqv"
Content-Disposition: inline
In-Reply-To: <ad78c18e-13dd-fca3-1aff-5b8e68a91c90@linaro.org>
Precedence: bulk


--cjtzgc4xxdlkdkqv
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 13, 2023 at 10:49:24AM +0200, Daniel Lezcano wrote:
> On 15/05/2023 14:33, Ond=C5=99ej Jirman wrote:
> > Hi Maxime,
> >=20
> > On Mon, May 15, 2023 at 01:54:41PM +0200, Maxime Ripard wrote:
> > > Hi,
> > >=20
> > > On Sun, May 14, 2023 at 08:46:05PM +0200, Christophe JAILLET wrote:
> > > > Should an error occur after calling sun8i_ths_resource_init() in th=
e probe
> > > > function, some resources need to be released, as already done in the
> > > > .remove() function.
> > > >=20
> > > > Switch to the devm_clk_get_enabled() helper and add a new devm_acti=
on to
> > > > turn sun8i_ths_resource_init() into a fully managed function.
> > > >=20
> > > > Move the place where reset_control_deassert() is called so that the
> > > > recommended order of reset release/clock enable steps is kept.
> > > > A64 manual states that:
> > > >=20
> > > > 	3.3.6.4. Gating and reset
> > > >=20
> > > > 	Make sure that the reset signal has been released before the relea=
se of
> > > > 	module clock gating;
> > > >=20
> > > > This fixes the issue and removes some LoC at the same time.
> > >=20
> > > It should really be three different patches:
> > >   - One to fix the resource release, that can be backported to stable
> > >     releases
> > >   - One to switch to devm_clk_get_enabled
> > >   - and one to change the order of clock enable vs reset deassertion
> >=20
> > The order was correct before this patch. I don't think an incorrect ord=
er
> > should be intorduced, even if temporarily between two patches.
>=20
> Maxime ?

I agree with Ond=C5=99ej

Maxime

--cjtzgc4xxdlkdkqv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZIgz6AAKCRDj7w1vZxhR
xbFeAP9nZaUHBaCk2zpQ9spk1lWcNPRC8lzIl2Swc+pADkJzfwEAoEPaz8Vy5Osm
Q+TSMfTLQNJhVNyS2FSE4zt1fM4g9wc=
=Fa6+
-----END PGP SIGNATURE-----

--cjtzgc4xxdlkdkqv--