Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e05c4897-ea77-bd1e-0bdd-e897107a614f@redhat.com>
Date:   Tue, 13 Jun 2023 10:44:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] selftests: lib.mk: fix out-of-tree builds
Content-Language: en-US
To:     Muhammad Usama Anjum <usama.anjum@collabora.com>,
        Anders Roxell <anders.roxell@linaro.org>, shuah@kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        "open list : MEMORY MANAGEMENT" <linux-mm@kvack.org>,
        John Hubbard <jhubbard@nvidia.com>
Cc:     linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230613074931.666966-1-anders.roxell@linaro.org>
 <cf6eb3f1-276a-bdcc-7d63-7f4ab3f9cdce@collabora.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <cf6eb3f1-276a-bdcc-7d63-7f4ab3f9cdce@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 13.06.23 10:16, Muhammad Usama Anjum wrote:
> This patch needs to go through mm tree as the commit which it fixes is in mm.
> 
> On 6/13/23 12:49 PM, Anders Roxell wrote:
>> Since commit ("selftests: error out if kernel header files are not yet
>> built") got merged, the kselftest build correctly because the
>> KBUILD_OUTPUT isn't set when building out-of-tree and specifying 'O='
>> This is the error message that pops up.
>>
>> make --silent --keep-going --jobs=32 O=/home/anders/.cache/tuxmake/builds/1482/build INSTALL_PATH=/home/anders/.cache/tuxmake/builds/1482/build/kselftest_install ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- V=1 CROSS_COMPILE_COMPAT=arm-linux-gnueabihf- kselftest-install
>> make[3]: Entering directory '/home/anders/src/kernel/next/tools/testing/selftests/alsa'
>>
>> -e [1;31merror[0m: missing kernel header files.
>> Please run this and try again:
>>
>>      cd /home/anders/src/kernel/next/tools/testing/selftests/../../..
>>      make headers
>>
>> make[3]: Leaving directory '/home/anders/src/kernel/next/tools/testing/selftests/alsa'
>> make[3]: *** [../lib.mk:77: kernel_header_files] Error 1
>>
>> Fixing the issue by assigning KBUILD_OUTPUT the same way how its done in
>> kselftest's Makefile. By adding 'KBUILD_OUTPUT := $(O)' 'if $(origin O)'
>> is set to 'command line'. This will set the the BUILD dir to
>> KBUILD_OUTPUT/kselftest when doing out-of-tree builds which makes them
>> in its own separete output directory.
>>
>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> Please add fixes tag. ("selftests: error out if kernel header files are not
> yet built")
> 
> Tested-by: Muhammad Usama Anjum <usama.anjum@collabora.com>

This should get squashed into the original patch unless it's already in 
mm-stable (which it isn't) and we have a stable commit id.

-- 
Cheers,

David / dhildenb