Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230613093054.2067340-1-wenst@chromium.org> <3a840fbf-8250-9870-3caa-3e12c468aa24@linaro.org>
In-Reply-To: <3a840fbf-8250-9870-3caa-3e12c468aa24@linaro.org>
From:   Chen-Yu Tsai <wenst@chromium.org>
Date:   Tue, 13 Jun 2023 17:45:52 +0800
Message-ID: <CAGXv+5GWArqHok_ZcL=L9cMGfBnbP8vm26DM==F0i+6LQ24rxg@mail.gmail.com>
Subject: Re: [PATCH] thermal/drivers/generic-adc: Register thermal zones as
 hwmon sensors
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jun 13, 2023 at 5:44=E2=80=AFPM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> On 13/06/2023 11:30, Chen-Yu Tsai wrote:
> > Register thermal zones as hwmon sensors to let userspace read
> > temperatures using standard hwmon interface.
> >
> > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> > ---
> >   drivers/thermal/thermal-generic-adc.c | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/thermal/thermal-generic-adc.c b/drivers/thermal/th=
ermal-generic-adc.c
> > index 017b0ce52122..e95dc354f192 100644
> > --- a/drivers/thermal/thermal-generic-adc.c
> > +++ b/drivers/thermal/thermal-generic-adc.c
> > @@ -13,6 +13,8 @@
> >   #include <linux/slab.h>
> >   #include <linux/thermal.h>
> >
> > +#include "thermal_hwmon.h"
> > +
> >   struct gadc_thermal_info {
> >       struct device *dev;
> >       struct thermal_zone_device *tz_dev;
> > @@ -153,6 +155,12 @@ static int gadc_thermal_probe(struct platform_devi=
ce *pdev)
> >               return ret;
> >       }
> >
> > +     ret =3D devm_thermal_add_hwmon_sysfs(&pdev->dev, gti->tz_dev);
> > +     if (ret) {
> > +             dev_err(&pdev->dev, "Failed to add hwmon sysfs attributes=
\n");
> > +             return ret;
> > +     }
>
> Usually, if the hwmon registering fails this is not fatal.

Ack. I'll change it to dev_warn.

ChenYu