Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Jun 2023 12:34:36 +0300
From:   Matti Vaittinen <mazziesaccount@gmail.com>
To:     Matti Vaittinen <mazziesaccount@gmail.com>,
        Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc:     Matti Vaittinen <mazziesaccount@gmail.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] iio: light: bu27034: Fix scale format
Message-ID: <5369117315cf05b88cf0ccb87373fd77190f6ca2.1686648422.git.mazziesaccount@gmail.com>
References: <cover.1686648422.git.mazziesaccount@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="nu5zW1gmaBLRAMXS"
Content-Disposition: inline
In-Reply-To: <cover.1686648422.git.mazziesaccount@gmail.com>
Precedence: bulk


--nu5zW1gmaBLRAMXS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

The driver is expecting accuracy of NANOs for intensity scale in
raw_write. The IIO core is however defaulting to MICROs. This leads the
raw-write of smallest scales to never succeed as correct selector(s) are
not found.

Fix this by implementing the .write_raw_get_fmt callback to use NANO
accuracy for writes of IIO_CHAN_INFO_SCALE.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
Fixes: e52afbd61039 ("iio: light: ROHM BU27034 Ambient Light Sensor")
---
 drivers/iio/light/rohm-bu27034.c | 22 +++++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/light/rohm-bu27034.c b/drivers/iio/light/rohm-bu27=
034.c
index 846c3d43aa34..f737d62bdf92 100644
--- a/drivers/iio/light/rohm-bu27034.c
+++ b/drivers/iio/light/rohm-bu27034.c
@@ -572,7 +572,7 @@ static int bu27034_set_scale(struct bu27034_data *data,=
 int chan,
 		return -EINVAL;
=20
 	if (chan =3D=3D BU27034_CHAN_ALS) {
-		if (val =3D=3D 0 && val2 =3D=3D 1000)
+		if (val =3D=3D 0 && val2 =3D=3D 1000000)
 			return 0;
=20
 		return -EINVAL;
@@ -584,7 +584,7 @@ static int bu27034_set_scale(struct bu27034_data *data,=
 int chan,
 		goto unlock_out;
=20
 	ret =3D iio_gts_find_gain_sel_for_scale_using_time(&data->gts, time_sel,
-						val, val2 * 1000, &gain_sel);
+						val, val2, &gain_sel);
 	if (ret) {
 		/*
 		 * Could not support scale with given time. Need to change time.
@@ -621,7 +621,7 @@ static int bu27034_set_scale(struct bu27034_data *data,=
 int chan,
=20
 			/* Can we provide requested scale with this time? */
 			ret =3D iio_gts_find_gain_sel_for_scale_using_time(
-				&data->gts, new_time_sel, val, val2 * 1000,
+				&data->gts, new_time_sel, val, val2,
 				&gain_sel);
 			if (ret)
 				continue;
@@ -1213,6 +1213,21 @@ static int bu27034_read_raw(struct iio_dev *idev,
 	}
 }
=20
+static int bu27034_write_raw_get_fmt(struct iio_dev *indio_dev,
+				     struct iio_chan_spec const *chan,
+				     long mask)
+{
+
+	switch (mask) {
+	case IIO_CHAN_INFO_SCALE:
+		return IIO_VAL_INT_PLUS_NANO;
+	case IIO_CHAN_INFO_INT_TIME:
+		return IIO_VAL_INT_PLUS_MICRO;
+	default:
+		return -EINVAL;
+	}
+}
+
 static int bu27034_write_raw(struct iio_dev *idev,
 			     struct iio_chan_spec const *chan,
 			     int val, int val2, long mask)
@@ -1260,6 +1275,7 @@ static int bu27034_read_avail(struct iio_dev *idev,
 static const struct iio_info bu27034_info =3D {
 	.read_raw =3D &bu27034_read_raw,
 	.write_raw =3D &bu27034_write_raw,
+	.write_raw_get_fmt =3D &bu27034_write_raw_get_fmt,
 	.read_avail =3D &bu27034_read_avail,
 };
=20
--=20
2.40.1


--=20
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =3D]=20

--nu5zW1gmaBLRAMXS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmSIOCwACgkQeFA3/03a
ocXCAAf9ERi4KO6rwKLhEuFdPFdT/FdFqLaO52sZGLctWan4v97H2FXMfxftrlIF
qwpKynSIi8iXl4FHVqxqw6JfCjKbYhb77DOsxKiHdbGNRDDr2TtVzffT5iLZgUSY
vLnnA/QLdjYx1w9oRdP3TOWBW3rz+9oyhyvRerhYYbc2t3pq9Z6dLENHJ+nvvfD4
yN4i7EGiX/T1hEbTakYp142ZIv9eaLex4PV0yjpaCoTNwZPbYBZFrvAunAeJrnJB
HmczDnxqxn2YQc2Iiyb3ETv1qlqZgf1ata7edS3po8XAUPrxuP9bvlTA6Yzpl/ZH
TsoO/9EnLc2PCK1kt5cpCqe1+McSlg==
=jbbw
-----END PGP SIGNATURE-----

--nu5zW1gmaBLRAMXS--