Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Jun 2023 17:27:43 +0800
From:   Chester Lin <clin@suse.com>
To:     Markus Elfring <Markus.Elfring@web.de>
Cc:     kernel-janitors@vger.kernel.org, s32@nxp.com,
        linux-gpio@vger.kernel.org, opensource.kernel@vivo.com,
        Linus Walleij <linus.walleij@linaro.org>,
        Lu Hongfei <luhongfei@vivo.com>,
        LKML <linux-kernel@vger.kernel.org>, cocci@inria.fr
Subject: Re: [PATCH] pinctrl: nxp: Adjust error predicates for improved
 exception handling in s32_dt_node_to_map()?
Message-ID: <ZIg2j025xV7E6yI8@linux-8mug>
References: <20230606070201.14249-1-luhongfei@vivo.com>
 <fca44dcf-e632-fed6-aee9-03a5b0c6b1d9@web.de>
 <ZIgPl0UShltd0VEe@linux-8mug>
 <b6c1500b-c901-00c7-e1be-1fa0088972a3@web.de>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b6c1500b-c901-00c7-e1be-1fa0088972a3@web.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlNGeTh2RDRWY1phRm5BaVc3UHV4bTh6RC9Cc0Y2M29RaDVRelBJUlFxZnQz?=
 =?utf-8?B?NXFYWXFGanE1VmJkYzRudVpWM0JxVE1WRXBLRmxhWWZlVUc4TnlDWU5FVmEy?=
 =?utf-8?B?UlhjTFBHU3RTQnNSVXZqYTVxRVVUZGV4U1k3TU1HZE11d0lpSTU4TGFnckhD?=
 =?utf-8?B?V3MwZmREVjkwUHBqbytJSWtWUUtOcW5lR1ZFdVZxS1lKUk9jaERnUGpoQlFN?=
 =?utf-8?B?NGZxMnN3YUoyTklCYXR0TUFCT0ZPandNSXdzSkVQeldaeTYwUU9FcVc1VFVL?=
 =?utf-8?B?bm1ETTV4MlpLYTlESm1xMVlXQXljSW8zekNmNnZMbnIzK0EzeVpVOEFLc2pk?=
 =?utf-8?B?Y1FiblFIM2s3YUcyK1NHZFJyY2RWK3BselJNTEV2K3lGdWozQzlMRzJlYkJL?=
 =?utf-8?B?YWZ1RUhzNzRaQWVzU2ExU3J1WmlpZ3VIREhuczhCdWJJUk1TVXk4RThBcy9o?=
 =?utf-8?B?YzZrem03S1FTZHVlTkpSZHNxOXEwWHU1YVg1cFFXTEZlTUtWaUd2YVpzUW9s?=
 =?utf-8?B?MXduZUtnRVNkZHpvWENNWFFFOENLckZsWkdsNVVjejNsRFhneTdDSlJzOTZs?=
 =?utf-8?B?VmJQb0tOM1NRUWZZaDhaYjR4T0IyTWpaWkFib3pRT3BXMlVvOXpMOVl3R2JJ?=
 =?utf-8?B?dSs5R0xIR25BSCtOVHlSM3VkYlErNnZBUVhxMVZmekZXN0dqK2V2ZnZ4NUU4?=
 =?utf-8?B?TStCNm9Qd3Riang5b0xkcEhDL1VTUDRXVDR2VjNWSmZ6Y3V1Qm9UVEhyR2xh?=
 =?utf-8?B?eDhHN1FaQzlWWU1zRjFpZ0ttSXBwcnJiRENFVmw3WCtPUVlGNTJQYzV3WWpO?=
 =?utf-8?B?Ymg5eElVM3Y5UW8rSW1rZ2xlTzZMcGE5OGJQY0wwa0RQQzMzV0tBNEdoeHh4?=
 =?utf-8?B?U3dNSmJDOWxvK3RPbWEyaktsK1JqTWNaWGFmSVFaRUUyMlphbnlFQkJBeWhW?=
 =?utf-8?B?VlY3ME9uendIcWFkaTUzWUhPeTlMTWpNSTNlZFZPaUFRSU8zZXI4TDdLTTg0?=
 =?utf-8?B?aXpyakdpSGY4dTRhREl0WW41VlBuYnRJTzFkUUxZVElTbHVhak1rRm0zN0dY?=
 =?utf-8?B?UWVPQWRheEFvUnh3M2d1ZzEzQU1Va2FnWGlXcjJwcW9ISWRaak5DTjZ6dHpp?=
 =?utf-8?B?b2lvZ3UycFUxb0FzV3FLd1hCd3NYL1h1VE5oUm5obzlrc3VNcnZHdFpXNkNw?=
 =?utf-8?B?UTk0dm5ab0FMSzlscmhsR04zRnAwN2drNXU2YjVZbEJZK3J4SUxNWGpLV2hT?=
 =?utf-8?B?aWsvQ21rN3YwQnhKOGxad0M1bFhOeWxjMlVvUk1PcVJPSStReGxrenBFcnpM?=
 =?utf-8?B?L0VOcXZpQVVwNmo0b0RUY1hVZDZ2cnB6RHRoWDJycGFDb0xjbEdqNzUzTU9m?=
 =?utf-8?B?UlZad1J3NmVsemlCSXRVYnMvZ3VaRk9PajNUcmNaVGZMSk1iL0VMNGtaaFJR?=
 =?utf-8?B?RjMyZ0xnNFc5Z2VCYUdHVXJQVFo0eW8yMXJFY2hqd29XVjROakFYckdLeGdW?=
 =?utf-8?B?VFNOUUVlT2pwc2xpV1R6ejZDMjVLb3hwSnVTMFVKSDdxaXpaT0VVQy9aaGNB?=
 =?utf-8?B?WjQ0N0MzVWxScUd4SW9KSXB4VU5GblIxZmtqRzVIQnRaWXl0bUlyWHdLaTRG?=
 =?utf-8?B?K1NxTVU3VmE2YWNqQ0Jlei8ySUlPbDNic3NuaWE1aktNSlVWcVY5SmpNU0hD?=
 =?utf-8?B?SXkzcU91aHoxc0s2T3gzcDlzZTJGS2k0a1hubUtuOVgraW50Nk15NjBqZGJX?=
 =?utf-8?B?enZzblg1QmlOTHlFc3I0aUEzcCs5QkRSZVZUcHlOYUlaVHNBOStkMnVkTXV1?=
 =?utf-8?B?TU92dXFkL2tMV01jeFR1d1FwQ1F4VDlsaFliRlAvVVByRU1hT01lOVJBK015?=
 =?utf-8?B?ckJUcVdVdEI2RVE3em1OdFFjOXhJSFFMeVN1by9BOXh2Z3dSaHVDYTFEeU5x?=
 =?utf-8?B?bk9McVlrMDh2Mlo3SVpuVHdhQ1piOXdWOEtwdklhRzQ0dmtpOWs5MnRTcTRy?=
 =?utf-8?B?NDFQU0N6dlEzbWlvUzRIbVdCcVRVejVmZDd6eFB3OHVJRHlvOW5ZcGlzenBN?=
 =?utf-8?B?RE1hcUU5K3c1SE5HRGJjblRrSS9IN0RTbFZNZ3Y3Y2g3V3l5QWNKMHhGWXM2?=
 =?utf-8?Q?6NBs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63184f15-e080-4cb5-9c78-08db6bf074d5
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3439.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 09:27:50.1334
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T2xrPE277iKMAq+Ts+S86BJn/+xy3mZHGjeeIU1icgAbM0MdBkT20PTrRm11CePd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7653
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 13, 2023 at 11:15:22AM +0200, Markus Elfring wrote:
> >>> Ensure child node references are decremented properly in the error path.
> >> …
> >>> +++ b/drivers/pinctrl/nxp/pinctrl-s32cc.c
> >>> @@ -279,8 +279,10 @@ static int s32_dt_node_to_map(struct pinctrl_dev *pctldev,
> >>>  		ret = s32_dt_group_node_to_map(pctldev, np, map,
> >>>  					       &reserved_maps, num_maps,
> >>>  					       np_config->name);
> >>> -		if (ret < 0)
> >>> +		if (ret < 0) {
> >>> +			of_node_put(np);
> >>>  			break;
> >>> +		}
> >>>  	}
> >>>
> >>>  	if (ret)
> >>
> >> May the same error predicate be applied at two places here?
> >>
> >
> > I think these two error predicates can be combined together in another patch.
> 
> Are you going to reduce such error predicates so that exception handling
> can be improved another bit?
> 
Yes, I am. There will be a patch to improve these error predicates. Thanks for
your suggestion.

Regards,
Chester

> Regards,
> Markus