Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230609121649.88147-1-minhuadotchen@gmail.com>
In-Reply-To: <20230609121649.88147-1-minhuadotchen@gmail.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Tue, 13 Jun 2023 11:45:27 +0200
Message-ID: <CAMRc=Md9utfFY3Uimnn7XTiHma7GBBmKLPAc9Y735Mxt1McBWw@mail.gmail.com>
Subject: Re: [PATCH] gpio: davinci: make davinci_gpio_dev_pm_ops static
To:     Min-Hua Chen <minhuadotchen@gmail.com>
Cc:     Keerthy <j-keerthy@ti.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jun 9, 2023 at 2:16=E2=80=AFPM Min-Hua Chen <minhuadotchen@gmail.co=
m> wrote:
>
> This patch fixes the following sprse warnings:
>
> drivers/gpio/gpio-davinci.c:695:1: sparse: warning: symbol 'davinci_gpio_=
dev_pm_ops' was not declared. Should it be static?
>
> No functional change intended.
>
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
> ---
>  drivers/gpio/gpio-davinci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index aaaf61dc2632..1aed3ace0240 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -692,7 +692,7 @@ static int davinci_gpio_resume(struct device *dev)
>         return 0;
>  }
>
> -DEFINE_SIMPLE_DEV_PM_OPS(davinci_gpio_dev_pm_ops, davinci_gpio_suspend,
> +static DEFINE_SIMPLE_DEV_PM_OPS(davinci_gpio_dev_pm_ops, davinci_gpio_su=
spend,
>                          davinci_gpio_resume);
>
>  static const struct of_device_id davinci_gpio_ids[] =3D {
> --
> 2.34.1
>

Applied, thanks!

Bart