Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Jun 2023 12:34:55 +0300
From:   Matti Vaittinen <mazziesaccount@gmail.com>
To:     Matti Vaittinen <mazziesaccount@gmail.com>,
        Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc:     Matti Vaittinen <mazziesaccount@gmail.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] iio: light: bu27008: Fix scale format
Message-ID: <e4778b74cde41431f77bc8dd88ec18605da0b400.1686648422.git.mazziesaccount@gmail.com>
References: <cover.1686648422.git.mazziesaccount@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="8eb3CYBD1iP+J9nU"
Content-Disposition: inline
In-Reply-To: <cover.1686648422.git.mazziesaccount@gmail.com>
Precedence: bulk


--8eb3CYBD1iP+J9nU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

The driver is expecting accuracy of NANOs for intensity scale in
raw_write. The IIO core is however defaulting to MICROs. This leads the
raw-write of smallest scales to never succeed as correct selector(s) are
not found.

Fix this by implementing the .write_raw_get_fmt callback to use NANO
accuracy for writes of IIO_CHAN_INFO_SCALE.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>

---
Fixes tag not added because AFACS the bu27008 is not yet in any releases.
---
 drivers/iio/light/rohm-bu27008.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/light/rohm-bu27008.c b/drivers/iio/light/rohm-bu27=
008.c
index 489902bed7f0..80eb14ea8193 100644
--- a/drivers/iio/light/rohm-bu27008.c
+++ b/drivers/iio/light/rohm-bu27008.c
@@ -633,7 +633,7 @@ static int bu27008_try_find_new_time_gain(struct bu2700=
8_data *data, int val,
 	for (i =3D 0; i < data->gts.num_itime; i++) {
 		new_time_sel =3D data->gts.itime_table[i].sel;
 		ret =3D iio_gts_find_gain_sel_for_scale_using_time(&data->gts,
-					new_time_sel, val, val2 * 1000, gain_sel);
+					new_time_sel, val, val2, gain_sel);
 		if (!ret)
 			break;
 	}
@@ -662,7 +662,7 @@ static int bu27008_set_scale(struct bu27008_data *data,
 		goto unlock_out;
=20
 	ret =3D iio_gts_find_gain_sel_for_scale_using_time(&data->gts, time_sel,
-						val, val2 * 1000, &gain_sel);
+						val, val2, &gain_sel);
 	if (ret) {
 		ret =3D bu27008_try_find_new_time_gain(data, val, val2, &gain_sel);
 		if (ret)
@@ -677,6 +677,21 @@ static int bu27008_set_scale(struct bu27008_data *data,
 	return ret;
 }
=20
+static int bu27008_write_raw_get_fmt(struct iio_dev *indio_dev,
+				     struct iio_chan_spec const *chan,
+				     long mask)
+{
+
+	switch (mask) {
+	case IIO_CHAN_INFO_SCALE:
+		return IIO_VAL_INT_PLUS_NANO;
+	case IIO_CHAN_INFO_INT_TIME:
+		return IIO_VAL_INT_PLUS_MICRO;
+	default:
+		return -EINVAL;
+	}
+}
+
 static int bu27008_write_raw(struct iio_dev *idev,
 			     struct iio_chan_spec const *chan,
 			     int val, int val2, long mask)
@@ -756,6 +771,7 @@ static int bu27008_update_scan_mode(struct iio_dev *ide=
v,
 static const struct iio_info bu27008_info =3D {
 	.read_raw =3D &bu27008_read_raw,
 	.write_raw =3D &bu27008_write_raw,
+	.write_raw_get_fmt =3D &bu27008_write_raw_get_fmt,
 	.read_avail =3D &bu27008_read_avail,
 	.update_scan_mode =3D bu27008_update_scan_mode,
 	.validate_trigger =3D iio_validate_own_trigger,
--=20
2.40.1


--=20
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =3D]=20

--8eb3CYBD1iP+J9nU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmSIOD8ACgkQeFA3/03a
ocWAnwf/QwkW5XP56+q9/tOHL6thmq5bbQeoCwKDeWcLMuj9HiOQ7WQ67ekPswtI
aj2b/g0btom6/OY6kGxcHMFlGQ85MI/tFekupitxGrGnB+u7z6lRneh3d0ZSOp+j
oPF1PbUjC7pLDdv2udeFhWrlRNg0zAD+g40eAlDZcLwCKdqbvnWebJq6eka3gZaP
NFVucs8oC1eJHhuVRcW9o82+neadTfDljGxpG+Kiv/pxA6MXbUCH0TSB5eoOBBBt
C5/YtZTpbPE3BCDAuyEoW9eE1rdRszdZErD8Tdgjqp6HC4hUoBy3ymHokgmYuy5n
GiaLoLgDa9MGpyO6RJEO58kaYFzUcA==
=uMZ4
-----END PGP SIGNATURE-----

--8eb3CYBD1iP+J9nU--