Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5dde33b8-75ee-3de4-d694-d5700b9cc0a6@intel.com>
Date:   Tue, 13 Jun 2023 11:57:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v1] platform/x86/dell/dell-rbtn: Fix resources leaking on
 error path
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     <linux-acpi@vger.kernel.org>, <rafael@kernel.org>,
        <andriy.shevchenko@intel.com>, <pali@kernel.org>,
        <hdegoede@redhat.com>, <markgross@kernel.org>,
        <fengguang.wu@intel.com>, <dvhart@linux.intel.com>,
        <platform-driver-x86@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
References: <20230612090250.1417940-1-michal.wilczynski@intel.com>
 <27dfd35-1d9d-b52f-ee7-1a5b9b25794@linux.intel.com>
From:   "Wilczynski, Michal" <michal.wilczynski@intel.com>
In-Reply-To: <27dfd35-1d9d-b52f-ee7-1a5b9b25794@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sk9NMVpnOWtZUDkxQXIwQXk3bnlpTWs1UytjNWJwekxpNC9qb3lWT3puZ0dY?=
 =?utf-8?B?R0ZsNlR2L1pNZEF5OFNuRXkxNzRvSk5YT3E1SGZlYnc1emF6QUVNR3RkSld6?=
 =?utf-8?B?SnpsaEFnN2tKcFZYVFRsb0FHZGphTEx3bXNtZGpFZjc3aHlQeVM0Y2ppSkRn?=
 =?utf-8?B?N2lRcS9zY083Nnh0R0NoNkJjbURoY1BCTVdKeFpsMit6WXVGbVVBVUV4cmw1?=
 =?utf-8?B?VElUT04ybUc2L09qQnJvekUzNGlFVjFuMDlIQkRSNW1TRzJGQW8xUHZ5NUM5?=
 =?utf-8?B?YmdrRWczc2lHYWxVWXIyWDFjUUNLeFByakJidjZ2cnc4Zkh5TnA3MnhoT0lD?=
 =?utf-8?B?NnVQTjFFa3RnaG5hMWdzOC80UGw1bXgreHJHSVRRQkJaWTI1bmdRQTdNeVNZ?=
 =?utf-8?B?Q1d5NkxwcUYyU2tUdTRWTXFlaXFkL2VqS3hPZ1ZFOXBWQkM0UTVhTUUyOEk5?=
 =?utf-8?B?VGprbVFsdVlhS3R1RVVkN3FMZGVTcTFjcGVLR29iZjRkM24yWGFPbE9PVE9N?=
 =?utf-8?B?Vy9GcUNkaGlxc2lxLy9wSkRreXE4Zmw1ci94Rk9GeVczcHRhWVR1cmVuMEV6?=
 =?utf-8?B?dGZ1SWFRSmNrMzI1bElNY0g2V2RaSzV3V2swVjVNMXhZQ1Bic0NDNHhCc1pz?=
 =?utf-8?B?eHp6QXFISUhNTmxpVmw1QXpMclR5bStkTTU0Yzg2dEQzc1JWUTIyUmM0cjdF?=
 =?utf-8?B?c1hvNGVISTFrUFI3MDI0a1FtQjc3ZTUrdW1pVS85em5vazEyUDFxY0pqdEtR?=
 =?utf-8?B?SFp6azNXemZZS25oMksyOXFESDVOMXBjTmFZSXRmMVhuQkMyTjdxSjZVZGgv?=
 =?utf-8?B?REdvejc2aitFNnJOUk9hUFB2eW1CM2tpdmw4c0JEZVNxTmJiRk81MUk2c0lI?=
 =?utf-8?B?Y1V0ekREQ05SNlBGZFlaZEtZK3hHblFJNlVyUmxkQ2J0VUFMaHJWQmJ0UTdD?=
 =?utf-8?B?T3Z1QVluVVpkZkpZUmZCdU15R254RU9HdnhoR0ZnZjE0NlFjZGlwSXZtekV2?=
 =?utf-8?B?bFZSQVZqTzk2aFNxNVNxK2hWNG56WS9NdUJIc0VJeHhnRWFwYlNvUkpEYWVL?=
 =?utf-8?B?ZWhwWnMwUHh2UUt0aG9vWC9ua3lNQ2dPTThicEhUaTcvTEMvU0puSW5GNGhU?=
 =?utf-8?B?dHg4NWg1M2lOYlZUb2F2aFZWRkRYbG1DcVFLOUlLTzRxU3kzRGxXMWorNmRo?=
 =?utf-8?B?ejFXVHhWeVY3UlJpem1zRGUxNnJUdFdPVHd3eXBiUmtXQ2tLYmg0REpJcm9G?=
 =?utf-8?B?a21MSGp4RjRJc0J1NmZ3QzUremFEYXFHWFBaSDFOUDZ1WDU3Q1VmUXlmWEJE?=
 =?utf-8?B?TTF4UlhHWWEzc1RlcC9yVkNqdDdPQ0QrQkJzTC9OQ1h1NDBzSkF4dFNwcEFs?=
 =?utf-8?B?NUlTd3BoeWxOY1RsWG9nZGpFcENkN2IzeGFBZ1RibGVpMmZWVGowdnV4eUIx?=
 =?utf-8?B?a1d3RVIwSkZLeXhIczlIR0VMcmdGK09NdEllVjR5elRwb0doaGFpOVdWM2pX?=
 =?utf-8?B?ZnlNUXlLekRIQm9ld3VnUloxSEh6SlBhd3Vsc2hGeUg2d21sVFV3eDNINGV2?=
 =?utf-8?B?NkU2aVhUS1BWYkc1eEpFRUdNcXNSWkNwZzB2N3F5QXlXL3RZTUptYWprZThm?=
 =?utf-8?B?Z1VheGxxYktNTTJsMER0cVF6MUx6eXZzaTBPNjZuT1czS0k5TGViaUkvUFA3?=
 =?utf-8?B?Q0FJcVg4UWdMTXJCQkRJRm5SZkxyQUY3TUZwNFVwUWNjaGw4djJGbE8rSUFS?=
 =?utf-8?B?U3ptczdQRzVyZnRUdXEzT1Q5SVRSOU93L3E4dWRVa3cxc3kvKzdpRTRjR0h2?=
 =?utf-8?B?ODJDQUdYcWZHMHdwV0tDQWtNTnZGRjVXcDBEUzY3RHArdlNRMWxNckZOR1Y4?=
 =?utf-8?B?bW5jd1ZreEc1UGkyKzNnYllJM3d6clQrRWdQbGRlcUdTVWdMbmV2WjVRVkVO?=
 =?utf-8?B?c2dmSzFKSVlIK0Q3a3NYOXhiRDdrTnNtVnVhdkJ4TUpidVdKekJaSmtHdGpL?=
 =?utf-8?B?Vml6MU41amo2TXlzZnFldERxZ3NaTCtWak0rZzhQTXdTV1pKRjVSMFZudUJv?=
 =?utf-8?B?bVdsdlEvbVdVZVh4Uk5KVW53Q3BnZTdtbkVzdmY5cHlQUmV5V0RvQ0Iwc3BH?=
 =?utf-8?B?MThnSXZIZ3RSbWNiWGN3U1Y5UUdoaWxnZ05peSsySHM5WmNFbWdFUEc0dWVI?=
 =?utf-8?B?R0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cf25fdb7-7774-4db0-8b79-08db6bf4a5ba
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 09:57:50.2462
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5iDBq0C6SwseLfu/JVhq0DGy/7A88qbWHmB0lSE9epb+t/CGfMC9z0GQh/0IZiHCyD4/94JkBcsg73NNwq2XGMkXUXogEyvnj9NB/JbjI+c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7351
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/13/2023 11:28 AM, Ilpo Järvinen wrote:
> On Mon, 12 Jun 2023, Michal Wilczynski wrote:
>
>> Currently rbtn_add() in case of failure is leaking resources. Fix this
>> by adding a proper rollback. While at it, remove unnecessary assignment
>> of NULL to device->driver_data and unnecessary whitespace, plus add a
>> break for the default case in a switch.
>>
>> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>> Fixes: 817a5cdb40c8 ("dell-rbtn: Dell Airplane Mode Switch driver")
>> Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>>  drivers/platform/x86/dell/dell-rbtn.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/platform/x86/dell/dell-rbtn.c b/drivers/platform/x86/dell/dell-rbtn.c
>> index aa0e6c907494..e9b3f9c3ab7d 100644
>> --- a/drivers/platform/x86/dell/dell-rbtn.c
>> +++ b/drivers/platform/x86/dell/dell-rbtn.c
>> @@ -420,10 +420,12 @@ static int rbtn_add(struct acpi_device *device)
>>  		break;
>>  	default:
>>  		ret = -EINVAL;
>> +		break;
>>  	}
>> +	if (ret)
>> +		rbtn_acquire(device, false);
>>  
>>  	return ret;
>> -
>>  }
>>  
>>  static void rbtn_remove(struct acpi_device *device)
>> @@ -442,7 +444,6 @@ static void rbtn_remove(struct acpi_device *device)
>>  	}
>>  
>>  	rbtn_acquire(device, false);
>> -	device->driver_data = NULL;
>>  }
>>  
>>  static void rbtn_notify(struct acpi_device *device, u32 event)
> I'm a bit worried the stable people might not like "these while at it 
> parts". Those changes too are all good but unrelated to the actual fix so 
> they should appear in their own patches.

Hi, thanks for you input,
Changes seemed really minor and inconsequential, so it seemed to me like it would be an
overkill to create a separate patch for a cosmetic change.


>