Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230613054601.31566-1-kimseer.paller@analog.com> <20230613054601.31566-2-kimseer.paller@analog.com>
In-Reply-To: <20230613054601.31566-2-kimseer.paller@analog.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 13 Jun 2023 12:57:07 +0300
Message-ID: <CAHp75Vfk2=rYh7GO5XUV8cr3C+3nwu4-PfxxVDuG3Vj0a6b=XQ@mail.gmail.com>
Subject: Re: [PATCH v4 2/2] iio: adc: max14001: New driver
To:     Kim Seer Paller <kimseer.paller@analog.com>
Cc:     jic23@kernel.org, lars@metafoo.de, lgirdwood@gmail.com,
        broonie@kernel.org, Michael.Hennerich@analog.com,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jun 13, 2023 at 8:46=E2=80=AFAM Kim Seer Paller
<kimseer.paller@analog.com> wrote:
>
> The MAX14001 is a configurable, isolated 10-bit ADC for multi-range
> binary inputs.

...

> +struct max14001_state {
> +       struct spi_device       *spi;
> +       /*
> +        * lock protect agains multiple concurrent accesses, RMW sequence=
, and

against

> +        * SPI transfer
> +        */
> +       struct mutex            lock;
> +       int                     vref_mv;
> +       /*
> +        * DMA (thus cache coherency maintenance) requires the
> +        * transfer buffers to live in their own cache lines.
> +        */
> +       __be16                  spi_tx_buffer __aligned(IIO_DMA_MINALIGN)=
;
> +       __be16                  spi_rx_buffer;
> +};
> +
> +static int max14001_read(void *context, unsigned int reg_addr, unsigned =
int *data)
> +{
> +       struct max14001_state *st =3D context;
> +       int ret;
> +
> +       struct spi_transfer xfers[] =3D {
> +               {
> +                       .tx_buf =3D &st->spi_tx_buffer,
> +                       .len =3D 2,

sizeof()

> +                       .cs_change =3D 1,
> +               }, {
> +                       .rx_buf =3D &st->spi_rx_buffer,
> +                       .len =3D 2,

sizeof()

> +               },
> +       };
> +
> +       st->spi_tx_buffer =3D bitrev16(cpu_to_be16(FIELD_PREP(MAX14001_AD=
DR_MASK,
> +                                                               reg_addr)=
));
> +
> +       ret =3D spi_sync_transfer(st->spi, xfers, ARRAY_SIZE(xfers));
> +       if (ret)
> +               return ret;
> +
> +       *data =3D bitrev16(be16_to_cpu(st->spi_rx_buffer)) & MAX14001_DAT=
A_MASK;
> +
> +       return 0;
> +}

...

> +static const struct iio_chan_spec max14001_channels[] =3D {
> +       {
> +               .type =3D IIO_VOLTAGE,
> +               .channel =3D 0,

Is it required?

> +               .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW) |
> +                                     BIT(IIO_CHAN_INFO_SCALE),
> +       }
> +};

--=20
With Best Regards,
Andy Shevchenko