Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1021926rwd; Tue, 13 Jun 2023 03:54:03 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5q+GVd/MFaXbpKOcr3dDQluWNOg4WZMaJn3txYlQhuWrgQY9DdPSV3JZcaYO5eohCiquOZ X-Received: by 2002:a05:6a00:228f:b0:64a:ff32:7349 with SMTP id f15-20020a056a00228f00b0064aff327349mr14991590pfe.32.1686653643021; Tue, 13 Jun 2023 03:54:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686653643; cv=none; d=google.com; s=arc-20160816; b=Btg4ECigmdwrOGTMKX8UhifkQ0CsM+kpt1aWJLasn/kWwx8lssdCQMpKX69Cyq3KIr IXi/f5ARi5xFjhyq19jRToGmeDKMfNt0IWbgEvx5gSqMCKY6AxwiTRD4BakTkRg3LzyN lS4dDtxawGuvEQNCrKAHZE7qN2YxfaYZcNm1+6WI2HDKfki6vPw6zUZ5s7qp38yuH7J7 pV/yEhOP3h7vYgnGHxy82JpGhlEFDQhTJAtzfTOTD24MQCo2bSLuUCBnzygA8E3Q1FE6 tdeiyxc2FFQICeABlfXBzZg2XAVZ02A8zhyYJdb3oNJSty/jKEk9R/y5++kcU0FzpXNT vt0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=FcIqiwGu4sLEkTe056TBYKLsIuMHS5/22uZLcaXmrIg=; b=XkqbKWxGARGb7itJyPtC3m/NPv2Vlh0oP1RPQCqj/JeOUmcpAfq99gWBTQnoiY8M0b 2ZJNGmQAGfYaiHF+dUs+lOBIVxkZcedrOpaPiTfC2/+2fFdUhcGgHjmvY6ruO6HEtgSG BCam8C6onjWn0R+GmLbMiBCyHCuuKhbFaWus6v6r62dLxr51wuTO8yfLsmDJMH72vIcd 1lqF1xejS1B2IFYxeRXFtlLCZ/YIm2p10LDuGiRjKfWswnrV0byal3yHXs3mtFIZi1m6 mWvSbX8PCFR/+8hwGZwkJbka9Bos7AtKYxGSaEK8CA7zwfXxTdc+3TTyLfgFmBdyKUVJ E+mQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=q38P38oF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h11-20020a65480b000000b0054402b987f8si8324745pgs.605.2023.06.13.03.53.50; Tue, 13 Jun 2023 03:54:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=q38P38oF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241265AbjFMKhk (ORCPT + 99 others); Tue, 13 Jun 2023 06:37:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240642AbjFMKhg (ORCPT ); Tue, 13 Jun 2023 06:37:36 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 882F0187 for ; Tue, 13 Jun 2023 03:37:34 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-4f6255ad8aeso6594394e87.2 for ; Tue, 13 Jun 2023 03:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686652653; x=1689244653; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FcIqiwGu4sLEkTe056TBYKLsIuMHS5/22uZLcaXmrIg=; b=q38P38oFNz436rbtz93StwiYL/vFP7MMNqPeNIqejeYdXIrrCA3boHSyNWjxCLq+yT dL/m53B2SwFPNECbkZSRBytuIDffRItcWoVo+WlXh39G5Czhu9zYzZNMndOPjJyGARt5 kbl072mpM6tDiMEqdz247ltufPd3+4qHo6Oeg9xmLT5SlA1fjzpla2uhD6mm/axrTWYJ izBLn9ywFt38UPfmPSDd7ZYJOXCxjbaWU5b05peQOck/vQznRpGC6CifT0xizIH1bxmu Tgoj9P9zSDjP2ZN4rY88dTvxN0xd364jYAjGfSlb2E2YQE15gsbGsvyx1gRL5t7XbU0j m4FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686652653; x=1689244653; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FcIqiwGu4sLEkTe056TBYKLsIuMHS5/22uZLcaXmrIg=; b=Z1tNy51eTdTiX14kbeYWLDn4a5f9tG90sHe5Xpmgno3ukSZR07lkQKVNQ+6cbvOzCY 9xeNXajxuw6UBTpV9ND5Q7lNfMDhhF5BheQrIcr7cz6sO7boAym7X00yJgxUm7Xtw0gi N0wTGUbYQ7pgDcho54uZkgv1slZRD2b2anQoUd4jA1Bpl2OyDbCHK7n6QEvy8XNeBOYH m8a7LUbLcoh3x34LE+5bZEsRKyeWW1zzkwwWfxjdoP9Zt8B3w6I5T2nWJmDez0gccwoe LN4qSmP8XXNr6Wt+t9hrhUKlV/9/Tji3T8bdikHHH3N1mzFaWYp2UvuuXMMZhdCC2a+j rblQ== X-Gm-Message-State: AC+VfDwmFyYJCWkJb+7l6wnJ8JiDFDklIns1bkixWh0OsyqSOpcyfl/d Gk5M3SuaKE87UAX1QXh/c7gwBQ== X-Received: by 2002:a19:2d4e:0:b0:4f3:93d6:377b with SMTP id t14-20020a192d4e000000b004f393d6377bmr4733972lft.37.1686652652707; Tue, 13 Jun 2023 03:37:32 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id k9-20020a7bc409000000b003f6050d35c9sm13973436wmi.20.2023.06.13.03.37.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 03:37:32 -0700 (PDT) Date: Tue, 13 Jun 2023 11:37:30 +0100 From: Daniel Thompson To: Thomas Zimmermann Cc: daniel@ffwll.ch, javierm@redhat.com, sam@ravnborg.org, deller@gmx.de, geert+renesas@glider.be, lee@kernel.org, jingoohan1@gmail.com, dan.carpenter@linaro.org, michael.j.ruhl@intel.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Laurent Pinchart , stable@vger.kernel.org Subject: Re: [PATCH v2 01/38] backlight/bd6107: Compare against struct fb_info.device Message-ID: <20230613103730.GA169438@aspen.lan> References: <20230612141352.29939-1-tzimmermann@suse.de> <20230612141352.29939-2-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612141352.29939-2-tzimmermann@suse.de> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 12, 2023 at 04:07:39PM +0200, Thomas Zimmermann wrote: > Struct bd6107_platform_data refers to a platform device within > the Linux device hierarchy. The test in bd6107_backlight_check_fb() > compares it against the fbdev device in struct fb_info.dev, which > is different. Fix the test by comparing to struct fb_info.device. > > Fixes a bug in the backlight driver and prepares fbdev for making > struct fb_info.dev optional. > > v2: > * move renames into separate patch (Javier, Sam, Michael) > > Fixes: 67b43e590415 ("backlight: Add ROHM BD6107 backlight driver") > Signed-off-by: Thomas Zimmermann > Cc: Laurent Pinchart > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: dri-devel@lists.freedesktop.org > Cc: # v3.12+ > Reviewed-by: Javier Martinez Canillas Reviewed-by: Daniel Thompson Daniel. PS Please don't treat this as an Acked-by, if you want to land this patchset via a single tree please coordinate with Lee Jones!