Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1041237rwd; Tue, 13 Jun 2023 04:10:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6prGL2aOqqAbYEA0Mk9u3Ej448czKjY7FCDsKlGAd0EiHiVwqNicKlnsswE2q0IUl/gyri X-Received: by 2002:a17:907:368d:b0:961:78c2:1d27 with SMTP id bi13-20020a170907368d00b0096178c21d27mr13655845ejc.19.1686654614453; Tue, 13 Jun 2023 04:10:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686654614; cv=none; d=google.com; s=arc-20160816; b=mo6DNNdgKrBZ1dJtKDGNbZuzLgjUBQiarYNuIXRwWAj1nP+raPUnJIUFbdInBY18Dj pmYEw6Sjo7O//plFRdl2IudQMcmDshziEAX1SkYrwOC66bIMIyfUV08kO51cdpsAFn7g /2zk1WtPefWMVzEkD6Aug9jai23IdWggtZJtl0aXWmm5Td5POAVQLvrpfOdiX85gxDAN PE1ycuwg7T747MdnsphYCkYQiW4Sgm088Yt9yUMU5u3i2j1PFI4bZRZRScu31qbh8PPM m2RGJn3WiIM73F9zd6bD3fSQG1O88/Py444cloRDgkS9CeKak7xOvG2VF2my94ZGg4IA ZCiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=L+0q/8B3X2O+bLieXF8c9g+8ohNwELNU1kRNH19cJQQ=; b=I5Z5QDABlWrT7km8Z+v8IDDLwE2FCIIW9seoqnZXcaTYwo+somt2q7aUVy5gZnd4y8 n/11vyycQ0foQZCMi/BbyFDa8nSCjpUgmqmz2SkaLveRTqIs2Jbd87SO3y0QeiERNmm8 dN6XrYFWsS5o0R2HD1hC7mwqWv4BQmBG4a/XGYZW8B11DtM5DZ94ERAwGZ653kwWpmls rO3RO74nZNgXZzmNb/2jEafWjjI7UPX1nQrK9h0Fn2SoSG2Q6de4awWm1LmgU9qmSHk2 LRWAdzYz1GJ5YA45XsjoKeylfaHlflNJdQpPhL//0A/iiK6DGhjiUHvuakVJE/Qn/EwO mZkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mp5t8BFs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f8-20020a1709062c4800b00976b9d5d985si6203394ejh.177.2023.06.13.04.09.44; Tue, 13 Jun 2023 04:10:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mp5t8BFs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241033AbjFMKkM (ORCPT + 99 others); Tue, 13 Jun 2023 06:40:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241894AbjFMKjm (ORCPT ); Tue, 13 Jun 2023 06:39:42 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C9ACE69 for ; Tue, 13 Jun 2023 03:39:40 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-30fc26affa9so1503519f8f.0 for ; Tue, 13 Jun 2023 03:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686652779; x=1689244779; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=L+0q/8B3X2O+bLieXF8c9g+8ohNwELNU1kRNH19cJQQ=; b=mp5t8BFsJLvB4B2RBPo6x6uNyPCi8jDPJJpT5/LpidCyzOQv4FCXKrMWr1ZoGeWb2S 1dBOQjE7wNbB2/NIq8xC5IgXRwNRGlVnZW3Z4RXFfWXN3WDAjIuuNAySekfhnk34w5wO NzDIjtTF8SXSuX25qLMn3huo8p/83/zQMv/5E4FEAXUWYyMCx8Mo+LAzcn9buVVIEf25 xq6WyCppmw0R4kg6OL44jDGiDE0u+RRVrPQ0ZksXnqIcz16sfbXTylvjE97DH2Pg1vn+ u4HS9GU54OKGBiesVcpBbKbzyQtzvsmO+sXxWBrgzd+eRZlTzu8i2amAs2BDVfmzc8Gh L22w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686652779; x=1689244779; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L+0q/8B3X2O+bLieXF8c9g+8ohNwELNU1kRNH19cJQQ=; b=PylOAspWb/H2JZ6NSGV3vA0V9YrkHQ3zVxqXWJYxMrhBOJDf+D05bEiAa+JyTBpJ6F GAu3rZ4j9KGf66jCnkY5W49+dijuwpv8r8rsCTcPGHLZcjr1V/XTfJhNai+i9Drj+hn0 fw2d3TTBNsg6mlCJ+920RSNTgoDCVO1KFBXJbJOiq9DgSK1Wwmx5bAoG30saetaZlaKM L2RlFv2IGvLiR36pUy8KndBMwwMw/gbBmAoK9bBXMTtF3gf+9ydlg43xTYyDFsVErorq t2wjuzVnN5GHCfKcncgHraEF0+bsLOZqF31KQ2QSn6A4Bn+tv5FvwYNK3JfW/VEpWhQA S9dw== X-Gm-Message-State: AC+VfDzezwBcGS9cuGlxmKJeG5OjvBAI8hQS7nXJdEH3Wjv2qgtxuzqz NH5n1OuGbcGHH7IEaPlonjzBPQ== X-Received: by 2002:a5d:508a:0:b0:30f:caf6:5bde with SMTP id a10-20020a5d508a000000b0030fcaf65bdemr1780025wrt.32.1686652779043; Tue, 13 Jun 2023 03:39:39 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id h2-20020a5d5482000000b0030fbc96bdffsm7123579wrv.25.2023.06.13.03.39.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 03:39:38 -0700 (PDT) Date: Tue, 13 Jun 2023 11:39:36 +0100 From: Daniel Thompson To: Thomas Zimmermann Cc: daniel@ffwll.ch, javierm@redhat.com, sam@ravnborg.org, deller@gmx.de, geert+renesas@glider.be, lee@kernel.org, jingoohan1@gmail.com, dan.carpenter@linaro.org, michael.j.ruhl@intel.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Laurent Pinchart , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , stable@vger.kernel.org Subject: Re: [PATCH v2 05/38] backlight/lv5207lp: Compare against struct fb_info.device Message-ID: <20230613103936.GE169438@aspen.lan> References: <20230612141352.29939-1-tzimmermann@suse.de> <20230612141352.29939-6-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612141352.29939-6-tzimmermann@suse.de> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 12, 2023 at 04:07:43PM +0200, Thomas Zimmermann wrote: > Struct lv5207lp_platform_data refers to a platform device within > the Linux device hierarchy. The test in lv5207lp_backlight_check_fb() > compares it against the fbdev device in struct fb_info.dev, which > is different. Fix the test by comparing to struct fb_info.device. > > Fixes a bug in the backlight driver and prepares fbdev for making > struct fb_info.dev optional. > > v2: > * move renames into separate patch (Javier, Sam, Michael) > > Fixes: 82e5c40d88f9 ("backlight: Add Sanyo LV5207LP backlight driver") > Signed-off-by: Thomas Zimmermann > Cc: Laurent Pinchart > Cc: Yoshinori Sato > Cc: Rich Felker > Cc: John Paul Adrian Glaubitz > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: linux-sh@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: # v3.12+ > Reviewed-by: Javier Martinez Canillas Reviewed-by: Daniel Thompson Daniel.