Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e9bf9658-216f-a882-c699-858c41892451@linaro.org>
Date:   Tue, 13 Jun 2023 12:53:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH 1/3] arm64: dts: qcom: sc8180x: Add USB Type-C of_graph
 anchors
Content-Language: en-US
To:     Bjorn Andersson <quic_bjorande@quicinc.com>,
        Bjorn Andersson <andersson@kernel.org>,
        Vinod Koul <vkoul@kernel.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230612221456.1887533-1-quic_bjorande@quicinc.com>
 <20230612221456.1887533-2-quic_bjorande@quicinc.com>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20230612221456.1887533-2-quic_bjorande@quicinc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 13.06.2023 00:14, Bjorn Andersson wrote:
> Define anchors for wiring up the USB Type-C graph in the board files.
> 
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sc8180x.dtsi | 48 +++++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
> index a7668f9e68d6..4144beb70cb4 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
> @@ -2464,6 +2464,23 @@ usb_prim_qmpphy: phy@88e9000 {
>  
>  			status = "disabled";
>  
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +
> +					usb_prim_qmpphy_out: endpoint {};
> +				};
> +
> +				port@2 {
> +					reg = <2>;
> +
> +					usb_prim_qmpphy_dp_in: endpoint {};
> +				};
> +			};
> +
>  			usb_prim_ssphy: usb3-phy@88e9200 {
>  				reg = <0 0x088e9200 0 0x200>,
>  				      <0 0x088e9400 0 0x200>,
> @@ -2513,6 +2530,23 @@ usb_sec_qmpphy: phy@88ee000 {
>  
>  			status = "disabled";
>  
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +
> +					usb_sec_qmpphy_out: endpoint {};
> +				};
> +
> +				port@2 {
> +					reg = <2>;
> +
> +					usb_sec_qmpphy_dp_in: endpoint {};
> +				};
> +			};
> +
>  			usb_sec_ssphy: usb3-phy@88e9200 {
>  				reg = <0 0x088ee200 0 0x200>,
>  				      <0 0x088ee400 0 0x200>,
> @@ -2607,6 +2641,11 @@ usb_prim_dwc3: usb@a600000 {
>  				snps,dis_enblslpm_quirk;
>  				phys = <&usb_prim_hsphy>, <&usb_prim_ssphy>;
>  				phy-names = "usb2-phy", "usb3-phy";
> +
> +				port {
> +					usb_prim_role_switch: endpoint {
> +					};
> +				};
>  			};
>  		};
>  
> @@ -2659,6 +2698,11 @@ usb_sec_dwc3: usb@a800000 {
>  				snps,dis_enblslpm_quirk;
>  				phys = <&usb_sec_hsphy>, <&usb_sec_ssphy>;
>  				phy-names = "usb2-phy", "usb3-phy";
> +
> +				port {
> +					usb_sec_role_switch: endpoint {
> +					};
> +				};
>  			};
>  		};
>  
> @@ -2986,6 +3030,8 @@ dp0_in: endpoint {
>  
>  					port@1 {
>  						reg = <1>;
> +						mdss_dp0_out: endpoint {
> +						};
>  					};
>  				};
>  
> @@ -3060,6 +3106,8 @@ dp1_in: endpoint {
>  
>  					port@1 {
>  						reg = <1>;
> +						mdss_dp1_out: endpoint {
> +						};
>  					};
>  				};
>