Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1052457rwd; Tue, 13 Jun 2023 04:19:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ofMB8tvX31kYcAPukMCDeCByBJlufT9faLu6C4/pwMIBLwolHNnOSdK/QVAsCRfeZSkBy X-Received: by 2002:a17:902:e74c:b0:1b0:3f89:9836 with SMTP id p12-20020a170902e74c00b001b03f899836mr9502156plf.22.1686655182034; Tue, 13 Jun 2023 04:19:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686655182; cv=none; d=google.com; s=arc-20160816; b=WPByIFS0t3ydNWDUdu1KBHcxfUTfdoxUeKzQ8RUcGRckCSNzhYUMNgecUgGNuoEqXi ZBhM/dHol/FnTctMETrSK03qlcvwOV4krKzTcBloJTcsVi5PyirUmhRDNBMtR2YCg25W 75FzuRYNL7brMN07Zf4pjT1hLymOGj1rmCnU+WqTRFr5LCxV7cfbK+yfZUogNQgHnG6L GfxN+vOXfAE7qeHxXUWJdzwu+PspmDrpdHoLQaBdU6xGnuUj1nND0N6hbtDkvHVsHmhI IF6BFV4dTBMm/6wBy/fIx8GICJXqeIJGS6UIc1UdTFUqjF+qoaOiGP/PEjQnHMJPIRlf MCZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=x+Pej+DjtuslhRkqSbqykfmY3R1IGvKyLMb1wCzPsnA=; b=wol4f9ksDSP8ogxbVT3W+2075qSp+UkCuSbvQ0P1qOnop1yez06YkhRpxxjRavZC4a OaRuTZbDQbN4rGrroaveavhZJLfymk6CDgAkixmDghs6qS3alKU3BWPVopIVIBUv4MJz D9TTLm3RA3M8Jf1Erd8Lx11pj3cKau4oGKClYuKh2MnRQp/HnPVmEOWd051ARVEZWQP/ WVdQKOMd6/RGSLgSNoAqVUHXM9es7+MTl5QHqzA5U45UOt10WhZF6KpIGtyUI7NALAWT 6Ih2kI0irDhuYo5Ie6ikkhzQutK6wbef1JYt2ZQvEPrrYox4cNmPZrDNy3kFzjGROkOK xhcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="DPCy6m3/"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=9z2qqSYJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h18-20020a170902f55200b001b176ba9f20si5267135plf.277.2023.06.13.04.19.29; Tue, 13 Jun 2023 04:19:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="DPCy6m3/"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=9z2qqSYJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242204AbjFMLMI (ORCPT + 99 others); Tue, 13 Jun 2023 07:12:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242124AbjFMLKH (ORCPT ); Tue, 13 Jun 2023 07:10:07 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A851992; Tue, 13 Jun 2023 04:10:06 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 619461FDA7; Tue, 13 Jun 2023 11:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686654605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x+Pej+DjtuslhRkqSbqykfmY3R1IGvKyLMb1wCzPsnA=; b=DPCy6m3/VoljsI4nL85OtZJkvAEjkY7VIh384polvAzdZI0R/H09cLfHmiysnYAztjsd7Q 7Nu15mdsj95TGchL3ik5Il/vUYWQT83VTNjDA3Yy1BTOKxdO15IPDGwBSBwjyIo13XxjSC 5vCy8hCHueof/0WuJ0szfScdyOn/rpw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686654605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x+Pej+DjtuslhRkqSbqykfmY3R1IGvKyLMb1wCzPsnA=; b=9z2qqSYJdYO4whOJ9l9oFrTLJwBXOJqfq4+4rtK6NiiIkNufrM06d5VbAmrFmjZ3tEjz5q JcuK6R3S2IrIDnAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 15F0E13483; Tue, 13 Jun 2023 11:10:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cOCCBI1OiGR8CQAAMHmgww (envelope-from ); Tue, 13 Jun 2023 11:10:05 +0000 From: Thomas Zimmermann To: daniel@ffwll.ch, javierm@redhat.com, sam@ravnborg.org, deller@gmx.de, geert+renesas@glider.be, lee@kernel.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, dan.carpenter@linaro.org, michael.j.ruhl@intel.com Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v3 28/38] fbdev/sh7760fb: Use hardware device with dev_() output during probe Date: Tue, 13 Jun 2023 13:07:03 +0200 Message-ID: <20230613110953.24176-29-tzimmermann@suse.de> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230613110953.24176-1-tzimmermann@suse.de> References: <20230613110953.24176-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Call output helpers in the probe function with the hardware device. The virtual fbdev device has not been initialized at that point. Also prepares fbdev for making struct fb_info.dev optional. Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg --- drivers/video/fbdev/sh7760fb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/sh7760fb.c b/drivers/video/fbdev/sh7760fb.c index 74543a1e30314..8566bcd664076 100644 --- a/drivers/video/fbdev/sh7760fb.c +++ b/drivers/video/fbdev/sh7760fb.c @@ -450,7 +450,7 @@ static int sh7760fb_probe(struct platform_device *pdev) par->pd = pdev->dev.platform_data; if (!par->pd) { - dev_dbg(info->dev, "no display setup data!\n"); + dev_dbg(&pdev->dev, "no display setup data!\n"); ret = -ENODEV; goto out_fb; } @@ -519,13 +519,13 @@ static int sh7760fb_probe(struct platform_device *pdev) ret = fb_alloc_cmap(&info->cmap, 256, 0); if (ret) { - dev_dbg(info->dev, "Unable to allocate cmap memory\n"); + dev_dbg(&pdev->dev, "Unable to allocate cmap memory\n"); goto out_mem; } ret = register_framebuffer(info); if (ret < 0) { - dev_dbg(info->dev, "cannot register fb!\n"); + dev_dbg(&pdev->dev, "cannot register fb!\n"); goto out_cmap; } platform_set_drvdata(pdev, info); -- 2.41.0