Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1102588rwd; Tue, 13 Jun 2023 05:04:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4ZeG5mnaMRQPjorunFFFkCRNJvZC1bdAbnfql6kAOJxnzPXx1jqUHX2oh8NzqxPK1TjtTH X-Received: by 2002:a17:903:120a:b0:1af:ffda:7bab with SMTP id l10-20020a170903120a00b001afffda7babmr10398251plh.3.1686657879584; Tue, 13 Jun 2023 05:04:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686657879; cv=none; d=google.com; s=arc-20160816; b=gkU7gUzetWKUjiIuoBZ3rk1kB6KM1dwizu8J57T1qr1Z1HUvylhFz552LuX8cJWhOR AkqoETQsWJtpBoM3SVAi2AiMMtkqsWjb7vFjwUZHbYr4ScVB0kOoWKj+TsKiTqXP4KCy M/fyfhkQxxq6fzFEDqwOGyN6p+qxnwkt/UCg99VVmW/tcq0K7tu5SM/xQIRWm3nL+kWT NiqSX4kYTj4vKKtniwVpRXGLyewKCI5dhyIIATVFBwGUrQDzEE4U9FT2JGQaHnvqa9jq A1AIGa+PX0ZU4qvIE4kkhn643cC4wvmp4DWihdUiqtMRc2+NhmJrKZT4uMfaz9bZYV6B 8rTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xGuAwbZ+ToWocWzlF7uUFTALD/7tV0uI1p0rTYe0rOw=; b=BBrKsi6boGwsGpmYBBudhW6Z0UxNkuruneYeA6Nv7oS25N31I9/MIhlLcF8ynDQpnm KRFmsHlLzRZ4wCuhHV6za7pMhwK9o7vQVLGPuJ+Vgg2901G28RvTljrtfxqBu9Mr58I3 IIm/25cCvuLwF7aNlY7g2cnGtTHZQiiqF50ZbuvgUZuO0K1yxHmH7Ir4dv8jessXur1w b8fXMB3zROEgYuiWDign6O8vdFKQDq4PlmEELOqbSA/fzgv0R/lOLPoilkM8zBiBb9Wx 0PfmnhyFQHmy4Aza5P+PxjluSuCdLadjqLHkkHcsD/4Uw3NXsCiPpjRR4isPcfA5d79U 1t2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=T0wn9mJW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y1-20020a17090322c100b001b045d65af0si9191169plg.76.2023.06.13.05.04.26; Tue, 13 Jun 2023 05:04:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=T0wn9mJW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241490AbjFMLxK (ORCPT + 99 others); Tue, 13 Jun 2023 07:53:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240399AbjFMLxH (ORCPT ); Tue, 13 Jun 2023 07:53:07 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA1C719A5; Tue, 13 Jun 2023 04:52:37 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 522D0224C5; Tue, 13 Jun 2023 11:52:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1686657129; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xGuAwbZ+ToWocWzlF7uUFTALD/7tV0uI1p0rTYe0rOw=; b=T0wn9mJWbyZjRwsgG82QNi/GH9v/gfKYllIRa19GYFZfIeFrZxnN05r2NBWG31Gv0BdOHE Xa99ZbS/k4wu7P+HIBADAToF6+U6kIrNU9rgZG7dNRKB3/b8irgVVlRdBEaXCAOQFx1HxL jWyJMAbrq2xqZg9KY/6T5D6RkZ9pPXg= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3505513345; Tue, 13 Jun 2023 11:52:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Av0rDGlYiGTGIAAAMHmgww (envelope-from ); Tue, 13 Jun 2023 11:52:09 +0000 Date: Tue, 13 Jun 2023 13:52:07 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Hao Jia Cc: tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [External] Re: [PATCH] cgroup: rstat: Simplified cgroup_base_stat_flush() update last_bstat logic Message-ID: References: <20230518124142.57644-1-jiahao.os@bytedance.com> <5g73i4yvi4ub4dqrf4dnq5qghkyckoygmgd2st6be3gg7twww2@w6zim6nxpt3b> <4d49f7e7-2488-9690-258e-34e617cfef6f@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 12, 2023 at 11:13:41AM +0800, Hao Jia wrote: > Sorry for replying you so late. I am using RDTSC on my machine (an Intel > Xeon(R) Platinum 8260 CPU@2.40GHz machine with 2 NUMA nodes each of which > has 24 cores with SMT2 enabled, so 96 CPUs in total.) to compare the time > consumption of arithmetics vs copying. There is almost no difference in the > time consumption between arithmetics and copying. Thanks for carrying out and sharing this despite not convincing towards the change. Michal