Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f7b67068-62c4-0977-265a-37c84f553eab@veeam.com>
Date:   Tue, 13 Jun 2023 14:34:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v4 02/11] block: Block Device Filtering Mechanism
Content-Language: en-US
To:     Randy Dunlap <rdunlap@infradead.org>, <axboe@kernel.dk>,
        <hch@infradead.org>, <corbet@lwn.net>, <snitzer@kernel.org>
CC:     <viro@zeniv.linux.org.uk>, <brauner@kernel.org>,
        <willy@infradead.org>, <dlemoal@kernel.org>, <wsa@kernel.org>,
        <heikki.krogerus@linux.intel.com>, <ming.lei@redhat.com>,
        <gregkh@linuxfoundation.org>, <linux-block@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>,
        "Donald Buczek" <buczek@molgen.mpg.de>
References: <20230609115858.4737-1-sergei.shtepa@veeam.com>
 <20230609115858.4737-2-sergei.shtepa@veeam.com>
 <e2f851d7-6b17-7a36-b5b3-2d60d450989d@infradead.org>
From:   Sergei Shtepa <sergei.shtepa@veeam.com>
In-Reply-To: <e2f851d7-6b17-7a36-b5b3-2d60d450989d@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/13/23 03:51, Randy Dunlap wrote:
> 
> On 6/9/23 04:58, Sergei Shtepa wrote:
>> diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
>> index b7b56871029c..7904f157b245 100644
>> --- a/include/uapi/linux/fs.h
>> +++ b/include/uapi/linux/fs.h
>> @@ -189,6 +189,9 @@ struct fsxattr {
>>   * A jump here: 130-136 are reserved for zoned block devices
>>   * (see uapi/linux/blkzoned.h)
>>   */
>> +#define BLKFILTER_ATTACH	_IOWR(0x12, 140, struct blkfilter_name)
>> +#define BLKFILTER_DETACH	_IOWR(0x12, 141, struct blkfilter_name)
>> +#define BLKFILTER_CTL		_IOWR(0x12, 142, struct blkfilter_ctl)
> 
> Please update Documentation/userspace-api/ioctl/ioctl-number.rst
> with the blkfilter ioctl number usage.

It seems to me that there is no need to change anything in the table of
numbers for 'blkfilter'. I think the existing record is enough:

0x10  20-2F  arch/s390/include/uapi/asm/hypfs.h
0x12  all    linux/fs.h
             linux/blkpg.h

Maybe it would probably be correct to specify the file 'uapi/linux/fs.h'?
And maybe we need to specify the request numbers for blksnap?

add ioctls numbers for blksnap

Asked-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Sergei Shtepa <sergei.shtepa@veeam.com>
---
 Documentation/userspace-api/ioctl/ioctl-number.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst
index 176e8fc3f31b..96af64988251 100644
--- a/Documentation/userspace-api/ioctl/ioctl-number.rst
+++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
@@ -202,6 +202,7 @@ Code  Seq#    Include File                                           Comments
 'V'   C0     linux/ivtvfb.h                                          conflict!
 'V'   C0     linux/ivtv.h                                            conflict!
 'V'   C0     media/si4713.h                                          conflict!
+'V'   00-1F  uapi/linux/blksnap.h                                    conflict!
 'W'   00-1F  linux/watchdog.h                                        conflict!
 'W'   00-1F  linux/wanrouter.h                                       conflict! (pre 3.9)
 'W'   00-3F  sound/asound.h                                          conflict!
-- 
2.20.1