Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <de2b71d8-9204-a8cc-2e82-9a9e2c04ee9e@loongson.cn>
Date:   Tue, 13 Jun 2023 20:45:40 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [ PATCH v2 0/3] Add Loongson I2S controller support
Content-Language: en-US
To:     Mark Brown <broonie@kernel.org>
Cc:     lgirdwood@gmail.com, krzysztof.kozlowski+dt@linaro.org,
        linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        loongarch@lists.linux.dev, loongson-kernel@lists.loongnix.cn
References: <20230612085048.3039471-1-mengyingkun@loongson.cn>
 <31bd1de1-feb7-4544-aca6-cfb983722057@sirena.org.uk>
From:   Yingkun Meng <mengyingkun@loongson.cn>
In-Reply-To: <31bd1de1-feb7-4544-aca6-cfb983722057@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/6/13 03:07, Mark Brown wrote:
> On Mon, Jun 12, 2023 at 04:50:48PM +0800, YingKun Meng wrote:
>> Hi all,
>>
>> This patchset adds support for Loongson I2S controller, and
>> introduce a ASoC machine driver for loongson platform.
>>
>> The Loongson I2S controller is available on Loongson
>> 7a2000/2k2000 chips, works as a PCI device. It has two
>> private DMA controllers used to playback and capture.
>> Each DMA controller has one channel.
>>
>> The ASoC machine driver adds support for audio device which
>> using loongson I2S controller to tranfser the audio data.
>> The audio device uses "PRP0001" as its ACPI device ID, which
>> provides a means to use the existing DT-compatible device
>> identification in ACPI.
> The code here all looks broadly good - I did have a few review comments
> that I sent in reply to the individual patches but they're more
> stylistic than anything too substantial.


Thanks