Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Jun 2023 09:16:51 -0400
From:   Phil Auld <pauld@redhat.com>
To:     Miaohe Lin <linmiaohe@huawei.com>
Cc:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com, vschneid@redhat.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/deadline: simplify dl_bw_cpus() using
 cpumask_weight_and()
Message-ID: <20230613131651.GA536267@lorien.usersys.redhat.com>
References: <20230522115605.1238227-1-linmiaohe@huawei.com>
 <7bfde912-1e15-ec1f-8a62-9cc508739cd6@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7bfde912-1e15-ec1f-8a62-9cc508739cd6@huawei.com>
Precedence: bulk

On Tue, Jun 13, 2023 at 08:19:22PM +0800 Miaohe Lin wrote:
> On 2023/5/22 19:56, Miaohe Lin wrote:
> > cpumask_weight_and() can be used to count of bits both in rd->span and
> > cpu_active_mask. No functional change intended.
> > 
> > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> 
> friendly ping... :)

This looks reasonable, and better, to me.

Reviewed-by: Phil Auld <pauld@redhat.com>

> 
> > ---
> >  kernel/sched/deadline.c | 11 +----------
> >  1 file changed, 1 insertion(+), 10 deletions(-)
> > 
> > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> > index 166c3e6eae61..fe983ed7bb12 100644
> > --- a/kernel/sched/deadline.c
> > +++ b/kernel/sched/deadline.c
> > @@ -110,20 +110,11 @@ static inline struct dl_bw *dl_bw_of(int i)
> >  static inline int dl_bw_cpus(int i)
> >  {
> >  	struct root_domain *rd = cpu_rq(i)->rd;
> > -	int cpus;
> >  
> >  	RCU_LOCKDEP_WARN(!rcu_read_lock_sched_held(),
> >  			 "sched RCU must be held");
> >  
> > -	if (cpumask_subset(rd->span, cpu_active_mask))
> > -		return cpumask_weight(rd->span);
> > -
> > -	cpus = 0;
> > -
> > -	for_each_cpu_and(i, rd->span, cpu_active_mask)
> > -		cpus++;
> > -
> > -	return cpus;
> > +	return cpumask_weight_and(rd->span, cpu_active_mask);
> >  }
> >  
> >  static inline unsigned long __dl_bw_capacity(const struct cpumask *mask)
> > 
> 

--