Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1228705rwd; Tue, 13 Jun 2023 06:38:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7jSy12FW9mP+42p+cra7rUksHPHLsEe8R3HN/kHyWNVObAxieDrQud2dxMILPWnMOluQ++ X-Received: by 2002:a05:6830:86:b0:6ab:983f:a56b with SMTP id a6-20020a056830008600b006ab983fa56bmr9985835oto.11.1686663480250; Tue, 13 Jun 2023 06:38:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686663480; cv=none; d=google.com; s=arc-20160816; b=TOB/ImvnBg6xd8Bc6+PBQQ/BLHdnULfi3AaMypC8jXs7NUjAIgwP73fhSOHyz5leZs eEFNfr1Z9X0d5CjPQ7aOZvfIjXnxP58drpfbsxeFEGmVb3Hq35uFD+IUPpmuUQqNedba yGJFfGjNJZWAYgQa0PH5V3zAkkeFinKRoGULjoPVodoj0UVL62Ol76071GIvmlg2pN9A ufQH0yqsuXudOln0wbPPSI+P6iZTZataEYjI80pxtfHGrwCR1a+jtj0SkUm+yB/nEJjf 2Gdu4AEEU7oJzeVHxyN7RkFP9qgqBnxpos32aCw0qxyhEUAIS4UJprlRqox41u1QDCAo KyHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=mcfeSqEktACnUGtbwffiWPfhMhm9ciWasUaJ5wlhxNI=; b=mYE5Xd+KVLpheucOcuS3RFM6l9wgV0wUbiIU5hemAW0SGBpKz1e1VYAjhl4QWmjQcy OeST4TQ7I4G1X6O1BFJiwGf4Y+S5OS1hEuRSKw6jE9K7PmbnogJ7OogLDOpuYqRDytYC 9+5mq1vHFxW2AevtdKWpXFVwXYSLKeFV/SzjKgKrbtWMEt6ldve+MVQT0WfHGVkTuPsi XcNPxj66Gkd3dRa1tTkb0h3y/rtlSCP+a6986Dn49oHqfQy1ra4RkWbp9Rkmu/C9cZzu PpbbVtiW289jD1qPVDZI0IK7dg/8waPa6xZK75BFyKRgNMhlaIwxoOdX0hf77NdGWHHg 7kMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e25-20020a637459000000b00528b78ddbdesi1098993pgn.63.2023.06.13.06.37.46; Tue, 13 Jun 2023 06:38:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239785AbjFMNZS (ORCPT + 99 others); Tue, 13 Jun 2023 09:25:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242639AbjFMNZL (ORCPT ); Tue, 13 Jun 2023 09:25:11 -0400 Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62B301B0 for ; Tue, 13 Jun 2023 06:25:08 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0Vl2cNV1_1686662703; Received: from 30.221.134.22(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0Vl2cNV1_1686662703) by smtp.aliyun-inc.com; Tue, 13 Jun 2023 21:25:04 +0800 Message-ID: <25a8daec-e1c4-2164-c210-4ee6b9924c99@linux.alibaba.com> Date: Tue, 13 Jun 2023 21:25:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v8 4/5] erofs: unify inline/shared xattr iterators for listxattr/getxattr To: Jingbo Xu , xiang@kernel.org, chao@kernel.org, huyue2@coolpad.com, linux-erofs@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org References: <20230613074114.120115-1-jefflexu@linux.alibaba.com> <20230613074114.120115-5-jefflexu@linux.alibaba.com> From: Gao Xiang In-Reply-To: <20230613074114.120115-5-jefflexu@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/6/13 15:41, Jingbo Xu wrote: ... > + > +int erofs_getxattr(struct inode *inode, int index, > + const char *name, > + void *buffer, size_t buffer_size) I changed these line above into: int erofs_getxattr(struct inode *inode, int index, const char *name, void *buffer, size_t buffer_size) > +{ > + int ret; ... > ssize_t erofs_listxattr(struct dentry *dentry, > @@ -568,8 +523,9 @@ ssize_t erofs_listxattr(struct dentry *dentry, I also move erofs_listxattr definition into a line (since it's just 80 chars). Otherwise it looks good to me, Reviewed-by: Gao Xiang Thanks, Gao Xiang