Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <53510828-ee5b-1d91-0f85-b79da4422741@meta.com>
Date:   Tue, 13 Jun 2023 06:42:40 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.12.0
Subject: Re: [PATCH] selftests/bpf: Remove unneeded variable "ret"
Content-Language: en-US
To:     baomingtong001@208suo.com, ast@kernel.org, daniel@iogearbox.net,
        andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
        yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org,
        sdf@google.com, haoluo@google.com, jolsa@kernel.org,
        mykolal@fb.com, shuah@kernel.org, jakub@cloudflare.com,
        Jakub Kicinski <kuba@kernel.org>
Cc:     bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230613084315.62021-1-luojianhong@cdjrlc.com>
 <6228af14241b831be4bae6ebcd63799e@208suo.com>
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <6228af14241b831be4bae6ebcd63799e@208suo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFZYRWhlQjdPdlo2NmRWUDZNVURDeE4xUkt5SFVMWnFmME9QUVVtK3pCSzhr?=
 =?utf-8?B?QjU2VXU1M081TGV0dFlXYW5zVm4xTG1RaFlGVEFpdm1CYnozbHZ6NHpvdHdw?=
 =?utf-8?B?Yzkra2NrN0VSRmI2TzdlNDB6ZHBDSDZTVndhd0ZaUit6THVlUVhnU2FBSnJM?=
 =?utf-8?B?QjlJTlVtZGh1NVhjbUZWYzdod25OSEpIa3k0TW4vb2xqd1JOOE92OS9aUTE1?=
 =?utf-8?B?V2Z3bnZEcE50bnkvTnJneFhadTRHb1BXZHAxSDluTFNQRXU4VFk4Q2xsS0cz?=
 =?utf-8?B?WUFPcmFQWnBDZ0M0ZzNUVmZQYVVyM3RLYlBreXFiNkgyQVUwOG5rTUc5M1E4?=
 =?utf-8?B?NFE1a0c3Z3hubmRkMENERDF2VHBHUGhGVVRnTTEyWHVjd2ZjWGhXOXJxSCs1?=
 =?utf-8?B?WDZaVFI5YldDcCs4bS9VV1NVWnI1Q0FyaHlIUW1yb2N0cEYzcURWRGthT3Vw?=
 =?utf-8?B?WCtHLy9meEhqQnZhamUwb01ZbDNBZE9yR3JHcTNKTEpNc3V0UDBwZlduVjZN?=
 =?utf-8?B?dCtkTW9OVTJLVDlvV1AxZkNJeGJ2UFlWVnFyUVlIV0ZTa2dzT1c4OE1JN0hl?=
 =?utf-8?B?MkM1bXBqN0huNjdxVXJZQnpod2hkcWMzSFIvVWwrbEwyNWV5cFY4ajVCVzNa?=
 =?utf-8?B?SHkvbFBhbHVHaDFKeGRWQW5xd3pILzl6YUs0eG1JL2tPM3NsOVNGQWMraXpP?=
 =?utf-8?B?dFZmYnl6VERiOURqbytOTmpVcmhrMXB3N1Q0R3JFZVUvcjIwR3M3WmNBZUE1?=
 =?utf-8?B?cjN4SmJTa3BIaHM2dXNpZGMvQWxONVY2Y1o0b1V0MXNUNk9UbVJVUzY0eUFp?=
 =?utf-8?B?c3hUc0l5OFczVy9XY2ZLN0hnR0pKOFNjRTNGNk1SS3hTbU5wU1BTNWVoa3hs?=
 =?utf-8?B?bVRlQWMvYzZsdUVYQ25yNjRIZjJFOTcvQW0zWEFYR1BIdFlNY0Y4dkxrTDRE?=
 =?utf-8?B?THV3Qm5aNUZRVnlnT0dwYzRNZERKa0k2L3Q1R2ozWkkzYmJmOTZ5TkN6Q1Ev?=
 =?utf-8?B?cnFpMGJ3YytsbXhCZnpnalhvdVJmWU5UMWJXNGFwSFBSbWUxNEJCQWF6MktD?=
 =?utf-8?B?bzhpSmd2SjRmcS9NbHNHaStNcWw3WGc3MWVlc1Y1YzFFYW5BY2xGN2NDcUNi?=
 =?utf-8?B?WTArT2RuaU5NTGNleEo3dm1kc2xnYUorZ093ZUxET1ZGUTg1MUtrbEFad3RI?=
 =?utf-8?B?R2h4Z1NwZEdoMkVzMHhwa1RRczBka3NadUQydk9IWWRXYlk5aHRPeEFjaDZl?=
 =?utf-8?B?S1R3Wi9udndYdWM3akVQRzJnVlR3ZnNDNFBrd2JSVXlaRWcvN3BQSjYxZHls?=
 =?utf-8?B?UXcxVnFWVnFSa1ExYkFXRmlwM3ZObCtydHhvMlNySmpXSWVyMWIvMkpHM1Jj?=
 =?utf-8?B?b0I2VzJRdVR2KzJjRHZIOVF0Y2Z0MnoxcXM0UE1GNy9vT2t2ME5CWHROWXlx?=
 =?utf-8?B?QkIxYk5FaS9sRFdNMUZIbVkybnJjYWw5WXUyVXNJeTVpa045L1VTb3c3L3NR?=
 =?utf-8?B?bHVQeGRQaTBwN0JqN1gzUFdZbjgySXh4eFBOWjluMzZSdXUvS1hqZ1F4c0ww?=
 =?utf-8?B?R2c5azBtc0JKeS9YMm5NdFM4aEZLTnh6aVZYamxDVjlvcnhjNlJKMU5seHp4?=
 =?utf-8?B?Wm5lY3hRdldKazVIdWQ5aEgwUktNR3E2NVhSaVpndWZiYm5wMjNRb2VmNGla?=
 =?utf-8?B?aFhXRFZLZlJ0alJ4Vmtac3ZjTGh5bEZYTDFEa09iSjg1SEVXUFFhbXpBVStp?=
 =?utf-8?B?TXFZcmVoRXlwa1BoMHFIcDZUS0h5TEtDdEdFWWdyR1ZEU0hxYnFKL1czeDNO?=
 =?utf-8?B?WTBRREt4SWx3blVXM2VmR21YT2RUc2ljaDI5TFhudlBWYkdOUHJjQnpQTWVn?=
 =?utf-8?B?Y09UYWsvSklITzVQeTc1UUhyWVE2V3dSRDdqejJwYUdlUko2SldCclEvc05K?=
 =?utf-8?B?dEJFeHVyUm5HOFU1bzNKbnhtNitLSkNTMzB1YXFkMzdjY3pMa2FkN05EU2JT?=
 =?utf-8?B?ZyszcXRjNFZvcFBoS3JudFp2VC9Vb0dJSHJlVm9yL01ITjR5REJra0Zkc2ZE?=
 =?utf-8?B?ZlUweVZRV1dYaTlOOTE4SkpaNGt3dGdVSHRDTmN2UmNkVG5uZ2hqUXh6N0Rp?=
 =?utf-8?B?NTZ3UkkwV3gwYlE1WU15bW5KaUkvbDNwU294K2Y3VUFIUVZTNkdPQld5NzBF?=
 =?utf-8?B?Smc9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d264678-d35b-4be3-f442-08db6c141104
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 13:42:44.5469
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vlB4ua3G/1kC4yKy3fs2gA/7/gSbw3z2nkYUtYjIPB/p3NfufV81MHqvdYJ7N2Rp
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR15MB5376
X-Proofpoint-ORIG-GUID: Vi-1QOw2i1I9377wftmZI0mpvtj90gUP
X-Proofpoint-GUID: Vi-1QOw2i1I9377wftmZI0mpvtj90gUP
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-13_04,2023-06-12_02,2023-05-22_02
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/13/23 1:50 AM, baomingtong001@208suo.com wrote:
> Fix the following coccicheck warning:
> 
> tools/testing/selftests/bpf/progs/tailcall_bpf2bpf6.c:28:14-17: Unneeded 
> variable: "ret".
> 
> Return "1".
> 
> Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
> ---
>   tools/testing/selftests/bpf/progs/tailcall_bpf2bpf6.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf6.c 
> b/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf6.c
> index 4a9f63bea66c..7f0146682577 100644
> --- a/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf6.c
> +++ b/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf6.c
> @@ -25,10 +25,9 @@ static __noinline
>   int subprog_tail(struct __sk_buff *skb)
>   {
>       /* Don't propagate the constant to the caller */
> -    volatile int ret = 1;
> 
>       bpf_tail_call_static(skb, &jmp_table, 0);
> -    return ret;
> +    return 1;

Please pay attention to the comment:
    /* Don't propagate the constant to the caller */
which clearly says 'constant' is not preferred.

The patch introduced this change is:
     5e0b0a4c52d30   selftests/bpf: Test tail call counting with bpf2bpf 
and data on stack

The test intentionally want to:
   'Specifically when the size 

     of data allocated on BPF stack is not a multiple on 8.'

Note that with volatile and without volatile, the generated
code will be different and it will result in different
verification path.

cc Jakub for further clarification.

>   }
> 
>   SEC("tc")