Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1285059rwd;
        Tue, 13 Jun 2023 07:16:42 -0700 (PDT)
X-Google-Smtp-Source: ACHHUZ4b2ZkyY9XQOZLrdkaQ/WnTLzr4E/cWoJugxoVj9OVR9l6HnPo5FLLNj7Z5CPKHSdLLnhXO
X-Received: by 2002:a19:9101:0:b0:4f6:2b29:b446 with SMTP id t1-20020a199101000000b004f62b29b446mr6400919lfd.21.1686665802578;
        Tue, 13 Jun 2023 07:16:42 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1686665802; cv=none;
        d=google.com; s=arc-20160816;
        b=QaPosYKHIXVNsL4rZd+aBDzoawBvKt6ncJv6DAIRX4coeNb5S8lBgdlDr70ee1lmNj
         PSAm794orrrLZC+O1bGkcMKtTh0kpJ7HfU3rQdEVI2ZQh/PwVJrdTtRVKai92PZPXwbF
         WOKSJ6WBWCjrX6SHXRSoJwaXbMZRgwXPu/MIV0Q+zpNUhsoNucNuGF9emw2DKLPWcYC8
         G1fD1zw6BgnKgsNVYzZPvkinSb7xTxeVZjerCvXFYnpdxS5FpaxnxVx7RHDxs2bAZ02u
         tJDJ+c4rX1WHfdBVA8V8RYaLXt5X96srPG4+sr+zAkiB71gs31RLl2uyrmWoWIy1L4Gc
         CT3g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:user-agent:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date;
        bh=z3uQxtMlnYM9b/rhnjFips3sJnZJw4v1iziXCNOi/AI=;
        b=f6EFLFlgnMVEqUPvOyyWKtcCn/CGp/SBXpXrVA2OBswuqUYjAxqE6nUhLT6Djfzq6+
         aL4UG0UK9ujmn+/7dRtS291OowhY4hZq2NPZYEztE5fIQD3Elfs6l3bTGPzY2A/kF1yC
         RfRVn71x0RpMorR+QIiI4QAxJcm+nAo+yahHxoCR9C2EnLu7cTit63x9+/smN7nVFm2Y
         SQVs+uh85oiLXYVoDrqIhrv2UK1yU1e+hSe3u61sAEllzJwAP/QodhSv2GQ9fuj6Pn52
         QX5rJ0azyM0IcAFUa4ByaVtOpNDDbXuymHmkH3+oF7qe8UpbLf7n5OsoITINT4mfyqyc
         JSnw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id u8-20020a17090657c800b00977da4a034bsi3661152ejr.59.2023.06.13.07.16.16;
        Tue, 13 Jun 2023 07:16:42 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S240430AbjFMNta (ORCPT <rfc822;adjskylinux@gmail.com>
        + 99 others); Tue, 13 Jun 2023 09:49:30 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50328 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S239886AbjFMNt2 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 13 Jun 2023 09:49:28 -0400
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D95FD1B2;
        Tue, 13 Jun 2023 06:49:18 -0700 (PDT)
Received: by verein.lst.de (Postfix, from userid 2407)
        id 676B768AFE; Tue, 13 Jun 2023 15:49:15 +0200 (CEST)
Date:   Tue, 13 Jun 2023 15:49:15 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Jingbo Xu <jefflexu@linux.alibaba.com>
Cc:     axboe@kernel.dk, hch@lst.de, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, tianjia.zhang@linux.alibaba.com,
        xiang@kernel.org, casey@schaufler-ca.com
Subject: Re: [PATCH v3 1/2] block: disallow Persistent Reservation on
 partitions
Message-ID: <20230613134915.GA23303@lst.de>
References: <20230613084008.93795-1-jefflexu@linux.alibaba.com> <20230613084008.93795-2-jefflexu@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230613084008.93795-2-jefflexu@linux.alibaba.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_SCC_BODY_TEXT_LINE,
        T_SPF_HELO_TEMPERROR,T_SPF_TEMPERROR autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 13, 2023 at 04:40:07PM +0800, Jingbo Xu wrote:
> Refuse Persistent Reservation operations on partitions as reservation
> on partitions doesn't make sense.
> 
> Besides, introduce blkdev_pr_allowed() helper, where more policies could
> be placed here later.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>