Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1317082rwd; Tue, 13 Jun 2023 07:39:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6qCibbSF5Fd6hWF1AzMg63kMvDMxH8GhgO5S/ppOt2ohtZdlfD+uaZsEMvlv43dunM6k1O X-Received: by 2002:aa7:c547:0:b0:50c:358:1eba with SMTP id s7-20020aa7c547000000b0050c03581ebamr6360646edr.35.1686667163881; Tue, 13 Jun 2023 07:39:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686667163; cv=none; d=google.com; s=arc-20160816; b=Azq7bPqQuIcKkxUihvhzEZJfFNtjU+WJsY1wAR/dQMz38OsEPKZ9p3FXl568POthuf wtxlN0bzSpUojBiGpYKWf07jqeffgRVdl8NdUM5PNm7WcHr6tUIxyj/SwHtHj0TVH+B3 Y8nTp1bEf7CJAq4tEnePqNgruJkqip87EsJVvGvqarXOymX1pEhsQlr5mbSit9JfmCWr vYH45nriQLqMW9pnskMjY3Ntyuspc60RJsD6p1Lc7VItqjkfcdkccji2JCPqHRePFlpk R7J/9SxlEv78Cppkj6X8fG+jSvI2JN0xbse017/fL7VwbgtONUXI2XciyKPz2nwr780h bxIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=q/9A+Z+TgBVYDrCZ3bWX8OfhcX85V5t+oh8ZXWenYUo=; b=c+Xgg9CQNj8Rau9X1zEMByePaKgYj5w7Bc/UYYncohFGBunxATkFgiLhHv+xE/ZM6P S9/+Z2g2nH9s+3IUam5VSEqag5HzB+WpnSMOf0fu2EDWHHeFAYuAgQsXDh5czJ138aO2 6U1U4Ew2YhgOCM43mXIe+3b6uCkkKlO5U77bMp7d/im86Q3oFNYPqESTmDvkaruw5yTF w3xKvwYZ4/AnI6isQp+zuckwIzexxmdvgYs3O/1G/+PcChpVoVzE7CJMBN5qMhC7kUUw j3EQHhjcII6lVRz5IGJFkesJdQmqgRr6tTQ8GY2uG7pofvEVK1CJM5gSfdHidUmxyken LH/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l12-20020a056402028c00b00514a669d4d5si7519401edv.241.2023.06.13.07.38.59; Tue, 13 Jun 2023 07:39:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242853AbjFMOGJ (ORCPT + 99 others); Tue, 13 Jun 2023 10:06:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242743AbjFMOFK (ORCPT ); Tue, 13 Jun 2023 10:05:10 -0400 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11F4326AF; Tue, 13 Jun 2023 07:04:37 -0700 (PDT) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1b3dd3ca7adso13351645ad.3; Tue, 13 Jun 2023 07:04:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686665033; x=1689257033; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q/9A+Z+TgBVYDrCZ3bWX8OfhcX85V5t+oh8ZXWenYUo=; b=BzKh0FjnEJTXb/bwkQl+2eDHw1mtrOfo6L9WvRpXa01jcyoxncTfdgz45Us6dNGpGY NV6UyjAgmWJ9qSaOV8g93z+MTNaPBRw+S2fO4I4GnQoIagXxK1TM7tJTSqAFaLR0vCwa ZW0w60yGNfvwM4yhk2PA2as9Uw3Nl++L8ipR1EIKpNsjVe18rN+5zCvXxqN+k9cThzWY B/aeUWJ/+hsSdXMhae7momTg999dya5tOoudTizbSOpagsFNkPgXGEEBRfz3eoIy1r4Q Vs5ruBrLKMzJwJq6e/OG+OZjVFYEVIlpG0jy2hbdKSRVt20edlgVjRIvpE3AqK1DT66V mFRg== X-Gm-Message-State: AC+VfDzDf0j7bi5q7UHIhPkPjmfk1nI5ABrsgCbyftllrS+XiaicUNHq LWOcLrzmI8ZBn6Xulbt6jko= X-Received: by 2002:a17:902:f687:b0:1a6:6fe3:df8d with SMTP id l7-20020a170902f68700b001a66fe3df8dmr13407929plg.8.1686665032684; Tue, 13 Jun 2023 07:03:52 -0700 (PDT) Received: from [192.168.3.219] ([98.51.102.78]) by smtp.gmail.com with ESMTPSA id j13-20020a170902da8d00b001b06c106844sm10324024plx.151.2023.06.13.07.03.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 07:03:52 -0700 (PDT) Message-ID: <488689a7-e68e-bd68-2cb2-f2f67baa176d@acm.org> Date: Tue, 13 Jun 2023 07:03:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v5] scsi: ufs: wb: Add explicit flush_threshold sysfs attribute Content-Language: en-US To: Lu Hongfei , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Jinyoung Choi , Daniil Lunev , Bean Huo , Peter Wang , open list , "open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER" Cc: opensource.kernel@vivo.com References: <20230613022240.16595-1-luhongfei@vivo.com> From: Bart Van Assche In-Reply-To: <20230613022240.16595-1-luhongfei@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/12/23 19:22, Lu Hongfei wrote: > + /* The range of values for wb_flush_threshold is (0,10] */ > + if (wb_flush_threshold > UFS_WB_BUF_REMAIN_PERCENT(100) || > + wb_flush_threshold == 0) { For future patches, please align split lines as is done elsewhere in the kernel. This means aligning "wb_flush_threshold == 0" with "wb_flush_threshold > ...". Anyway: Reviewed-by: Bart Van Assche