Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Jun 2023 15:22:35 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Okan Sahin <okan.sahin@analog.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 2/2] regulator: max77857: Add ADI MAX77857/MAX77831
 Regulator Support
Message-ID: <6e75f1b5-db99-43c8-aae9-132269b2eb89@sirena.org.uk>
References: <20230613080552.4492-1-okan.sahin@analog.com>
 <20230613080552.4492-3-okan.sahin@analog.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="O1QQbi+LWYO5tBXP"
Content-Disposition: inline
In-Reply-To: <20230613080552.4492-3-okan.sahin@analog.com>
Precedence: bulk


--O1QQbi+LWYO5tBXP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jun 13, 2023 at 11:05:50AM +0300, Okan Sahin wrote:

> +struct regmap_config max77857_regmap_config = {
> +	.reg_bits = 8,
> +	.val_bits = 8,
> +	.cache_type = REGCACHE_RBTREE,

Please use the more modern REGCACHE_MAPLE for new devices.

> +static irqreturn_t max77857_irq_handler(int irq, void *data)
> +{
> +	struct regulator_dev *rdev = data;
> +	enum max77857_id id = (enum max77857_id)rdev_get_drvdata(rdev);
> +	struct device *dev = &rdev->dev;
> +	unsigned long flags = 0;
> +	unsigned int status;
> +	int ret;
> +
> +	switch (id) {
> +	case ID_MAX77831:
> +	case ID_MAX77857:
> +		ret = regmap_read(rdev->regmap, MAX77857_REG_INT_SRC, &status);
> +		break;
> +	default:
> +		return IRQ_HANDLED;
> +	}

We just completely ignore the interrupt if it's not one of the supported
devices, that seems wrong - it looks likee those devices don't have the
support for interrupts at all and so should never get here?  If the
interrupt does go off then this is likely to lead to problems.  I think
it'd be better if the driver just didn't request the interrupt for
devices that it doesn't support interrupts for, if there's no interrupt
support in the hardware for those it could also complain if one is
specified though that's optional.

> +	if (ret) {
> +		dev_err(dev, "cannot read status\n");
> +		return IRQ_HANDLED;
> +	}

IRQ_NONE.

--O1QQbi+LWYO5tBXP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSIe6oACgkQJNaLcl1U
h9CuNQf+KFgyY6janu6dhTtJn4QR9TZ65kzcshdAxrYQ37D1QUPNq8H2MUfnMoMW
K19+vVoPm9DfKAFyasTEk4vhzSWqu+uWiIXwC1NWUq29JyPKq0NIzaxPIgLCgDi/
ZDGBCwYg9yZE7Y3Gu6vQoo6Xn9u5mCYX4HWKcFNGFPHNuASC213kPMPeLx/S8UkS
OjzW0s9LPYrm/Dq/ZGcL6lkNBixD0gqjarU2HsA14hqWhnIR9+NfbboScNRv1o2a
6AHKQVY29PCJ2ndCPqWQeZBOCZXZatL46OlbhnrUER0aGtsw+oJzpI+jXBBIThZw
XGzBa1k2sxE4zeEC7KA4qVNpnHKhcg==
=OgFa
-----END PGP SIGNATURE-----

--O1QQbi+LWYO5tBXP--