Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8d8c54ed-600e-b71a-b008-bae4f8180916@intel.com>
Date:   Tue, 13 Jun 2023 17:21:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v2] platform/x86/dell/dell-rbtn: Fix resources leaking on
 error path
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@intel.com>
CC:     <linux-acpi@vger.kernel.org>, <rafael@kernel.org>,
        <ilpo.jarvinen@linux.intel.com>, <pali@kernel.org>,
        <hdegoede@redhat.com>, <markgross@kernel.org>,
        <fengguang.wu@intel.com>, <dvhart@linux.intel.com>,
        <platform-driver-x86@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230613084310.2775896-1-michal.wilczynski@intel.com>
 <ZIiHaEn7nW7yAFK8@smile.fi.intel.com>
From:   "Wilczynski, Michal" <michal.wilczynski@intel.com>
In-Reply-To: <ZIiHaEn7nW7yAFK8@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3VpM3NTQWZFTktiZFlId1NUOWgvZlkvUnBSUVNCbTd4NW95cnJQaDIrOGwx?=
 =?utf-8?B?QUx4aXduT2cwSWl6U2dCdkJoeVhTS2RkanE4TDhlODlzQjFqRzhsL0pMWVV0?=
 =?utf-8?B?bWhzQVE2b2JVM09NV2g4anJYL2R5bG9EcjBxZHlQZ0pVNXBJcWVkcENSYVgy?=
 =?utf-8?B?eEUydHNQelFSdVREb25rOVRuZWNVQWFkaDhVQmRnWHhvWEs4OGZodHMyVEVk?=
 =?utf-8?B?Nm5RTGZpd3hpUk5nb2I3ZVRNdDBiVVN6U3dwQWdhaThWeWFpNEtzc3BiVDNB?=
 =?utf-8?B?MVlNTm1mWFVUMHdVYkJPQzNnWnozU1k2bFlVNlI2bnQyTlJDa2tUNkZnWVNI?=
 =?utf-8?B?ZHliZ2JOa28rZVl1VkhuTkZGVjRwdG9Pb0Y3NlVhMUZvL1lKT3dZRk92Mmtz?=
 =?utf-8?B?ZG9ESHhaVkg2WWczbVBzMm9xcmFpZjVhV2J4bDNVRjdlaGNLNlRES1kxRVp3?=
 =?utf-8?B?Ny9KUGF5QnI1ZDAxVUpTcTNzK053QXhMTERCcUtuVTlaZnpwNWJCVHpUZVQ3?=
 =?utf-8?B?MndXN21XcFBBR1J3UHJyNklzeGM4S3EzRXFxVTVkcmVidnk3UVhyT3VKWHZ3?=
 =?utf-8?B?WGE2UWtQYVpMbWRGdXBSU21uWTB1M0JncTB1bnhINUp6bzBYNXlNbG8wcXU1?=
 =?utf-8?B?WlN3NDd0VXZtalZUM1BQSHNVTHZsYjZqbU5STFhlelNRMFovTlFWNDVYVEJR?=
 =?utf-8?B?bE5ONDdzWHlyZll3dXVQUDVJdGxiOHdGbU5LYTlMNVRtOHRKdVRRMy9IWER2?=
 =?utf-8?B?Rk1TYnphUmI0TWRJV1Q2ZTUxbkVZaTJtS3VZeDRRbUZuK0VrSGFCdzZPRzVL?=
 =?utf-8?B?NStQQ1QwZGluN3NiSno3ZnZNVmhFRVFiQ0VuSk5LM21FNGI4ZWdtTnJkM0o4?=
 =?utf-8?B?WWZDSlUxUEJicGdBNEoySGUxcExlTEV2Z3lZeTl0WTFvZ0h2M1NHbVlFeGpj?=
 =?utf-8?B?NmkzRzFONE1pTStYeUpLYWg3M05HTHFWcy9SU3k3MDJQQTg0RCszdEFqQ2Jo?=
 =?utf-8?B?TElCYUJOTXZYS3E3Z21KcGNPYUJLeWNlMERxQ01uU01QeWZhdVpFb05Wb0h5?=
 =?utf-8?B?eTV3VXdZWXpMZWlEcXAramRZSENKcjY0ZDdnWTE0TEhmL2xCeUJJVkVHeStI?=
 =?utf-8?B?dzluUkFrdTh1TEx6TXpnZW81L09nT0J1OFdYa01DalNLbElYNnNPU0pNcW1B?=
 =?utf-8?B?Q1puK21VM1FpWCt1M3cyaTI4Q2ZhODltL1A0MVQ3cDlaR054NVpycmRXblRS?=
 =?utf-8?B?a3pBM1RZV3pRK1ZSdWRrb2tyRjU4cjBBTmFwNmVrVVQvYlE2L20wNE5XVTNh?=
 =?utf-8?B?aGYrRG4rRmtZSVhPTEluL0hGUkhUWU9wQzVKOWNQQm1zcDB3UURtTnBZRTAz?=
 =?utf-8?B?OTVLTmJpVytqODYySFh4Z2xpUVhlbDhBM2tLRXNQY3AzejI1TWxkbWtFZ0V5?=
 =?utf-8?B?cTRqaTluUCtkRkxBbktMSEhTQTk2MW4zUWgvQm4xT3h1Wi81MnBFcld0L2JR?=
 =?utf-8?B?S1pNbkdpMTBNNWxWTmNkY0JTYXdLaC9tUEViblRCZUhwYVNVUEFTVW1vY1F0?=
 =?utf-8?B?cnh0NWFuM2JUSVF4MmVtaGVuOWhsWkt5RlRKVHBrUTJYUDkxR0pJTjFSRjlp?=
 =?utf-8?B?ZjFIcURZcXpnTmtmNSs1OWhDdmw4d0MvdHI1VkRxZVExNUF0RmlieE9UN0gv?=
 =?utf-8?B?U0tKODlMQ1dnSmh6VUxFTWZGQTJLeDU5c0JxdlkwM1JRUVp0N0h2VW5Lb05s?=
 =?utf-8?B?OUVuNW5Td0xmeXlhNC82eVF2V2NFWTc3OXZYZ2xoSzQ1ang1MmtrQlVRSHhZ?=
 =?utf-8?B?L2MxZ01oWURvTE9VSFNmYTVVNzFqWksyVHRRWXBFc2xTQURmcU4vSjlJamNW?=
 =?utf-8?B?aXdJbGtPOW1NUURkd094ZTNJUGRJQmZLNWJwK21HTmRoenVCZkpPODF0NzA5?=
 =?utf-8?B?clVDQ2JBQ0FSM1lhZXBXVmdvOHBQeEtyTkp5TU1RbFN4NEprZGJDa0ZabEtH?=
 =?utf-8?B?UDkvWG4wd21UdW9PdHlwcitqQXA3aldyaGY4ckNYVm1OMk5JMHdpOVhqQU9T?=
 =?utf-8?B?WHhPWmNyUzBQaDBSYmNnMDdvSndZUnpucDZ4MzVwVkd3eFFCejBUSEJvbWhL?=
 =?utf-8?B?KzY4WS84R0IzS2Q4SmZ2aW82amNMcWpDb3k3TDltb1ZmQjk3bk5TZThhMnBO?=
 =?utf-8?B?SHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b20e759-4c12-42d1-6f40-08db6c21d5e7
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 15:21:18.3849
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nN3AuoHs/atbM73ocnq2M7h1SSI+/CibpfA5rzsztopr6V7zr7o6BCgPnTgl3+pBdDYvdwBgYF4nYlpTmohZ+kemtGUIc+pu7DfQJjy/ZhU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6777
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/13/2023 5:12 PM, Andy Shevchenko wrote:
> On Tue, Jun 13, 2023 at 11:43:10AM +0300, Michal Wilczynski wrote:
>> Currently rbtn_add() in case of failure is leaking resources. Fix this
>> by adding a proper rollback. Move devm_kzalloc() before rbtn_acquire(),
>> so it doesn't require rollback in case of failure. While at it, remove
>> unnecessary assignment of NULL to device->driver_data and unnecessary
>> whitespace, plus add a break for the default case in a switch.
>> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Isn't also suggested by Pali?

Oh yeah, should have added a tag for Pali as well

>
>> Fixes: 817a5cdb40c8 ("dell-rbtn: Dell Airplane Mode Switch driver")
>> Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Acked-by: Rafael J. Wysocki <rafael@kernel.org>
> ...
>
> Hans, can it (an additional tag) be folded into applied change?
>