Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1421641rwd; Tue, 13 Jun 2023 08:57:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7w/U4QQJ41/HtTFmknWZ5HHFemG0uBKnlmB3a3302pm2Jm6CU3OdSh6jsbcT2NF1e8561P X-Received: by 2002:a17:90a:9ad:b0:25b:e4ac:98ac with SMTP id 42-20020a17090a09ad00b0025be4ac98acmr6048825pjo.17.1686671826426; Tue, 13 Jun 2023 08:57:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686671826; cv=none; d=google.com; s=arc-20160816; b=Pl5wTs4+H9xMC2O1+Y2Mi5YSUyLsyNSEn0R3c49ETOdVJsWUDxrTe0v7CNInKu/0er MiFRs8j/XG6S6qX8e+vbCD3scMhEXlWo2WeV8sNABX556JlHa/WMZmY8F6M0E8cbTr5x 7fCCDOYlWMcCf8AzJQQ3QHG8UbN20axPvjK+f7Rpmxl92NbyH9InHEE5vk2KO1EHA8VK yr65uAgeDW3hOfXF7YHGAmrg+JV250ZqrJv9b2wjs5Njx4W/sQBiNGf94tjRKIpUyv2j YjlOisUUEMNJw2nk9kuxTu1CjY9FsGGQwXBJHe0Plrmd+P26jmgFHKtvsaLwsRnmg0L0 rq6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=L8w56/Eh3SaMVPV4rzPuQdoPoU4E4DMPZqkB2BMyc7Y=; b=PoZlxDpbr24XxcSip/dEgMCqw+0d3yf344EQ07QI1RAOBwdfKNOPkxT75rNchJYT0m qw9EcLFsMhGRzYTNnzIOOse2XNAHCgEVcSmaPfQRH4i/DbGXynWJ2cQqLBfBgbtpRo2Z SHBOHfZd15zhAq6T24oLhCMq3REDZ3f9lfZHNdejcdRGogYuzRnLmaQ4PoKYC+FJQPBh sGxxw+TLMHi9FgfgkbrJgGznxuzTJZMdM8IAVthhOdHs/nuU2XyUU66tkzVCD22hoags iCf7VoeHfqZqKA15+R9o8NAvVibdZ9CRZOv4nK+76CwZnmC+AVwR145uYqHh4XX8QJwL vWHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jGZLbQcl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 3-20020a17090a08c300b0025beeac6c98si3360095pjn.107.2023.06.13.08.56.52; Tue, 13 Jun 2023 08:57:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jGZLbQcl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242640AbjFMPjT (ORCPT + 99 others); Tue, 13 Jun 2023 11:39:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241194AbjFMPjP (ORCPT ); Tue, 13 Jun 2023 11:39:15 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACFF0127; Tue, 13 Jun 2023 08:38:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686670733; x=1718206733; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/xGp+iT5zbAfOiZZknUyObKuwpoHCKHzyzKxIRVycMY=; b=jGZLbQclZ8mcfAS6MbEFpzULfghCxa1roIQGEa4Ct8s15WTBjuhlfRK6 2XnNa5HSMUqzYuwMiXpNaDTH8836a+f0HrkDdUk8DtMZGEWZICj9dZj+j N6eIQiafSU79Uxsa5a07g6nm/gnRNAHxBKLE/LKAXJcn+ExguafsEPgW7 zHMUASG3Qit2Z4VhRa43Dw7/feaaOs8JMSx+jMSWpk2qYGz2wzF2U7oY3 GhvK7Q4UvPmonWabFBdaz6o92C86QX8gQFDPDmMmcqhKreqLnFoeaUjMW ewcsRN+uG7i9v/PXwHtCDdYGKnwLjsNRVYSWdE6QK9zu+vc7vGCiP8Au7 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10740"; a="444741953" X-IronPort-AV: E=Sophos;i="6.00,240,1681196400"; d="scan'208";a="444741953" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2023 08:38:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10740"; a="1041811992" X-IronPort-AV: E=Sophos;i="6.00,240,1681196400"; d="scan'208";a="1041811992" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP; 13 Jun 2023 08:38:15 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1q9661-003UMS-2p; Tue, 13 Jun 2023 18:38:13 +0300 Date: Tue, 13 Jun 2023 18:38:13 +0300 From: Andy Shevchenko To: Raag Jadav Cc: linus.walleij@linaro.org, mika.westerberg@linux.intel.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, pandith.n@intel.com Subject: Re: [PATCH v3 3/3] pinctrl: intel: simplify exit path of ->gpio_request_enable() hook Message-ID: References: <20230613085054.10976-1-raag.jadav@intel.com> <20230613085054.10976-4-raag.jadav@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230613085054.10976-4-raag.jadav@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 13, 2023 at 02:20:54PM +0530, Raag Jadav wrote: > Simplify exit path of ->gpio_request_enable() hook and save a few bytes. > > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-36 (-36) > Function old new delta > intel_gpio_request_enable 186 150 -36 > Total: Before=10453, After=10417, chg -0.34% I believe Mika's comment against patch 3 of v2 of this series applies here as well, meaning this patch won't be accepted. But let Mika express himself. -- With Best Regards, Andy Shevchenko