Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Jun 2023 17:32:58 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Lorenz Bauer <lmb@isovalent.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        David Ahern <dsahern@kernel.org>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Joe Stringer <joe@wand.net.nz>,
        Mykola Lysenko <mykolal@fb.com>, Shuah Khan <shuah@kernel.org>,
        Kuniyuki Iwashima <kuniyu@amazon.com>,
        Hemanth Malla <hemanthmalla@gmail.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
        linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 3/6] net: remove duplicate reuseport_lookup
 functions
Message-ID: <ZIiMKgt6iQwJ6vCx@corigine.com>
References: <20230613-so-reuseport-v2-0-b7c69a342613@isovalent.com>
 <20230613-so-reuseport-v2-3-b7c69a342613@isovalent.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230613-so-reuseport-v2-3-b7c69a342613@isovalent.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SluJtbNVc0bVwOTPYHz1aBl+GfQLMOisceiH4E0fUNKD6X5WmWQ5e6+qccCR?=
 =?us-ascii?Q?eOGrcrOcWrMVG6PVoVXfceF2ibnQagFkKT/+sJVM5XTq1WkiWOmKu7KjsQhV?=
 =?us-ascii?Q?Th1Nx+sGNKUC+/G/nNIhES/FZSl4lFwDRa2Y1LBrWm3xjUpxxOJLSxhIyt5x?=
 =?us-ascii?Q?UpuWrdVk27+oKQlT19w0q/tE2sg/Vx7j15cxI2OJ/Bwvydelu6xDwllsRJjm?=
 =?us-ascii?Q?uetDMJLeekaTDCRDq27LIcZkE664ZPZMbjwwoAljE8kVLb9WnXxFyBKhH9UW?=
 =?us-ascii?Q?sCsGzWtXDgqIhzpPrcE+uhbDF2XJgTvg0XGDjhWcopjgjaJAJ1n0hrhvYmEf?=
 =?us-ascii?Q?M06m+2YOdF8cxUwEukZcxChiAF9f7r/00T8GXW85/maCf5PjP9rQergGetiS?=
 =?us-ascii?Q?ateueyIQGWRrf0/n2cnibAG5vz3fDEiPutX8jnCOwhAP/UD1lYCNMVqfuL3y?=
 =?us-ascii?Q?7Ko/hGrCO1yEUCGKkSkSXwxtLAvJxsiHCUZSnobC/XfEWAzucgXIwG89uQDz?=
 =?us-ascii?Q?E8fMxe30/vH9z7+Lww29NCWInitxd7LXzkvhCSwp1HwH/zu0kjreNz9pYxFR?=
 =?us-ascii?Q?LSK5OveZylaiOJr1L0tDFTxikFW7G9hKaGzjW0tXRLAcnc3xUTAc1aMKXU6T?=
 =?us-ascii?Q?GRw2UT2ZP6Al3qYB4JAACBgBd6iG7aIH+TVWWO5GSCc7eNwvsGpYKkk/MaiD?=
 =?us-ascii?Q?3LPwH898OQlOndS+gKQZNiHmLrsUNF3YEJv7v9KkZ3YV0QCwx59RcplADa5q?=
 =?us-ascii?Q?JH43RpZAouTG9fodJz57O2zaucZsk9Ko9uerwLWguDfeDrDDw/XWyX8qyPJS?=
 =?us-ascii?Q?b1m6nhw+2E4uwriKSgv+ayvHpoyWP/zZJE3mn71w4qQL5G4T5176Mz8Q+TCR?=
 =?us-ascii?Q?Kw9DhVljZUVmRe4cKlO5+8xj1/1tNDfbEkpEUV/c1D96ygR7jiZpseaBUyrE?=
 =?us-ascii?Q?c8+484WbYV1bcukV96QSD/Vb8h42YaFqNkCOzBW2fkKD2t1LR/IiLHfLQfjz?=
 =?us-ascii?Q?facIC+Ne1J4vLR/gZGQbyZtg+4iFoMe6ImtGbMPkgUG+Et5GmI6GETe0DKd/?=
 =?us-ascii?Q?o4fEukJgJkOwwHGjOUCpG5KZyYYpDv3+IKzGJ+L2GhuSTLhga6yyLKpW5TJw?=
 =?us-ascii?Q?SXX8TJJ7L+qk34zPDJoE7kiIyGfUMYunOTVZNRrBrNJuZtpn92xQFvqYNbg+?=
 =?us-ascii?Q?GaVlvrXp++UjimYdr4S74c58GZWC9XdhO97vrN2DtVzP0lk/zygt4y38/noU?=
 =?us-ascii?Q?tyljODgo/vwWTERJ2CLCuHbAafYlnEyll4oSMF2TVFTDXUeulkVsP9iW1+SP?=
 =?us-ascii?Q?VvwnPakvw/1luInPOLP9218pCuAGoYB+hKCfiBJc4nrVUwY2NNy3u5iKkP+j?=
 =?us-ascii?Q?uxjkAchtjCKgiqF2atSu6ItwToKt68RmFrwGdvJYVsb6hj0f1A2eHrqXWFKM?=
 =?us-ascii?Q?c3Pt1OEQc4zSeqoapr6ZvXjrCVur1N7gBApRKRy9rVB1xXq4UxCgne67IWZD?=
 =?us-ascii?Q?qlZiEyVD2W0cxZDgr6fkNc6uDmg9Vtk5Bdv9LV23O3CxaH0qx6iAGshhDvKF?=
 =?us-ascii?Q?+5G0drDRTiMoNqIjEOWyRBJn9cqWySL0ze/JlA/AJBE5P9dUwntfUfMrN6jo?=
 =?us-ascii?Q?c6VRO01h4AbFXtja3whTEwMGY28gNDd3gYiqoHzQYeiAuZSjnXKY3vR5zpyH?=
 =?us-ascii?Q?wMbsng=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 986f8eff-82cc-4638-71b0-08db6c237cb0
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 15:33:07.6725
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /PjNtM+8z6j+lGwBDOggZVh6fA4E+7b/LmVZ3HUu/7kdR607wgD3xFg/tGyitdVMItZSzUl4mwm5DtNkZ7GyuX0XnHvhG5CbGyXUh0/acBY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB4040
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 13, 2023 at 11:14:58AM +0100, Lorenz Bauer wrote:

...

> @@ -332,6 +332,10 @@ static inline int compute_score(struct sock *sk, struct net *net,
>  	return score;
>  }
>  
> +INDIRECT_CALLABLE_DECLARE(u32 udp_ehashfn(const struct net *,
> +					  const __be32, const __u16,
> +					  const __be32, const __be16));
> +

Hi Lorenz,

Would this be better placed in a header file?
GCC complains that in udp.c this function is neither static nor
has a prototype.

Liksewise for udp6_ehashfn()

...