Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Jun 2023 16:47:10 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Ricard Wanderlof <ricardw@axis.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Waqar Hameed <waqar.hameed@axis.com>, kernel@axis.com,
        linux-kernel@vger.kernel.org,
        "Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v2] regmap: Add debugfs file for forcing field writes
Message-ID: <1c1f7fae-7eee-473a-b637-af021510d7d3@sirena.org.uk>
References: <pnd1qifa7sj.fsf@axis.com>
 <2023061322-garter-linseed-6dfe@gregkh>
 <5b20509c-e4d5-21f8-fc20-4d02b9abd87d@axis.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="5A4kAC+oX43H9Pox"
Content-Disposition: inline
In-Reply-To: <5b20509c-e4d5-21f8-fc20-4d02b9abd87d@axis.com>
Precedence: bulk


--5A4kAC+oX43H9Pox
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 13, 2023 at 05:15:10PM +0200, Ricard Wanderlof wrote:

> I can understand that enabling a write-always behavior results in a=20
> different behavior on the associated bus (e.g. I2C), but in the end it=20
> shouldn't affect the functionality of the peripheral device any more than=
=20
> rearranging driver code to perform regmap writes in a different order,=20
> which might also lead to fewer or more bus writes.

> It seems I'm clearly in the wrong here, so there must be some scenario=20
> I've missed. It just doesn't seem that dangerous; it's a debug=20
> functionality after all.

There are devices where the act of writing to a register can have side
effects even if the values in the register are the same (for example
triggering some kind of recalibration based on the "new" value).  It's
rare, and it's probably more likely to be annoying or disruptive than
actually dangerous, but it is something drivers might be relying on.

--5A4kAC+oX43H9Pox
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSIj30ACgkQJNaLcl1U
h9DvFAf/cQwuvYnO7JDuL83AFlpdAHUglQLWdk4YV7wQuxjt+nnVZuKRDADuX2rL
hNfdmO1mEwYBGon7bI8fY+omEisls736KXLAUs69DeEHz4tgO/zzMjYjLDsJmjev
QkxFreFWcvRLHsCTGxE9zTAcDysxULFmqotS9WI5EPCVnuZoj6cKLfxi2UwmILWB
QFxuKOttitcpWBz7HQhwzFCiMJFFsomtFvvK+QbmtAWEa6VIhUdDk0Jya5ilAfhk
VD4EQFEhWIy4YVT4YdGju+F6botKpzpXATjfGRROaRNDCfBwnaw3Yz9k0jN8RJKx
IPQ2jZii+OCd4Svwkl+vHapqsVc8qA==
=3Q0/
-----END PGP SIGNATURE-----

--5A4kAC+oX43H9Pox--