Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Jun 2023 18:21:22 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Sascha Hauer <s.hauer@pengutronix.de>
Cc:     linux-rockchip@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Will Deacon <will@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, kernel@pengutronix.de,
        Michael Riesch <michael.riesch@wolfvision.net>,
        Robin Murphy <robin.murphy@arm.com>,
        Vincent Legoll <vincent.legoll@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 01/25] PM / devfreq: rockchip-dfi: Make pmu regmap
 mandatory
Message-ID: <20230613162122.fkivfd7bzpwdrkan@mercury.elektranox.org>
References: <20230524083153.2046084-1-s.hauer@pengutronix.de>
 <20230524083153.2046084-2-s.hauer@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="jurk47xd2prgsurq"
Content-Disposition: inline
In-Reply-To: <20230524083153.2046084-2-s.hauer@pengutronix.de>
Precedence: bulk


--jurk47xd2prgsurq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, May 24, 2023 at 10:31:29AM +0200, Sascha Hauer wrote:
> As a matter of fact the regmap_pmu already is mandatory because
> it is used unconditionally in the driver. Bail out gracefully in
> probe() rather than crashing later.
>=20
> Fixes: b9d1262bca0af ("PM / devfreq: event: support rockchip dfi controll=
er")
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

>=20
> Notes:
>     Changes since v4:
>     - move to beginning of the series to make it easier to backport to st=
able
>     - Add a Fixes: tag
>     - add missing of_node_put()
>=20
>  drivers/devfreq/event/rockchip-dfi.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
>=20
> diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event=
/rockchip-dfi.c
> index 39ac069cabc75..74893c06aa087 100644
> --- a/drivers/devfreq/event/rockchip-dfi.c
> +++ b/drivers/devfreq/event/rockchip-dfi.c
> @@ -193,14 +193,15 @@ static int rockchip_dfi_probe(struct platform_devic=
e *pdev)
>  		return dev_err_probe(dev, PTR_ERR(data->clk),
>  				     "Cannot get the clk pclk_ddr_mon\n");
> =20
> -	/* try to find the optional reference to the pmu syscon */
>  	node =3D of_parse_phandle(np, "rockchip,pmu", 0);
> -	if (node) {
> -		data->regmap_pmu =3D syscon_node_to_regmap(node);
> -		of_node_put(node);
> -		if (IS_ERR(data->regmap_pmu))
> -			return PTR_ERR(data->regmap_pmu);
> -	}
> +	if (!node)
> +		return dev_err_probe(&pdev->dev, -ENODEV, "Can't find pmu_grf register=
s\n");
> +
> +	data->regmap_pmu =3D syscon_node_to_regmap(node);
> +	of_node_put(node);
> +	if (IS_ERR(data->regmap_pmu))
> +		return PTR_ERR(data->regmap_pmu);
> +
>  	data->dev =3D dev;
> =20
>  	desc =3D devm_kzalloc(dev, sizeof(*desc), GFP_KERNEL);
> --=20
> 2.39.2
>=20

--jurk47xd2prgsurq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmSIl4IACgkQ2O7X88g7
+ppKcw//ZTg1vOUfnXfLbpBaa8Hxz6w4+A4J9oT3pbk1OSYD9C8Nx8Z97dV0T4YN
0bM7LPlqdLXPrEngsMPWx0vwAdjZG2d5TnN0rRLB9LVoBEBtuiGi3t+AvPhvdCGh
OaqvCLwnkkOtGjU32NBq53nzLwp1JQio6uOwLMGFwvkNR3a1RnQlwFci7L/uOkNU
o4WEWyhC3FgtxvCOOQwlJ1Uz3k5fi9yQejvjBN79mF4RCS3ZvKfODcsYxLx1415a
i/Aee7UpLMk4btvPwM/1kc5NEvx01NXNZQj6V09gsDRDwLFg4dexXyjz8NPqZX3P
DhACT7gMN94enie2IllSF2umrbBcslkTtuPEJ4TlF0ES692vCl2qdodSRgxM89Lq
XgSrbwwP6NQgA0AhLjjy4Nw+WqHACYU55kpFdoB7txGcJXyQpRT4v+2x1vHQHMJL
DYnoy/ohmg6nlLAd84SSEyfqNI/UrGwQPYi2TwZe2SAyhqiCi5NKN08umm4xw1Jf
M5XuM9koQj5Wosqby0FBcUvPB7GjV8uA9lB1tNLrIjR26wHYrUpH4UNjtYzEHSHr
BMxi1e5c2cmAjzQIUUXCwi0t1kNqHTd3m+joEjM9NTt2NfjBe6cKGWwLcmgGmHkP
0aWH++uS2E+NQlAET1QTONzuh/MxJuB7Hm8AkYA4sT0PMEfCgP0=
=Gdda
-----END PGP SIGNATURE-----

--jurk47xd2prgsurq--