Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Jun 2023 18:47:58 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Sascha Hauer <s.hauer@pengutronix.de>
Cc:     linux-rockchip@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Will Deacon <will@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, kernel@pengutronix.de,
        Michael Riesch <michael.riesch@wolfvision.net>,
        Robin Murphy <robin.murphy@arm.com>,
        Vincent Legoll <vincent.legoll@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v5 11/25] PM / devfreq: rockchip-dfi: Handle LPDDR2
 correctly
Message-ID: <20230613164758.qjjjtog5bjnhjry5@mercury.elektranox.org>
References: <20230524083153.2046084-1-s.hauer@pengutronix.de>
 <20230524083153.2046084-12-s.hauer@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="4yktvbxgbrrvhkrz"
Content-Disposition: inline
In-Reply-To: <20230524083153.2046084-12-s.hauer@pengutronix.de>
Precedence: bulk


--4yktvbxgbrrvhkrz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, May 24, 2023 at 10:31:39AM +0200, Sascha Hauer wrote:
> According to the downstream driver the DDRMON_CTRL_LPDDR23 bit must be
> set for both LPDDR2 and LPDDR3. Add the missing LPDDR2 case and while
> at it turn the if/else if/else into switch/case which makes it easier
> to read.
>=20
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

>  drivers/devfreq/event/rockchip-dfi.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event=
/rockchip-dfi.c
> index 261d112580c9e..16cd5365671f7 100644
> --- a/drivers/devfreq/event/rockchip-dfi.c
> +++ b/drivers/devfreq/event/rockchip-dfi.c
> @@ -82,12 +82,19 @@ static void rockchip_dfi_start_hardware_counter(struc=
t devfreq_event_dev *edev)
>  		       DDRMON_CTRL_HARDWARE_EN), dfi_regs + DDRMON_CTRL);
> =20
>  	/* set ddr type to dfi */
> -	if (dfi->ddr_type =3D=3D ROCKCHIP_DDRTYPE_LPDDR3)
> +	switch (dfi->ddr_type) {
> +	case ROCKCHIP_DDRTYPE_LPDDR2:
> +	case ROCKCHIP_DDRTYPE_LPDDR3:
>  		writel_relaxed(HIWORD_UPDATE(DDRMON_CTRL_LPDDR23, DDRMON_CTRL_DDR_TYPE=
_MASK),
>  			       dfi_regs + DDRMON_CTRL);
> -	else if (dfi->ddr_type =3D=3D ROCKCHIP_DDRTYPE_LPDDR4)
> +		break;
> +	case ROCKCHIP_DDRTYPE_LPDDR4:
>  		writel_relaxed(HIWORD_UPDATE(DDRMON_CTRL_LPDDR4, DDRMON_CTRL_DDR_TYPE_=
MASK),
>  			       dfi_regs + DDRMON_CTRL);
> +		break;
> +	default:
> +		break;
> +	}
> =20
>  	/* enable count, use software mode */
>  	writel_relaxed(HIWORD_UPDATE(DDRMON_CTRL_SOFTWARE_EN, DDRMON_CTRL_SOFTW=
ARE_EN),
> --=20
> 2.39.2
>=20

--4yktvbxgbrrvhkrz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmSInb4ACgkQ2O7X88g7
+prLsg/+OFMv+BneIBfQR6aVu6uaeszYHoFsIk7sydXblAcOfo7MGACwwpiW3Fig
h8gftrpDOi6qfCjzOzhR0WkKacHVt5xrY3lpkC06i+0Ri81LXxXKpAYMx3G6XVQv
W/0invqIS8Q6FbQi+a33Bdt1cCKQgcYSMFlQsSMnlYGiW6ixOlbsF2WtT7WjG7aC
PhACLPESyedGRXSVsvy9z81kSmNOs2blGNpXnJhYn5kNHsymlZLcMR7OsWkmUC+0
pHkYx/XrFSBPe5tT22YHoNeBIjxYA+GS7ZWmn+pgt1Sy/Zqd0w8L9hTTpuN1t4tu
Syzy1Q8tUp9sFV1qqJwaA4zx0xQ6KJvGh1laebyBlW4Ej9igWklUGM5xlfMGNsaz
1usQVasNBlC28y8x3rUZSFxFocnvCMU9Upg9+Xsx+jRq2PG5H2KJQuWpdndk5PIA
GTeEvkdJ63XTSoL3UQ9nx5KkiEOMn4MWsTBORaNOLzcNAe3OD2VKeXmDqeL26qV4
LgyB4txXEJG55VQXNVZ5SV0j8l2xS9M6LLq5G4DbV4bl0i0m2+RxSB9XouokM1G/
W2zzn6VXu2Z/442GjoohwC8QA9pOug/ZB1BYd20S8h7TDrGZ3QkPzhjt/nHC1LAS
h82umKSpYRHGLAfnboV4/Xk1KcMbn1sXX8uk+vjE7I/TuA+b5wc=
=kmuy
-----END PGP SIGNATURE-----

--4yktvbxgbrrvhkrz--