Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Jun 2023 18:22:17 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Sascha Hauer <s.hauer@pengutronix.de>
Cc:     linux-rockchip@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Will Deacon <will@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, kernel@pengutronix.de,
        Michael Riesch <michael.riesch@wolfvision.net>,
        Robin Murphy <robin.murphy@arm.com>,
        Vincent Legoll <vincent.legoll@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v5 02/25] PM / devfreq: rockchip-dfi: Embed desc into
 private data struct
Message-ID: <20230613162217.auqdeogoxs35fuqe@mercury.elektranox.org>
References: <20230524083153.2046084-1-s.hauer@pengutronix.de>
 <20230524083153.2046084-3-s.hauer@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="jfxv54ui2trftfa7"
Content-Disposition: inline
In-Reply-To: <20230524083153.2046084-3-s.hauer@pengutronix.de>
Precedence: bulk


--jfxv54ui2trftfa7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, May 24, 2023 at 10:31:30AM +0200, Sascha Hauer wrote:
> No need for an extra allocation, just embed the struct
> devfreq_event_desc into the private data struct.
>=20
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

>  drivers/devfreq/event/rockchip-dfi.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event=
/rockchip-dfi.c
> index 74893c06aa087..467f9f42d38f7 100644
> --- a/drivers/devfreq/event/rockchip-dfi.c
> +++ b/drivers/devfreq/event/rockchip-dfi.c
> @@ -49,7 +49,7 @@ struct dmc_usage {
>   */
>  struct rockchip_dfi {
>  	struct devfreq_event_dev *edev;
> -	struct devfreq_event_desc *desc;
> +	struct devfreq_event_desc desc;
>  	struct dmc_usage ch_usage[RK3399_DMC_NUM_CH];
>  	struct device *dev;
>  	void __iomem *regs;
> @@ -204,14 +204,10 @@ static int rockchip_dfi_probe(struct platform_devic=
e *pdev)
> =20
>  	data->dev =3D dev;
> =20
> -	desc =3D devm_kzalloc(dev, sizeof(*desc), GFP_KERNEL);
> -	if (!desc)
> -		return -ENOMEM;
> -
> +	desc =3D &data->desc;
>  	desc->ops =3D &rockchip_dfi_ops;
>  	desc->driver_data =3D data;
>  	desc->name =3D np->name;
> -	data->desc =3D desc;
> =20
>  	data->edev =3D devm_devfreq_event_add_edev(&pdev->dev, desc);
>  	if (IS_ERR(data->edev)) {
> --=20
> 2.39.2
>=20

--jfxv54ui2trftfa7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmSIl7gACgkQ2O7X88g7
+pqavg//eGagVO58ELSDQgmcdseNzq5Z+G6qMNxVtz7FQsw+l/RWj2SPWK2u4g/a
sQ2WAQyE2/f/VIt3kp0evIvau8xhc77d84NCfuNOYHeWKsmnH81opNj5n5PiGAzK
iNwCRyecDGgOvar0ZqK+4RWS/+h0K//WH/dq85ssVMkkFye8GMTlYszbDWka5p98
BGQNHW7EuT8qCsni4haqU0CfW9/P0fSMPBjjygittVYlXu1Om2VCTBZpeB9uF6iQ
4hMJx9ih76+K4kQBMvxArKQOkZYBGYIUfjY97lH/YKZvrGf88Hm5RV2HiWzhN9v2
GUmxqlq/A2pyPBhlbRhZZNf/0At99qGKIUwyffLW5+6YLFgAtAysRleRmd2BpkXn
WrVsggohh0L0oaW4RWKeyT6/ZtcJ5qD9e1vari6JF0S+5+W+1CHtvEY+yQa3kekD
WVuc1HtRNeqkqjgiO9I051BOepkIrb6RTGJPi6Rsotz5QIQatW7GzhwUhhT0cDUs
f3ZcRjTvABqOfEVq4Y+ybEpcrhmlUW4hUPJjNsztf86D4mwAtUaRebpFof8NkJVn
9g3322XfKBBxRfMlnwYVeT7oNuMurn7YuyUvfydFSNyuxXYUdQEDj+Y2UQ2luBi8
IVunO3oplN9wAXOJHhYUsS//sGUeDNhcD7YwzSdxVnOs4ow2DVg=
=XyGu
-----END PGP SIGNATURE-----

--jfxv54ui2trftfa7--