Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        linux-kernel@vger.kernel.org
Subject: [PATCH net] net: dsa: felix: fix taprio guard band overflow at 10Mbps with jumbo frames
Date:   Tue, 13 Jun 2023 20:09:07 +0300
Message-Id: <20230613170907.2413559-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vuDA0wiVh3+AVIp6E4OIYTpK6bs01/CiwkUCpwmAn3bclDieEsTRCCK0Cp4T?=
 =?us-ascii?Q?s2tJl7CgGacHFkLrsY/5687OdXyHrd0H/xy2yjxKAtyeYlRor2ORUoXfdKb7?=
 =?us-ascii?Q?USDIUaAMJu6cRtpfJ9PLT5ojEd3aJGtooVpUejHl3jJQw1d2aWZ/uLMDO2rI?=
 =?us-ascii?Q?/P5nQ3P8rJHxBtYebzr66JUnwwpVu5TcC80Ynn1c1vDaz5MCkLL9untw4Hgx?=
 =?us-ascii?Q?o+v/GE9xHFPLNzr9XHnV91w/V0lowoCHWkJrS4LVbKDIPHo7SRvqc+ahpDV3?=
 =?us-ascii?Q?GUNxHLDSeLPjBJDW//SpksN0H4IRplHGYA2L3tV89T14Oz5XlVlyM7exJFH2?=
 =?us-ascii?Q?f/RPJPO6wpkt0D1//Xvj6K5HC5r2pIafKt93jRmVpWHjstXUleMDH6gArY0b?=
 =?us-ascii?Q?oQomMyJlkctCBwjCz1JNlu3Uv0df87vPOf5jNzTYkiOoyv2Ifujmeas15Pxd?=
 =?us-ascii?Q?f5XGl/tKFnuRYkdFCYx13hiVl2jc6tTgWQ+yVGGE/gDmS204wsRSkeHLEkk5?=
 =?us-ascii?Q?RoCoWP5UJrEzK9YnfjlQUe8Kumv2nB26HU5BPRcN6QD3MgnBFwnqI4nFREw/?=
 =?us-ascii?Q?gxHDw+BxB5OZ1uvIRFNsoQ45Q/AOYCjiq+4yxmGtvifHF9d4tvxt6M9VDJHZ?=
 =?us-ascii?Q?GoSDjtHXzeruz/KJA6IoH4ntUsvOP/65fX9sRRIZFavkwNZ7637MnBxyxEXN?=
 =?us-ascii?Q?wqkGv8dRofs3T1UBh0rlPItEsrfrrSjumb1qRWCaakdn0GZjbqWs2fxIp0yV?=
 =?us-ascii?Q?CjcPgcvcGj7k48Rk0w4UAeV7dsV130t3LxPQilpQTLZO7d3LMXhrzmimoW6Q?=
 =?us-ascii?Q?MWAO+Iucz022W+HPEPjnhwJE0qkYZyc7wT2RU6euPcAKo5V8oEMnCpxp2E19?=
 =?us-ascii?Q?sQ0zjpEMSfctYQOw7P4q4OFLup5FLRWK4VfYbuDsoMk+jWfF1gaERN9IQUL9?=
 =?us-ascii?Q?xjYGEgIeaDhOfQ1mynvOvL986kQm7dkM/6xZSjXlBhIiTChq4UCjnz+pYqCx?=
 =?us-ascii?Q?xt4FSjRpb+/0mcfCPlyU2JwdO2aTb+2Y3yQANfP/GGMi6qyEHbP4WFs8PKsh?=
 =?us-ascii?Q?c9mRaQuYeHL/boBU/atDuOCFSG8uTWF/5EL1Q28hcCly1otuq6fU/PqnMyeJ?=
 =?us-ascii?Q?Xmfi1MMTVb6PLrYLNZNHJyRwB8Lxeqf/uttFieAt5Sj273dhVjy7E+aOOZoJ?=
 =?us-ascii?Q?SoQmRcsyUH759bvJd410pjxYR5vQHU1bg2nqeWh7QmTmWFlxym61XezVXO/D?=
 =?us-ascii?Q?H7qq0CSWpCG7dT44b6FarIx+D7jx3payC1jrghm4R+iCOQGBZ38zRXtzb6cd?=
 =?us-ascii?Q?q/0ClVSKSMOUBz6VWBYtP/oUQD/rnStnDs+wrz2KF9WpHNJRzbXN3SUqjQRI?=
 =?us-ascii?Q?nxpMa90p+JrmCu/8x5UcKX8RjoaAiW+5zXPRDt1YW9r18eZx9waFIdozSVie?=
 =?us-ascii?Q?DvXFXt6i3XFFmvemN6L+cUwiEe1s97R0YObm4cHwbNP4+f12Bjmyh/Q91UcG?=
 =?us-ascii?Q?c2coCq0/gsjyNpQtx9j2h1ZLNc463+9u9kriQEvD+mXur07Zh9BT0Oz38eW9?=
 =?us-ascii?Q?IeOaB0QO3Q37LX7e70UPJ3TdbGGzsxejLcDpIfT0PBaZgbYC68ht2/Z3Pb76?=
 =?us-ascii?Q?SA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d88fd25-618d-4e24-e5fc-08db6c30ed02
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 17:09:19.5660
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SxGuWj92NxWVmP0nC3IkXGgLoH30Vta6RNs5R26OY+RuinQLDeyBcfJDNt0BMTH0xYpsMvAPVF0OGQv5uwssnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7548
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The DEV_MAC_MAXLEN_CFG register contains a 16-bit value - up to 65535.
Plus 2 * VLAN_HLEN (4), that is up to 65543.

The picos_per_byte variable is the largest when "speed" is lowest -
SPEED_10 = 10. In that case it is (1000000L * 8) / 10 = 800000.

Their product - 52434400000 - exceeds 32 bits, which is a problem,
because apparently, a multiplication between two 32-bit factors is
evaluated as 32-bit before being assigned to a 64-bit variable.
In fact it's a problem for any MTU value larger than 5368.

Cast one of the factors of the multiplication to u64 to force the
multiplication to take place on 64 bits.

Issue found by Coverity.

Fixes: 55a515b1f5a9 ("net: dsa: felix: drop oversized frames with tc-taprio instead of hanging the port")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/dsa/ocelot/felix_vsc9959.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c
index 903532ea9fa4..bb39fedd46c7 100644
--- a/drivers/net/dsa/ocelot/felix_vsc9959.c
+++ b/drivers/net/dsa/ocelot/felix_vsc9959.c
@@ -1251,7 +1251,7 @@ static void vsc9959_tas_guard_bands_update(struct ocelot *ocelot, int port)
 	/* Consider the standard Ethernet overhead of 8 octets preamble+SFD,
 	 * 4 octets FCS, 12 octets IFG.
 	 */
-	needed_bit_time_ps = (maxlen + 24) * picos_per_byte;
+	needed_bit_time_ps = (u64)(maxlen + 24) * picos_per_byte;
 
 	dev_dbg(ocelot->dev,
 		"port %d: max frame size %d needs %llu ps at speed %d\n",
-- 
2.34.1