Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Jun 2023 13:25:32 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Danilo Krummrich <dakr@redhat.com>
Cc:     airlied@gmail.com, daniel@ffwll.ch, tzimmermann@suse.de,
        mripard@kernel.org, corbet@lwn.net, christian.koenig@amd.com,
        bskeggs@redhat.com, matthew.brost@intel.com,
        boris.brezillon@collabora.com, alexdeucher@gmail.com,
        ogabbay@kernel.org, bagasdotme@gmail.com, willy@infradead.org,
        jason@jlekstrand.net, dri-devel@lists.freedesktop.org,
        nouveau@lists.freedesktop.org, linux-doc@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH drm-next v4 02/14] maple_tree: split up MA_STATE() macro
Message-ID: <20230613172532.o7gswjygcqndzsqw@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Danilo Krummrich <dakr@redhat.com>, airlied@gmail.com,
        daniel@ffwll.ch, tzimmermann@suse.de, mripard@kernel.org,
        corbet@lwn.net, christian.koenig@amd.com, bskeggs@redhat.com,
        matthew.brost@intel.com, boris.brezillon@collabora.com,
        alexdeucher@gmail.com, ogabbay@kernel.org, bagasdotme@gmail.com,
        willy@infradead.org, jason@jlekstrand.net,
        dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
        linux-doc@vger.kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20230606223130.6132-1-dakr@redhat.com>
 <20230606223130.6132-3-dakr@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230606223130.6132-3-dakr@redhat.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?riDRQKvDVDcQvV/GLBPlaOaEIJGT4e+YAImAlZNNXTo+Io3uogZNwOupum1Z?=
 =?us-ascii?Q?AKqG2RAq65hnZAkGde123Njw1FY4DA1lf+IuV9kgYZLysXlxxANPv/DKnd+r?=
 =?us-ascii?Q?67170BAljZs4ftmzZVbICxEp8bHMbcBusfzc7j6XR0rul0XVyQ2OrKjiX4Hz?=
 =?us-ascii?Q?6rwba9wyc1u3VC3LAObqQW03kIMeAHCiG/+LS43tr0EVyfGucN8LNIgK74F0?=
 =?us-ascii?Q?gVuSqnz9rDvCrT8qaA0kFdmUzSHFOkLT3Fwzzudk8PpUD1NrHBQ8cfF5VidD?=
 =?us-ascii?Q?ODMQQDgCshlNFFSyWaA7rtOwU+rSZbuNIjdHS3n7UVk6Rg43vCZusbniD2Ri?=
 =?us-ascii?Q?JrFJUEFAgWnHZbkaxD4aj2UJECPXowmCCZmtgC9AMIcTW9A5njt87E+0+uui?=
 =?us-ascii?Q?tGc7Lv1p/psjNYrSkMi9g4hCvBJfRxUNT2tBn1/ijWsRTPJZ1oxYGyNHoJTX?=
 =?us-ascii?Q?XwcTN1Y2AZDqcKh7K8q8rq2XcAZCzv85pyVLIqO8jD3H9YdDPIJlbKQv7zRT?=
 =?us-ascii?Q?IN4ah6GB+jhJPPRGOkiHp9upIO9/ne/4+A/uqXyGFV6Bdxr9A/tK6LH4zLEY?=
 =?us-ascii?Q?kEruXnT9ecxUKrm+CxPZ547uOJ5lOtsDh3qj3wMsdd6sT/DQd4suC5HeidQj?=
 =?us-ascii?Q?ciM+foC8lWFenVtk4kMzoQDNeoVu+lNTZeY9lXSLeY35vb5TA8HeMzx2OPk7?=
 =?us-ascii?Q?mdkhirRjcVtxMJ/jYiXyfGkEqvmf2I+mgRf+06qWORn2P/PPEgTY+cyVnsAi?=
 =?us-ascii?Q?ZYW0t/HLJth5XN43OlJZeduYWTb4mWEFBsicfcFXjR+P2UcPbDfjiOyOfwwk?=
 =?us-ascii?Q?PAvVUZE8+SKibTBKZL3hXNWM7cT1iSWiFkNB2qLN1SOrH/lrae72SaTe5yQ5?=
 =?us-ascii?Q?8dpJPpfoKS+OBYE6AddYOXcX5WRcSEXeSb2ZhwY4VMEotsr0HrXNDSsYtGb7?=
 =?us-ascii?Q?mKgpS+2u5Hf4TtWCgV8pHeCxpESwt5bPD5LokBLIoPYvOk/hMdNlGrS751fm?=
 =?us-ascii?Q?YFCoDwxhGkGL5yoYIxlHjcf9W4fC/b4qMgCex+Xm10XGgN5HbELlB0ZL/gFy?=
 =?us-ascii?Q?OwhLJhpDMfg7QlyUxnKUDPMWjHFYl2KH8eFAuJhZvNK98MOq/mUN2i/vztK5?=
 =?us-ascii?Q?aXtXo9Ls8EHPSn3/Xo5R0Oq3DyuRL92kXko4Vh0QEbV4cauDhxzXuZa0jINN?=
 =?us-ascii?Q?ShhtL7f3cbtBpnqGO06iaUQkLsP92+hHXwB8r3yUTsahSZxZmkl6gNqRDHl3?=
 =?us-ascii?Q?sdvB4ecxEPpitaHnB7N5/LS0gDhnjW0kW+j93EMGm6lUIDY5KLfGnuTQRnkN?=
 =?us-ascii?Q?LoNzgiNVDh0MB1B255YaTnhKG1Ii1A0NCzCEiuxeuUREsYZnNsJUsTuiOH6W?=
 =?us-ascii?Q?Agz676ZaMUZglGz4jVVrrBKn1UHUk4Kndp9UcduaogZBast4v+WXd7JZTCrs?=
 =?us-ascii?Q?u80r9CfMs4smTnZslb0dltSkzhuyHlO4nHfgqvrKPdM84aoABe12lfrpu2zn?=
 =?us-ascii?Q?2kzhwqRc6t5LnSkoCx5OiurlzcWvXMXi/mVeS1Z97aYo9rAOHpJ2o/abD2wH?=
 =?us-ascii?Q?L2XjXymVg5WTcIQyDWiFpnGWO3jW9zORFobowSIOfbUVNRDSRsRK7Mhactfg?=
 =?us-ascii?Q?DQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?N4WO+w89SjHcVLkFb4ZSm8WN+fMinGRDep2AOJDhKiZxA7ApQ9In/1oWTmyY?=
 =?us-ascii?Q?3fjIGyaB4rXko1MxneNNz6y2goncsuE7b2XD7Zzzt8NF/28ptNBpKUgWKi5K?=
 =?us-ascii?Q?38wkj7fesVoADTFNs5ic0gSk/sc3y1Zo+aiqdfwlVR/iWQHKpK+asybHVonI?=
 =?us-ascii?Q?PH4ZNmxaZxNyEhqgYY5Nu2OMh73B9RBo3kPy0glHGBh7XyFnhkNaPbKi4jf+?=
 =?us-ascii?Q?Yoy3vQU+ZRwq/76DRXoz5/qvFcOHJ+YCmvjRiQgne6PiuiEvbr7+aVr+RONV?=
 =?us-ascii?Q?5WcdmPa9f/em+WyTC3eAzqEwparXPH5hvkcQ2E0ITQZeU2d/ennN1AgB9SKu?=
 =?us-ascii?Q?6i5bzkLTSYsla8MyRUeVeGWS7aFMSW+1CwkqeGNBlreGZgyqGKC/BT7MMKXl?=
 =?us-ascii?Q?H6bpA0GDgEjod68XADnTBW4jYvrD4WqgjjF5Hmu4nolSS8NU41Y69NdwWthn?=
 =?us-ascii?Q?Vb6lCpOEz0A4lQc1xIUztGo/wqAjhFQr7tDidsOPgc2KOvZktm6cT7yNpx31?=
 =?us-ascii?Q?Ubonef9hQLBxSa7ERHWnqlukc1ZISW3fya56Y6AgNkAi1u4hKqnNMni1o+VW?=
 =?us-ascii?Q?TiuUf/KxIP68f/UM9opawRI+V2ybHkK3WYPMHfnXhll/Gh2Ajt+zBZwQpC7n?=
 =?us-ascii?Q?o4Elj3QMwyT35EL3IfP4+/eIUn/s0zykDmctYNbUvmrIDfZ54NTd195vkieu?=
 =?us-ascii?Q?FsxqtJFjwhDU6TIdlSCvJ7KVwU/bbCXTnzvILDgT+tHmqmE4K2xVfwUA9hQH?=
 =?us-ascii?Q?JRtIf6Eiit8tZrv84DiJGC0PkOrDSG3Bmeete1s515db62OUV6wYGW825tl2?=
 =?us-ascii?Q?OM2GPW0JtQDRMFZQvp2JR2KZNx3FWYi8INNeky8FiNBKzFCt3tacBiOIiTcr?=
 =?us-ascii?Q?UCAvit6eMquloXjCtGevj9Mdt0ormqzw8SX5Er0CamdDS+v0Uy2IIc9Wn6pc?=
 =?us-ascii?Q?tJ6Sz48IoJCLXVcR17jTGQWcNffFJCE0+vbyo9ObTJbQ0zHKIN9+X0Xkpldw?=
 =?us-ascii?Q?/AfVY79EY79iozKdxf7ky142/NhOaCy5Da+Pk0vq/Z8JIR3dxuxlNC45c4Ub?=
 =?us-ascii?Q?oivAyQtE6MPF0guu2DkDSc2++T5FYjZDBEVv7OUxcQ5HXQ04V95MAZMj7R+B?=
 =?us-ascii?Q?nfEbBrDmVMKwh/8giUYEGw9NmH1Do6/wzQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 640ce331-a024-4efd-a88b-08db6c333369
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 17:25:36.5681
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nR6pIlSOcQ1TdkqpFh3fuqPYbVilXS8AlpTWkn9LwfjkdlbcP3dusrSryZY/5zTfLvPWNEk3ssRJJKAzp0GNBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4596
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-13_20,2023-06-12_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 mlxscore=0
 spamscore=0 malwarescore=0 adultscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2306130154
X-Proofpoint-GUID: vpWtrFuiJbunxAjfgUpK1H4iSDUxzOT1
X-Proofpoint-ORIG-GUID: vpWtrFuiJbunxAjfgUpK1H4iSDUxzOT1
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Danilo Krummrich <dakr@redhat.com> [230606 18:31]:
> Split up the MA_STATE() macro such that components using the maple tree
> can easily inherit from struct ma_state and build custom tree walk
> macros to hide their internals from users.
> 
> Example:
> 
> struct sample_iterator {
> 	struct ma_state mas;
> 	struct sample_mgr *mgr;
> };
> 
> \#define SAMPLE_ITERATOR(name, __mgr, start)			\
> 	struct sample_iterator name = {				\
> 		.mas = MA_STATE_INIT(&(__mgr)->mt, start, 0),	\
> 		.mgr = __mgr,					\
> 	}
> 
> \#define sample_iter_for_each_range(it__, entry__, end__) \
> 	mas_for_each(&(it__).mas, entry__, end__)
> 
> --
> 
> struct sample *sample;
> SAMPLE_ITERATOR(si, min);
> 
> sample_iter_for_each_range(&si, sample, max) {
> 	frob(mgr, sample);
> }
> 
> Signed-off-by: Danilo Krummrich <dakr@redhat.com>

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>

> ---
>  include/linux/maple_tree.h | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/maple_tree.h b/include/linux/maple_tree.h
> index 1fadb5f5978b..87d55334f1c2 100644
> --- a/include/linux/maple_tree.h
> +++ b/include/linux/maple_tree.h
> @@ -423,8 +423,8 @@ struct ma_wr_state {
>  #define MA_ERROR(err) \
>  		((struct maple_enode *)(((unsigned long)err << 2) | 2UL))
>  
> -#define MA_STATE(name, mt, first, end)					\
> -	struct ma_state name = {					\
> +#define MA_STATE_INIT(mt, first, end)					\
> +	{								\
>  		.tree = mt,						\
>  		.index = first,						\
>  		.last = end,						\
> @@ -435,6 +435,9 @@ struct ma_wr_state {
>  		.mas_flags = 0,						\
>  	}
>  
> +#define MA_STATE(name, mt, first, end)					\
> +	struct ma_state name = MA_STATE_INIT(mt, first, end)
> +
>  #define MA_WR_STATE(name, ma_state, wr_entry)				\
>  	struct ma_wr_state name = {					\
>  		.mas = ma_state,					\
> -- 
> 2.40.1
> 
>