Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1589175rwd; Tue, 13 Jun 2023 11:08:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5luExdkCYmVomAU6lbwet8/D4mqRZe3f7bMRqe9kPReNg2QGAqeppn+xd1KM+rl+RuaSfu X-Received: by 2002:a05:6a00:234c:b0:663:13a9:9504 with SMTP id j12-20020a056a00234c00b0066313a99504mr18183440pfj.10.1686679692515; Tue, 13 Jun 2023 11:08:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686679692; cv=none; d=google.com; s=arc-20160816; b=KMZ+W5FBcPf6rZLPhadI7qiH5Z9feVVDiwdJszWbw686QLoOhUn0oKx9mgCrWhANqz 3L8rPp1bR8deA2qBGW8YkvX1V908+Vf61EY1voykr8rph0jiY6wR53qNWpfY1LDLhZtZ qf5dI5jKFFFPRJJQuNowf/7vZaxEPE+osy0Tkn7pzoMOVRSMviQm5WYo5M6Tf4L3uepO WqxZMftZPVff3ozWidHS/GAr38QaavXNzeT0CZdMPSRI1r5p6qWYm5+1MNg5Ok1Psy/H 7bNeaxNvVLb7sN2jovMXTi63B5Ex3gxWZ3Fu++We3LlSKsXxSoOfGtW7LReHmQ9VEtiC 4TKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=oquA6F/V3yzWtjUh4y6IKwJfdN3CCrv0UNat3zAzWzo=; b=JqVUzf5uhc+tWf+V3QbxfNIzTI/CJV+Fe5V9h4SNMWobMBZ7dp2Q6O1rcyCR1dBM5v QcsgGVrQz3fkSWSR4/eztQi0lJHj1ZtVRnkmgLZeIZrXJK1HSRqMZUfjwM38obmsEzvg Jxr+q02uqJaOzclLJ+PzQvnE/Zh7TKpoekuqNmP7aUiNdC+pcJxvH5Kwn0gIS0MzkrzD gWsnypiVs3VrTj9dFbogI+rK4J7Z3j4CuL3/A+nAtk5F39KTDsIvCUj4CMOvKlVV0pBa MygHmyzmjpku7MNiApF2PIgn0DcvRfdjDqKU/hTjZcb15Bu1VtFtcSfBMfqYP2Ih1GmV SVSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=g4a1E+MH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n1-20020aa79841000000b0063b7b7712a5si9035736pfq.304.2023.06.13.11.08.00; Tue, 13 Jun 2023 11:08:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=g4a1E+MH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235155AbjFMRxG (ORCPT + 99 others); Tue, 13 Jun 2023 13:53:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234693AbjFMRxE (ORCPT ); Tue, 13 Jun 2023 13:53:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CD84173E; Tue, 13 Jun 2023 10:53:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9FB2A62BBA; Tue, 13 Jun 2023 17:53:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 661C8C433F0; Tue, 13 Jun 2023 17:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686678783; bh=hOJkNt/HUS2Sl/TAnLkqJ+vyDEQMTGQ3jz3L8YGyuAI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g4a1E+MHv0xsUA9IBgPikrv3NWmMdqncwMfaPwd/VE9kl1aI5/s3bzPbzpStGUJxM ypdjZZogMt91+e64NZw5i48kouTAvqaUKO2yk80UqTOUed6rEiZKvSM6ZUHmN6wSoH l7pTNcSd026jxETBOPedfxlGfkTA6EscZUBzCMcnnyXacZZ+5dmQ6aeA72Vqq7AGx3 1voyVKcDvNuWYJd8dIcLMQAHtiJiK11/JBZGS64M+LsgQYM0qP9REXhmy62AxL0+QH t3eLtwA/sdbYtGe7nAkO0H+uMFZewpKZvAJL2f45BfxLw8LU2bRBP6fVwpffwqnW6/ 8k9fDNZZyb+fA== Date: Tue, 13 Jun 2023 10:56:26 -0700 From: Bjorn Andersson To: Konrad Dybcio Cc: Andy Gross , Michael Turquette , Stephen Boyd , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Stephan Gerhold Subject: Re: [PATCH 2/2] clk: qcom: gcc-msm8996: Use read-only RCG ops for RPM bus clocks Message-ID: <20230613175626.aesimqz2alcqjtok@ripper> References: <20230612-topic-rcg2_ro-v1-0-e7d824aeb628@linaro.org> <20230612-topic-rcg2_ro-v1-2-e7d824aeb628@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612-topic-rcg2_ro-v1-2-e7d824aeb628@linaro.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 12, 2023 at 11:22:48AM +0200, Konrad Dybcio wrote: > The config/periph/system NoC clocks are wholly controlled by the > RPM firmware and Linux should never ever alter their configuration. > Does Linux need to know about them? Regards, Bjorn > Switch them over to read-only ops to avoid that. > > Fixes: b1e010c0730a ("clk: qcom: Add MSM8996 Global Clock Control (GCC) driver") > Signed-off-by: Konrad Dybcio > --- > drivers/clk/qcom/gcc-msm8996.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-msm8996.c b/drivers/clk/qcom/gcc-msm8996.c > index 5e44d1bcca9e..588e3b67657a 100644 > --- a/drivers/clk/qcom/gcc-msm8996.c > +++ b/drivers/clk/qcom/gcc-msm8996.c > @@ -264,7 +264,7 @@ static struct clk_rcg2 system_noc_clk_src = { > .name = "system_noc_clk_src", > .parent_data = gcc_xo_gpll0_gpll0_early_div, > .num_parents = ARRAY_SIZE(gcc_xo_gpll0_gpll0_early_div), > - .ops = &clk_rcg2_ops, > + .ops = &clk_rcg2_ro_ops, > }, > }; > > @@ -284,7 +284,7 @@ static struct clk_rcg2 config_noc_clk_src = { > .name = "config_noc_clk_src", > .parent_data = gcc_xo_gpll0, > .num_parents = ARRAY_SIZE(gcc_xo_gpll0), > - .ops = &clk_rcg2_ops, > + .ops = &clk_rcg2_ro_ops, > }, > }; > > @@ -306,7 +306,7 @@ static struct clk_rcg2 periph_noc_clk_src = { > .name = "periph_noc_clk_src", > .parent_data = gcc_xo_gpll0, > .num_parents = ARRAY_SIZE(gcc_xo_gpll0), > - .ops = &clk_rcg2_ops, > + .ops = &clk_rcg2_ro_ops, > }, > }; > > > -- > 2.41.0 >