Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f8460975-731a-731c-e4a9-a310234182a2@intel.com>
Date:   Tue, 13 Jun 2023 11:37:05 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.11.0
Subject: Re: [PATCH v3 2/4] tools/testing/cxl: Fix command effects for
 inject/clear poison
To:     Vishal Verma <vishal.l.verma@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        "Davidlohr Bueso" <dave@stgolabs.net>,
        Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
        Russ Weight <russell.h.weight@intel.com>
References: <20230602-vv-fw_update-v3-0-869f82069c95@intel.com>
 <20230602-vv-fw_update-v3-2-869f82069c95@intel.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230602-vv-fw_update-v3-2-869f82069c95@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWs1VDJMbjYxMWtnc0pEcWR6aFBsUkptaGFVWk90V0tBYVRWa1p2YmFwVkJh?=
 =?utf-8?B?OGc5UmpkL1h0aHlUY3hNRmszeVlaRVFmanRmcC96K05TMUo5d2ZDRmFEVFNs?=
 =?utf-8?B?dWlocW5lc3JlMnF4cit2TjVvK3JrTEkxOVN3MDFNRXFsSFE5dzFhcDlOMXZu?=
 =?utf-8?B?RG1tcE5YT2sxQXpoZUhaUUdqa24wTXRUam1UREhPWGRxR2w1MDJuZlhWSUt6?=
 =?utf-8?B?UE5lSDBCWDgxelM4ZWdxNTNEWXFNUjB3UHJqbTl4STJ0anZxNHgvOWE3YU9o?=
 =?utf-8?B?TWFkMUM3T1BHUDViMGdVd2t5UFpiM00xY3Y3MTArSVV5eVNLS051SkpjV0RX?=
 =?utf-8?B?K3Fjc3M4WjZVaXVhUXdJd3dxL3FRQmkvZTBSNFVHL3ZRN2s5cHZmeDNzR1Jv?=
 =?utf-8?B?R0xlQ2NRTUtQaWF4ZXlSUHhwVE1KcUJVWm5oZGRqWW5sL2o4Y1NOY095Tm54?=
 =?utf-8?B?bTIrY1hCTEJGY0lTeWxSSlRPNWJPbUlIeUJrYmJGang1alZsTDNKMUFsNUpv?=
 =?utf-8?B?OXNxRnFJU2RVSmtYN2JwUlVmWVFOb2VBWk5XSGlRa2Q3MUhzQU5UcGk5Z3dQ?=
 =?utf-8?B?OUwwdHN2SmF5ZCtDMjAvN0g5ak03OWFkWk1PRDBJQks4TDYzN0xGdURCZytw?=
 =?utf-8?B?K0FLQ0h5R1UxeUI3M2MrMTFhdjJTOGYrNUZjTlhKYzBjWko1VnVCVWNmMzZM?=
 =?utf-8?B?Nisyakl0Y1h5eEFIYy9sTEU4T29pRUdwSWQrWURDU2FNbTF5NWZNQjdRbmNB?=
 =?utf-8?B?c09pTjlyZjZrdUE2QmpxemQ2RTlreGVYNEI5eGFPM2kyVmZZeHpkbHdvUyto?=
 =?utf-8?B?engzNGR5VGd1SkcyVjVUTGJncHd6ZW5ZckJqNlZOSjJNUHZRUm5udStLMmtj?=
 =?utf-8?B?UG90dDBWN2xDc1RVT2ZqY2xHS1Z2eFMrTUFQalFWLzNBQ3pJMWNUUWpRaUhh?=
 =?utf-8?B?ZXJ6YXVvSHpOMUljdS84RGFuNjVIdTJxVG0zaldFUFFPRExUTnFXSjNKdjUy?=
 =?utf-8?B?U1QwNzdBYjNmUVFrbGU4T3Z6K2VmUDZLdnI3a0JaeVJ2UmRkMloycDZHTXo0?=
 =?utf-8?B?cGE3RFFHeGNjYXJwOGVicm9BUUF0TVozVW0xYVNOMnl5cVV2Z2JocDFMcWpp?=
 =?utf-8?B?SU0zc2hhOW9xY2ZSTElMUWZ6bUpoWFpuU1I1MmR1Y09ZbEdEU3BjTkNRUnhk?=
 =?utf-8?B?RTFNSjdicGpzUGJmMVFrT0pOOGFLZDJBUnc2azl4a2NCQUhEQ3phZ1NWUXhF?=
 =?utf-8?B?RndOY1BadXNCcUhZb29ndDF1a2VtOXhXdFZsVTBoblZ2NHJpL3JDalVIK2kr?=
 =?utf-8?B?QUdoeVZ0MW4vNVRVTXNPbXNsVjVpZkpacHJCck04OWRvM2V5a215YjIvejgv?=
 =?utf-8?B?Q0ZDbVlDc1hadHJwNnAzMGFldVNxZm1RTWZjY3oyRG9JTzRQdVMyZVNpb084?=
 =?utf-8?B?MjVBT3R1UGRBaGZiQ1hOcXZ5VFVFTnpoZ0Y1QnZYMFdydHp1ckdwencrMUox?=
 =?utf-8?B?ZDdpMnExNG91OVZ6SndKbUFwTVpNQlV1SFlXa0J1SVFQUE9sYWR1aS9GaDhV?=
 =?utf-8?B?MmxmUGtpWlcvWHFqQTRQRmY1S2VXRSsyaDZNV0h6QXN4bHF3cGYrMjAwN3lB?=
 =?utf-8?B?dVptaC9rZmF5ZGtPdzBRc2puWU1Vd1o5am9USFVLajM5UTVDM2l3S0lzYnlw?=
 =?utf-8?B?TUpralN5UXlVV21nWmhDcXoyT2NMcjNkWGY3ajRBb2lYMW83SkhhaUN3L1U5?=
 =?utf-8?B?UTg1SzZwbDNaM2xXQndGUWJ4MGdFWnNDeGkzYUQ2Z3dzYUZ0MDJtRnhUV012?=
 =?utf-8?B?eU5BRWs1RGFralVUUHpoeDlVMlNMMmNYSnA1ZzR3WnVSbW51Ulc5YllkMXhh?=
 =?utf-8?B?SmJOakN6cjNVWkpqWm5KZzdvUXF3YjFqVXJ6RSt1S2VYSnNNNFJzZkZYek8v?=
 =?utf-8?B?L3VUQmZyN1RITlQwaUtyc2Rxa05DbEVqajV1NHpwWHg2YzlCRWU3QkluV1JN?=
 =?utf-8?B?YkhGQ2gwZ0szMGN0WmhrbFc2NGMwQ1gydldPbE5iVzM2SWN5Nk05bGNWamxH?=
 =?utf-8?B?WXpNdGE0Z2VOYzNwRGdtV1dIeWdsbERSdXFaWS91TWRFZGFnNmxLc3kveUFh?=
 =?utf-8?Q?xwE8IewNY/aMhEtsJrRTaBdgB?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b067c0e-6c6c-4629-f5e5-08db6c3d320e
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 18:37:09.4419
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TfYA3wpMukvzgj3LYvitCwIdGIoHvPCC4BVMKpwBEkBpVJXMbtyPZH7d0IdRYpCUf54vpv5NyQSG+S5tlwmU7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4840
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/11/23 23:55, Vishal Verma wrote:
> The CXL spec (3.0, section 8.2.9.8.4) Lists Inject Poison and Clear
> Poison as having the effects of "Immediate Data Change". Fix this in the
> mock driver so that the command effect log is populated correctly.
>
> Fixes: 371c16101ee8 ("tools/testing/cxl: Mock the Inject Poison mailbox command")
> Cc: Alison Schofield <alison.schofield@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Reviewed-by: Alison Schofield <alison.schofield@intel.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>


> ---
>   tools/testing/cxl/test/mem.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/cxl/test/mem.c b/tools/testing/cxl/test/mem.c
> index 34b48027b3de..403cd3608772 100644
> --- a/tools/testing/cxl/test/mem.c
> +++ b/tools/testing/cxl/test/mem.c
> @@ -52,11 +52,11 @@ static struct cxl_cel_entry mock_cel[] = {
>   	},
>   	{
>   		.opcode = cpu_to_le16(CXL_MBOX_OP_INJECT_POISON),
> -		.effect = cpu_to_le16(0),
> +		.effect = cpu_to_le16(EFFECT(2)),
>   	},
>   	{
>   		.opcode = cpu_to_le16(CXL_MBOX_OP_CLEAR_POISON),
> -		.effect = cpu_to_le16(0),
> +		.effect = cpu_to_le16(EFFECT(2)),
>   	},
>   };
>   
>