Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Jun 2023 13:12:00 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Benjamin LaHaise <bcrl@kvack.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>, <linux-aio@kvack.org>,
        <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH] fs/aio: Stop allocating aio rings from HIGHMEM
Message-ID: <6488cd9030687_1ad89929456@iweiny-mobl.notmuch>
References: <20230609145937.17610-1-fmdefrancesco@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230609145937.17610-1-fmdefrancesco@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4quljjVk8PFKyav9+gYG/RBSCL5vxNuukapMjju9neDORG/fWzLKTwtCDTj+?=
 =?us-ascii?Q?3Gu7/EokpxzUKU8osnPbsSk5prt7Wnh+dVHuqTmEurfha80tKh71C+nqJLVr?=
 =?us-ascii?Q?zxklhjB4kAnBRgYe6Zg1KZDbb4dfItwyqvNXIgLJki8eOiPL0PHCiqlJch4w?=
 =?us-ascii?Q?rd3VshB0rtBD65Gv4eIhieUJelb0KvBGPCPJQt7Pwct1O0gyoT7Kk+cshxZd?=
 =?us-ascii?Q?rgUdB3FYZ7cZ+Sfhz78DCqNL3vMIX/iqdumYV6lizWyl6BKNoz0gbn5FIxqY?=
 =?us-ascii?Q?Ls3/+noX/GB2Xiaotw/XGOB2Y28/pPZbbsWfsNiRYHXQYIgOu7oZ0oONwuK9?=
 =?us-ascii?Q?F9IeGoxqmpMbvTmQrKbivZJWXyYCWbJhNKr9xbT0IGQyMOHCc/6CLckHriTo?=
 =?us-ascii?Q?8M66QSdbHk7/T5ZNn4JPI8djJsC5IbRfkjO6fAZUMbwM+OTHFKoJgKiim3pN?=
 =?us-ascii?Q?8RelSBBZWSHkUR4k++RC3ga1aIdVGfgmESll5EINbXPrtzfpyG3RjuTTYXVl?=
 =?us-ascii?Q?JltwiJpL69xzysyLmdc2+2g2lA47elry6SJgeg4bsF2gZOx0wbZm6L1kcG+R?=
 =?us-ascii?Q?KiBUy+4TibYPCLbJDtnMcQhz9oB3PaenQX0qKgUXnefdd00nZYVcYZKSHncW?=
 =?us-ascii?Q?K0IPiAGoBjDZWHKdFVRu0/Pr2FYdI2ODX6rGIG/wcYNGD9/IxizVaEUAU8fk?=
 =?us-ascii?Q?y3TwruRACGWgJA5WLeoqgjcgYb8V9Fsf8lrrngCQXxTquNI3ltoRiEdTBwNt?=
 =?us-ascii?Q?2hcZaczvOMvJM32kvlRpkBOn/XJo7QwjLekaCf6bxbO+v867UfnKatxqJWXW?=
 =?us-ascii?Q?X/IGKZ7l+kdsrDXqadu9baQcLHiWPAkzU4CPPNm00BGsZZG0wwUQP9w8Ug+E?=
 =?us-ascii?Q?ewbUDzhV+/2e7wYvXW9lijG5uYZqhh7Z/kdfY7ezbOmRjvXaQ+8vFDqLlDBr?=
 =?us-ascii?Q?VmR877Pu732Smn2t1WKaHwz7x1AmgS+hq+E71hp309/L7U/cpMm0FV1DzpDe?=
 =?us-ascii?Q?spjVRVX3qbYgAxMRZBAqRcU48PtTtOt4mdrv0UfdsnFq5zd/AI/G+3kF1ANp?=
 =?us-ascii?Q?8FK97w9MWkFQ9Eyyo1D+0cW+DcjdtyxSXia7kkflZUIJQopfqSA3wv795Q/X?=
 =?us-ascii?Q?8RDUGQ+kpusPzdPoZtB/8ElZXHs7s/VEo8ntxGr2d8XkRf2WCrqu0pPjubua?=
 =?us-ascii?Q?HyJH6V/stwkRNmvCAfO8w6MITsiwVxNAJE65VTX004xieCnUqGqa3Fi1ZTIM?=
 =?us-ascii?Q?65KB5x5PPSANyJLVUeV+aaUnIG0VP1zXn8OXEi01DFqt/iqm21r2wJOHX2bv?=
 =?us-ascii?Q?INyddVEX7W0dt+p3phlmT0zg+bZGzHgodv5mfHOqIPvzLT3YwGODEoT7AMbF?=
 =?us-ascii?Q?h4uOQ1WwI3ZgTR+9q2E2jlHxmn0bkeR8wcrULQ8uVdeJP+53A/hHY2lIRdPY?=
 =?us-ascii?Q?STOpG2BONXpuAA8Q1fnPf0POPfWu/6lWmtMAscPoauZ4A3kOvDI9e5UhaZTt?=
 =?us-ascii?Q?VK4jLbBEZLimCOybdtbesLJBGz/bxrolAxz6g6QuuDZDwNjXQ4CNG5YO+ha8?=
 =?us-ascii?Q?BE3velaYlpAWCyylxfpzdWVd66ll4lpIfuomV6CN?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 62e54d54-86e3-4af9-20b0-08db6c4a75d5
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 20:12:06.7508
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nHrkUMWhWYmHXgMnVL39pATr+X1piyuWK/hKkEVgdXbxQQZKOaYAAHTZW3oARnnCJd1Ccx07j2F8FWV0nF6Q0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5527
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fabio M. De Francesco wrote:
> There is no need to allocate aio rings from HIGHMEM because of very
> little memory needed here.
> 
> Therefore, use GFP_USER flag in find_or_create_page() and get rid of
> kmap*() mappings.
> 
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Ira Weiny <ira.weiny@intel.com>
> Suggested-by: Matthew Wilcox <willy@infradead.org>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
>  fs/aio.c | 26 +++++++++-----------------
>  1 file changed, 9 insertions(+), 17 deletions(-)
> 
> diff --git a/fs/aio.c b/fs/aio.c
> index b0b17bd098bb..77e33619de40 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c

[snip]

> @@ -1250,10 +1244,9 @@ static long aio_read_events_ring(struct kioctx *ctx,
>  		avail = min(avail, nr - ret);
>  		avail = min_t(long, avail, AIO_EVENTS_PER_PAGE - pos);
>  
> -		ev = kmap(page);
> +		ev = page_address(page);

NIT: This might be cleaner to remove the temp variable;

		ev = page_address(ctx->ring_pages[pos / AIO_EVENTS_PER_PAGE];

But generally LGTM.

Reviewed-by: Ira Weiny <ira.weiny@intel.com>