Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230607162700.3234712-1-kan.liang@linux.intel.com> <20230607162700.3234712-9-kan.liang@linux.intel.com>
In-Reply-To: <20230607162700.3234712-9-kan.liang@linux.intel.com>
From:   Ian Rogers <irogers@google.com>
Date:   Tue, 13 Jun 2023 13:21:30 -0700
Message-ID: <CAP-5=fV7b=xGuSED88mNJ1k86mTt3YH185+PsedqWPYg4EL0zQ@mail.gmail.com>
Subject: Re: [PATCH 8/8] perf test: Add test case for the standard perf stat output
To:     kan.liang@linux.intel.com
Cc:     acme@kernel.org, mingo@redhat.com, peterz@infradead.org,
        namhyung@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        ak@linux.intel.com, eranian@google.com, ahmad.yasin@intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jun 7, 2023 at 9:27=E2=80=AFAM <kan.liang@linux.intel.com> wrote:
>
> From: Kan Liang <kan.liang@linux.intel.com>
>
> Add a new test case to verify the standard perf stat output with
> different options.
>
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> ---
>  tools/perf/tests/shell/stat+std_output.sh | 259 ++++++++++++++++++++++
>  1 file changed, 259 insertions(+)
>  create mode 100755 tools/perf/tests/shell/stat+std_output.sh
>
> diff --git a/tools/perf/tests/shell/stat+std_output.sh b/tools/perf/tests=
/shell/stat+std_output.sh
> new file mode 100755
> index 000000000000..b9db0f245450
> --- /dev/null
> +++ b/tools/perf/tests/shell/stat+std_output.sh
> @@ -0,0 +1,259 @@
> +#!/bin/bash
> +# perf stat STD output linter
> +# SPDX-License-Identifier: GPL-2.0
> +# Tests various perf stat STD output commands for
> +# default event and metricgroup
> +
> +set -e
> +
> +skip_test=3D0
> +
> +stat_output=3D$(mktemp /tmp/__perf_test.stat_output.std.XXXXX)
> +
> +event_name=3D(cpu-clock task-clock context-switches cpu-migrations page-=
faults cycles instructions branches branch-misses stalled-cycles-frontend s=
talled-cycles-backend)
> +event_metric=3D("CPUs utilized" "CPUs utilized" "/sec" "/sec" "/sec" "GH=
z" "insn per cycle" "/sec" "of all branches" "frontend cycles idle" "backen=
d cycles idle")
> +
> +metricgroup_name=3D(TopdownL1 TopdownL2)
> +
> +cleanup() {
> +  rm -f "${stat_output}"
> +
> +  trap - EXIT TERM INT
> +}
> +
> +trap_cleanup() {
> +  cleanup
> +  exit 1
> +}
> +trap trap_cleanup EXIT TERM INT
> +
> +function commachecker()
> +{
> +       local -i cnt=3D0
> +       local prefix=3D1
> +
> +       case "$1"
> +       in "--interval")        prefix=3D2
> +       ;; "--per-thread")      prefix=3D2
> +       ;; "--system-wide-no-aggr")     prefix=3D2
> +       ;; "--per-core")        prefix=3D3
> +       ;; "--per-socket")      prefix=3D3
> +       ;; "--per-node")        prefix=3D3
> +       ;; "--per-die")         prefix=3D3
> +       ;; "--per-cache")       prefix=3D3
> +       esac
> +
> +       while read line
> +       do
> +               # Ignore initial "started on" comment.
> +               x=3D${line:0:1}
> +               [ "$x" =3D "#" ] && continue
> +               # Ignore initial blank line.
> +               [ "$line" =3D "" ] && continue
> +               # Ignore "Performance counter stats"
> +               x=3D${line:0:25}
> +               [ "$x" =3D "Performance counter stats" ] && continue
> +               # Ignore "seconds time elapsed" and break
> +               [[ "$line" =3D=3D *"time elapsed"* ]] && break
> +
> +               main_body=3D$(echo $line | cut -d' ' -f$prefix-)
> +               x=3D${main_body%#*}
> +               # Check default metricgroup
> +               y=3D$(echo $x | tr -d ' ')
> +               [ "$y" =3D "" ] && continue
> +               for i in "${!metricgroup_name[@]}"; do
> +                       [[ "$y" =3D=3D *"${metricgroup_name[$i]}"* ]] && =
break
> +               done
> +               [[ "$y" =3D=3D *"${metricgroup_name[$i]}"* ]] && continue
> +
> +               # Check default event
> +               for i in "${!event_name[@]}"; do
> +                       [[ "$x" =3D=3D *"${event_name[$i]}"* ]] && break
> +               done
> +
> +               [[ ! "$x" =3D=3D *"${event_name[$i]}"* ]] && {
> +                       echo "Unknown event name in $line" 1>&2
> +                       exit 1;
> +               }
> +
> +               # Check event metric if it exists
> +               [[ ! "$main_body" =3D=3D *"#"* ]] && continue
> +               [[ ! "$main_body" =3D=3D *"${event_metric[$i]}"* ]] && {
> +                       echo "wrong event metric. expected ${event_metric=
[$i]} in $line" 1>&2
> +                       exit 1;
> +               }
> +       done < "${stat_output}"
> +       return 0
> +}
> +
> +# Return true if perf_event_paranoid is > $1 and not running as root.
> +function ParanoidAndNotRoot()
> +{
> +        [ $(id -u) !=3D 0 ] && [ $(cat /proc/sys/kernel/perf_event_paran=
oid) -gt $1 ]
> +}
> +
> +check_no_args()
> +{
> +       echo -n "Checking STD output: no args "
> +       perf stat -o "${stat_output}" true
> +        commachecker --no-args
> +       echo "[Success]"
> +}
> +
> +check_system_wide()
> +{
> +       echo -n "Checking STD output: system wide "
> +       if ParanoidAndNotRoot 0
> +       then
> +               echo "[Skip] paranoid and not root"
> +               return
> +       fi
> +       perf stat -a -o "${stat_output}" true
> +        commachecker --system-wide
> +       echo "[Success]"
> +}
> +
> +check_system_wide_no_aggr()
> +{
> +       echo -n "Checking STD output: system wide no aggregation "
> +       if ParanoidAndNotRoot 0
> +       then
> +               echo "[Skip] paranoid and not root"
> +               return
> +       fi
> +       perf stat -A -a --no-merge -o "${stat_output}" true
> +        commachecker --system-wide-no-aggr
> +       echo "[Success]"
> +}
> +
> +check_interval()
> +{
> +       echo -n "Checking STD output: interval "
> +       perf stat -I 1000 -o "${stat_output}" true
> +        commachecker --interval
> +       echo "[Success]"
> +}
> +
> +
> +check_per_core()
> +{
> +       echo -n "Checking STD output: per core "
> +       if ParanoidAndNotRoot 0
> +       then
> +               echo "[Skip] paranoid and not root"
> +               return
> +       fi
> +       perf stat --per-core -a -o "${stat_output}" true
> +        commachecker --per-core
> +       echo "[Success]"
> +}
> +
> +check_per_thread()
> +{
> +       echo -n "Checking STD output: per thread "
> +       if ParanoidAndNotRoot 0
> +       then
> +               echo "[Skip] paranoid and not root"
> +               return
> +       fi
> +       perf stat --per-thread -a -o "${stat_output}" true
> +        commachecker --per-thread
> +       echo "[Success]"
> +}
> +
> +check_per_cache_instance()
> +{
> +       echo -n "Checking STD output: per cache instance "
> +       if ParanoidAndNotRoot 0
> +       then
> +               echo "[Skip] paranoid and not root"
> +               return
> +       fi
> +       perf stat  --per-cache -a true 2>&1 | commachecker --per-cache
> +       echo "[Success]"
> +}
> +
> +check_per_die()
> +{
> +       echo -n "Checking STD output: per die "
> +       if ParanoidAndNotRoot 0
> +       then
> +               echo "[Skip] paranoid and not root"
> +               return
> +       fi
> +       perf stat --per-die -a -o "${stat_output}" true
> +        commachecker --per-die
> +       echo "[Success]"
> +}
> +
> +check_per_node()
> +{
> +       echo -n "Checking STD output: per node "
> +       if ParanoidAndNotRoot 0
> +       then
> +               echo "[Skip] paranoid and not root"
> +               return
> +       fi
> +       perf stat --per-node -a -o "${stat_output}" true
> +        commachecker --per-node
> +       echo "[Success]"
> +}
> +
> +check_per_socket()
> +{
> +       echo -n "Checking STD output: per socket "
> +       if ParanoidAndNotRoot 0
> +       then
> +               echo "[Skip] paranoid and not root"
> +               return
> +       fi
> +       perf stat --per-socket -a -o "${stat_output}" true
> +        commachecker --per-socket
> +       echo "[Success]"
> +}
> +
> +# The perf stat options for per-socket, per-core, per-die
> +# and -A ( no_aggr mode ) uses the info fetched from this
> +# directory: "/sys/devices/system/cpu/cpu*/topology". For
> +# example, socket value is fetched from "physical_package_id"
> +# file in topology directory.
> +# Reference: cpu__get_topology_int in util/cpumap.c
> +# If the platform doesn't expose topology information, values
> +# will be set to -1. For example, incase of pSeries platform
> +# of powerpc, value for  "physical_package_id" is restricted
> +# and set to -1. Check here validates the socket-id read from
> +# topology file before proceeding further
> +
> +FILE_LOC=3D"/sys/devices/system/cpu/cpu*/topology/"
> +FILE_NAME=3D"physical_package_id"
> +
> +check_for_topology()
> +{
> +       if ! ParanoidAndNotRoot 0
> +       then
> +               socket_file=3D`ls $FILE_LOC/$FILE_NAME | head -n 1`
> +               [ -z $socket_file ] && return 0
> +               socket_id=3D`cat $socket_file`
> +               [ $socket_id =3D=3D -1 ] && skip_test=3D1
> +               return 0
> +       fi
> +}

Tests, great! This logic is taken from
tools/perf/tests/shell/stat+csv_output.sh, could we share the
implementation between that and here by moving the code into something
in the lib directory?

Thanks,
Ian

> +
> +check_for_topology
> +check_no_args
> +check_system_wide
> +check_interval
> +check_per_thread
> +check_per_node
> +if [ $skip_test -ne 1 ]
> +then
> +       check_system_wide_no_aggr
> +       check_per_core
> +       check_per_cache_instance
> +       check_per_die
> +       check_per_socket
> +else
> +       echo "[Skip] Skipping tests for system_wide_no_aggr, per_core, pe=
r_die and per_socket since socket id exposed via topology is invalid"
> +fi
> +cleanup
> +exit 0
> --
> 2.35.1
>