Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Jun 2023 17:31:54 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Ian Rogers <irogers@google.com>
Cc:     kan.liang@linux.intel.com, mingo@redhat.com, peterz@infradead.org,
        namhyung@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        ak@linux.intel.com, eranian@google.com, ahmad.yasin@intel.com,
        Jing Zhang <renyu.zj@linux.alibaba.com>,
        John Garry <john.g.garry@oracle.com>
Subject: Re: [PATCH 4/8] perf vendor events arm64: Add default tags into
 topdown L1 metrics
Message-ID: <ZIjSOjV6JePKH1lu@kernel.org>
References: <20230607162700.3234712-1-kan.liang@linux.intel.com>
 <20230607162700.3234712-5-kan.liang@linux.intel.com>
 <CAP-5=fXjR_yhFqob_Kzsh3+dQ5N6zXzu-FJO5b4-qgYULth=eQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAP-5=fXjR_yhFqob_Kzsh3+dQ5N6zXzu-FJO5b4-qgYULth=eQ@mail.gmail.com>
Precedence: bulk

Em Tue, Jun 13, 2023 at 12:45:10PM -0700, Ian Rogers escreveu:
> On Wed, Jun 7, 2023 at 9:27 AM <kan.liang@linux.intel.com> wrote:
> >
> > From: Kan Liang <kan.liang@linux.intel.com>
> >
> > Add the default tags for ARM as well.
> >
> > Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> > Cc: Jing Zhang <renyu.zj@linux.alibaba.com>
> > Cc: John Garry <john.g.garry@oracle.com>
> 
> Acked-by: Ian Rogers <irogers@google.com>

Thanks, applied.

- Arnaldo

 
> Thanks,
> Ian
> 
> > ---
> >  tools/perf/pmu-events/arch/arm64/sbsa.json | 12 ++++++++----
> >  1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/tools/perf/pmu-events/arch/arm64/sbsa.json b/tools/perf/pmu-events/arch/arm64/sbsa.json
> > index f678c37ea9c3..f90b338261ac 100644
> > --- a/tools/perf/pmu-events/arch/arm64/sbsa.json
> > +++ b/tools/perf/pmu-events/arch/arm64/sbsa.json
> > @@ -2,28 +2,32 @@
> >      {
> >          "MetricExpr": "stall_slot_frontend / (#slots * cpu_cycles)",
> >          "BriefDescription": "Frontend bound L1 topdown metric",
> > -        "MetricGroup": "TopdownL1",
> > +        "DefaultMetricgroupName": "TopdownL1",
> > +        "MetricGroup": "Default;TopdownL1",
> >          "MetricName": "frontend_bound",
> >          "ScaleUnit": "100%"
> >      },
> >      {
> >          "MetricExpr": "(1 - op_retired / op_spec) * (1 - stall_slot / (#slots * cpu_cycles))",
> >          "BriefDescription": "Bad speculation L1 topdown metric",
> > -        "MetricGroup": "TopdownL1",
> > +        "DefaultMetricgroupName": "TopdownL1",
> > +        "MetricGroup": "Default;TopdownL1",
> >          "MetricName": "bad_speculation",
> >          "ScaleUnit": "100%"
> >      },
> >      {
> >          "MetricExpr": "(op_retired / op_spec) * (1 - stall_slot / (#slots * cpu_cycles))",
> >          "BriefDescription": "Retiring L1 topdown metric",
> > -        "MetricGroup": "TopdownL1",
> > +        "DefaultMetricgroupName": "TopdownL1",
> > +        "MetricGroup": "Default;TopdownL1",
> >          "MetricName": "retiring",
> >          "ScaleUnit": "100%"
> >      },
> >      {
> >          "MetricExpr": "stall_slot_backend / (#slots * cpu_cycles)",
> >          "BriefDescription": "Backend Bound L1 topdown metric",
> > -        "MetricGroup": "TopdownL1",
> > +        "DefaultMetricgroupName": "TopdownL1",
> > +        "MetricGroup": "Default;TopdownL1",
> >          "MetricName": "backend_bound",
> >          "ScaleUnit": "100%"
> >      }
> > --
> > 2.35.1
> >

-- 

- Arnaldo