Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1755607rwd; Tue, 13 Jun 2023 13:48:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7DsSwuQOAcJAcCQQ6+vSVGQbSrYOON5gqwW2sW/O1aILgmGJ2O+KPubkIE5Dq4B0AqANYb X-Received: by 2002:a17:902:9304:b0:1ae:626b:475f with SMTP id bc4-20020a170902930400b001ae626b475fmr9258341plb.12.1686689337596; Tue, 13 Jun 2023 13:48:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686689337; cv=none; d=google.com; s=arc-20160816; b=fpQrgF8K08Nt0n2Idr7vmwKGwtcirnaTY7FwLGCJZps5e8OKR1JyH4fGLCuW7M/+8c +Wd3CEqxQdvdxHT0WyMN2z7WQR2T6XXNlnF8kp33sRpmD/Y6t4scmsPazgmgHHstfhlS 6ysk0eX0NIyWzNLhd7+vSnsXZZld6oS0fmE1wlz6tcWCPMo19dkc+6fHpffZYem57BkV aHmWWK89gl5/KJPTj/N5GkFi/KB0i1tVsSQs1G2W2XEJvt8apv3SWWZw2Uw13TWu4qjf V94eVipwyLZcVSwY0ZlzS9fLqr/xszBO7YFdRoSGJRSYF2HOj48IsVMxSE/aUPHKxO8A Crvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=KYTi7R1na9a50Ov2kINcNl6p8dn3MSr2AXDHhuOecUI=; b=l7//nIhPou9HgPR6GNDM/Az9vZOUyx95kQY8oh2HRY1JS1daLbzIZioWk+61T5WC7h wPUnjS5nh5PvBQOyZwpBImZUIooRi1Mlg7eVXOx2LlWcVlrEPxh9ipPTp5hL070xln2l WOBgKC5QKpewe6fgmNK9lMUw5QNF/49La0vwIo06a2BN+1qdW6UVB5L4VKLVPqX3eY2E GkSiOU1A0HYnTs5qNc3JFJj0ReHXcNZ+8wI4ZLu2l5Skq8+i0Clj5rbmVkCBI8gQUZvA DpVwzj6a7+bqI9AZkU4n+gHCUwtCZZQp/2/cSSwyp4VMDhwMiPLEQUVuQr2da5t2olxp s02w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=A260gQeE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d1-20020a170902b70100b001b06fa86af9si9199701pls.462.2023.06.13.13.48.44; Tue, 13 Jun 2023 13:48:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=A260gQeE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236080AbjFMUbH (ORCPT + 99 others); Tue, 13 Jun 2023 16:31:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239641AbjFMUaz (ORCPT ); Tue, 13 Jun 2023 16:30:55 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 676011BF5 for ; Tue, 13 Jun 2023 13:30:49 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-652d1d3e040so4563221b3a.1 for ; Tue, 13 Jun 2023 13:30:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1686688249; x=1689280249; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KYTi7R1na9a50Ov2kINcNl6p8dn3MSr2AXDHhuOecUI=; b=A260gQeEMHclZVygyc4n4vupbAvrqkqlnSosMCjUQD0YbVX7Gy8i2OOdQuIox7hkhN 8T5kSuAv6qgx7XTcXaTrpa95anM+bQ837h4+gW0RnWvX+GJqL2T65ruQCIM0vWGze9nG R/v1av+YEyGKHi6dl13wLfSn/8h1bGTtHfusw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686688249; x=1689280249; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KYTi7R1na9a50Ov2kINcNl6p8dn3MSr2AXDHhuOecUI=; b=E8u1+1B2GEBc8vvDTSFDoVBKuLNkpWKivv+Y80YaGtt3IiEc7opbV3O0HLP/nt9M0W dVrMbi31dI4qQ1XTcDLU7SYdwtS2TS784kczZOY89lWE585HtYwykZKVsbLdqLyZgFEn ZHNFnZ3THbWwStzo/xb1paQ4zVh9RkjlCux3cTXO2LKzVvyGMESyKdpQsDCE0RVPus/L VYMkfcgJ64RqTL91Eac65fcD07D0F7ifhyNSxUxvGbnq13YKtv3DI1nffUL7MiOmhIUY 0x28Qq6PmXO8WA/Z7WqH6Zl1FTPNG28EQGGWAJ48qeNw0E8e5boYs7O6Vhe/sV3E8X3Y c0pg== X-Gm-Message-State: AC+VfDw76eQmDRvaMpHSnmO+koo5OCneW4Ty+bOo3zCjEe/h0VEsHX2c dFt9KlzEwxI2j8f2LDDMvms0wA== X-Received: by 2002:a17:90a:f2c9:b0:25c:1397:3c0b with SMTP id gt9-20020a17090af2c900b0025c13973c0bmr2237895pjb.37.1686688248844; Tue, 13 Jun 2023 13:30:48 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id 1-20020a17090a034100b0025bf9e02e1bsm3479153pjf.51.2023.06.13.13.30.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 13:30:48 -0700 (PDT) Date: Tue, 13 Jun 2023 13:30:47 -0700 From: Kees Cook To: Tom Rix Cc: mcgrof@kernel.org, yzaikin@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] sysctl: set variable sysctl_mount_point storage-class-specifier to static Message-ID: <202306131330.AAC4C43AC@keescook> References: <20230611120725.183182-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230611120725.183182-1-trix@redhat.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 11, 2023 at 08:07:25AM -0400, Tom Rix wrote: > smatch reports > fs/proc/proc_sysctl.c:32:18: warning: symbol > 'sysctl_mount_point' was not declared. Should it be static? > > This variable is only used in its defining file, so it should be static. > > Signed-off-by: Tom Rix Reviewed-by: Kees Cook -- Kees Cook