Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Jun 2023 14:08:47 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Sumitra Sharma <sumitraartsy@gmail.com>,
        =?iso-8859-1?B?Suly9G1l?= Glisse <jglisse@redhat.com>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
CC:     Ira Weiny <ira.weiny@intel.com>, Fabio <fmdefrancesco@gmail.com>,
        "Deepak R Varma" <drv@mailo.com>
Subject: Re: [PATCH v2] lib: Replace kmap() with kmap_local_page()
Message-ID: <6488dadf965f5_1afb9929434@iweiny-mobl.notmuch>
References: <20230610175712.GA348514@sumitra.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230610175712.GA348514@sumitra.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bU9MZVlnMExDbUJwSW5kZW5SWFRXckJnM2JvNVJSeEpuNFMyUE9EYUdySUR5?=
 =?utf-8?B?VC9taTNESHFsWGFMeWJ4dDNudzg2VXlFRHdSWjdHQ3RCVmtMcFVoN3hJTmg1?=
 =?utf-8?B?NFpJR1RjQUIxNnFabUlleXhGS1hPRlkyam5vVGk2U2ZRSVBHV1dyU1ZQeXpV?=
 =?utf-8?B?VWcwZUNxTUdTYnIvbWk5blZqQ3FicjNIU3lQMWhuS1BjeGFESVZjUUxWeUR3?=
 =?utf-8?B?RDY5L2kvc3ZZd3ZhUzhZNTFNbWV0cTZjZHJ1UENNQkc3QS8vUEtVVmVDdGRz?=
 =?utf-8?B?RVNsQ1ZFRVhNZVJGM3JlSjR6dDFseGtIaFAwcmVHcVJ6ZDVqS2NlamEvT3RI?=
 =?utf-8?B?KzAwa2FrM2pwSEIzVW5RYTUxMUdNRXZETWdaelV4WEJCZXFJOWtwbmRXY3li?=
 =?utf-8?B?N2M4K0s2SGUvTEZnWlVpM1pyWXo1dFpRajMrenVJc2E3NXlCVEZ0OVNqN2d0?=
 =?utf-8?B?dWMvUUZ5dy9BVnlrR2ZHbDNvMDVobzFHVkhiOVo1YzdxdmMzWkIvVUtNVGxy?=
 =?utf-8?B?anZHOGM4VEhyYk90aTVqYkcwaTNwUjNOWUljSkNmSWVqeVJqUnphVEhmSnVi?=
 =?utf-8?B?c1ozTkhaS0ttT2tkWno5SnUzd3pVMjQ4TEdiVEZOM0FFdHpMUjd2Qk8yeTFo?=
 =?utf-8?B?SVgxRzd1UndxV1hCd0x6NllJSUpBRjBVVTNJaTQyQlU4Y3BJc2hhQXI0QWw4?=
 =?utf-8?B?Ti8vQWE3QU9wRWRiR1FnMzBZcmZ3THpUeUJxWnJvcEV1YlRuaTlpcEFraHNV?=
 =?utf-8?B?eWtNaFJ4aTFWVllZSUpVcGRJRG1ZMndvMm13b0piMTFTUGtTVkg5eDhLNEpj?=
 =?utf-8?B?L1cyOHk4ZmpYSk5ub0pDVWIzMEhpR3lheFVTcVRKbmJzd2dSSGU0aUprVUE0?=
 =?utf-8?B?ek1ta3VTWWJiQ1R1YmZraXVJQnJpOUczbzNnaElkVkw5elh2NGVxNWpqU0dL?=
 =?utf-8?B?K0F2WlgxZVJnQXdzWVlSMHRNdWhyZ29abUF4MitHU1R1cHM2aklnWjRtVWhR?=
 =?utf-8?B?bFU3QnZ2eE9wRDVvajRWQUNhTnZXdVdEa0IxUlFYdEtqWU4zR1Nham1OTmFt?=
 =?utf-8?B?QzIrQUMyK1ppUXJZRGZBZkgyODI0VDlyaUFHKzhBTTFkSUh6MzczWFFVYk5S?=
 =?utf-8?B?RCtIS3p1M29HRWpkZ2wvREw0QlRJclFXTUpMRFZmeVNOOU9yazFrTHJOTG9L?=
 =?utf-8?B?ZFJjVy9WR0tnU3JGenVXcEtxRmcyOHE2ZDUrUUdvVnRlUFpGa01BNUNxdEw0?=
 =?utf-8?B?RmFLdXAwd0Q0YTZObG1UcGczdXkwekZVd2hXNzFFRHpsWm96N0ZuRkpqbVhN?=
 =?utf-8?B?RVM0NzZxeTM1TWF1aElMbkxQYWhJczNscFQwZnJTU1BSMVBrc3VUMFo4eWxr?=
 =?utf-8?B?aWdvRXNuNkNxU3U4TmRhdkxZbVlyc2MxQTlEVlJ3R3MyMno5d0NNL3FmR1Rv?=
 =?utf-8?B?cTlkdHZEU2I2akpDdkQvYkIxYWI2NzB1R04weUU0dGRLZG5GRDV6ZVI4ekxM?=
 =?utf-8?B?RnUwTUp0czZRTUV4WXhNaTFXeWwvS3ZTcDhKWndJLzRHdzZDQjhBZHdBQVVv?=
 =?utf-8?B?OThaYUkwbUxMSVRUa0dFWmE5L1kvRzhyMGRrZ0tqY3Z1RjBFWkVPcTNxYmE0?=
 =?utf-8?B?VUkvQW53NFlEWkx3VWI2VS9pdk5US2RGVTZjYklzc3ZCSm9TbTBoMmpJT2xO?=
 =?utf-8?B?bkMwUVhDTjRVS2lIaUhBa1pGckFremJ0S0c4NVNxZGF6UkMxYnF3T1NLUkNl?=
 =?utf-8?B?QXNPYzFqSmc2T0hQZG50U1JZVUVYUC9wVUFTVTFqeUR2NklSbXNyUHFMVHp1?=
 =?utf-8?B?VmRaTGZMMWpYMyt1U0NBZHpJNnpHb2czS1JTejhIZWtlcEJpUjNpOUE0cFhy?=
 =?utf-8?B?K0lmRWhpS0g5SXpyZXhtZXArd3RibVRqL3FvZlZRTzJzaWJ5TVJSbUZKRC9I?=
 =?utf-8?B?S21neUpZOGRRVnoyOXloUk5LVm1BQUo2c0hySFlsc1Y5K3ljVm8vOEltTTFY?=
 =?utf-8?B?WlYzeHM4YTJUMWp3bnZ4L2lPMXVNaW5ZMXVsR3N2eEErN2V0YzQrWXdxOUk2?=
 =?utf-8?B?bmlCUGVtZmZta3pxeWpHcWMvc1psWjVId0VYb3pBK1BxMU43aDR1QWdIaWNF?=
 =?utf-8?Q?8WtYBe3mRpf2EV1Kms68oqNHI?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e487233a-47c9-4209-c496-08db6c5264a7
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 21:08:53.9140
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S18RonqVb+nNZqThuEIJMFcVvWyyYKozGHlUtjtEyZkSd5NlNrf12xYHDxc6wLYr64gRVfThOnU7PIQRorOuxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5689
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sumitra Sharma wrote:
> kmap() has been deprecated in favor of the kmap_local_page()
> due to high cost, restricted mapping space, the overhead of
> a global lock for synchronization, and making the process
> sleep in the absence of free slots.
> 
> kmap_local_page() is faster than kmap() and offers thread-local
> and CPU-local mappings, take pagefaults in a local kmap region
> and preserves preemption by saving the mappings of outgoing
> tasks and restoring those of the incoming one during a context
> switch.
> 
> The mappings are kept thread local in the functions
> “dmirror_do_read” and “dmirror_do_write” in test_hmm.c
> 
> Therefore, replace kmap() with kmap_local_page() and use
> mempcy_from/to_page() to avoid open coding kmap_local_page()
> + memcpy() + kunmap_local().
> 
> Remove the unused variable “tmp”.
> 
> 
> Suggested-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> 
> Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>

LGTM

Reviewed-by: Ira Weiny <ira.weiny@intel.com>