Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1805168rwd; Tue, 13 Jun 2023 14:39:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6qc/EgkdkCDwCrijyqCoZClU3ZikIwZkYOzs1AY3APW1Dbd+RoXVQZwFM+BgZp15VdPB0Y X-Received: by 2002:a05:6512:465:b0:4eb:18d:91de with SMTP id x5-20020a056512046500b004eb018d91demr6568524lfd.43.1686692392861; Tue, 13 Jun 2023 14:39:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686692392; cv=none; d=google.com; s=arc-20160816; b=WmY4g47evmTirB1IHB8+5foZ6Zmkl583DTRiK7zObmF5MMLyU6dd2cw5QzIKmJEZuA jWe4aRU3uzRPuwjmfisgpMbzllbgkIr0vwoge7PjHowGDSq+PF354pxN+sd7E9bKLO7X Ebm+dyDPt8XGwzBIcOhJjlq28P++kyDAFSXTdfN3W3ukKJ6W03UflRF+dv2Zhhd+yq8h cv+DJ2cUhDSELqVFdDlg6VS0ri2ALFiPKpX1iA5l/T1MTbrCGvzsHa+nO2sZY3P1upeu 1IYtp/FlDQqIkHI89tp5VaeRlS4N2MsEiB/j3kBEi/MJ/XSomjSU4hmLA1wMk5XVfA5S JBBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=sq4Gobht14PLhIrlUF3qoMat2z47BnhfNavxp+vbMx8=; b=D5296qbvrL/OZS2Hnj2co5YQOWE3cS7JeoemPUpvGzJG6Wnsq3N/1NyLvWUvocWWWQ 4tQWeIoA0hoAJOmXeTqwM/7VBCWfGYue8dnpKArxHyvF2oHLVBxYdwi+NATHWKtx+OoW 0wVp5oHwecrmRL0XzWs7XcvV/DjuiDuFyPvGptwyKM61nTjCe15q60T8jtDKgo5V5kiT SF3/MSdmr/e7lLKFeGsyDDWxMbf1R6Sw5GXZsszIuYLx4bTnmuOEFC8SbIsigQhhnl9B tauBZlSl/ASRWvjMfsGG7KZdg6TVKWTL4b6fhoHJh4l+jdrx4VYPsd/2BEgeVhcZHd6O PKcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VyhsikgX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id be6-20020a0564021a2600b0051872bd531asi1588809edb.536.2023.06.13.14.39.26; Tue, 13 Jun 2023 14:39:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VyhsikgX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231995AbjFMVgp (ORCPT + 99 others); Tue, 13 Jun 2023 17:36:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231499AbjFMVgh (ORCPT ); Tue, 13 Jun 2023 17:36:37 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 419C81BDA for ; Tue, 13 Jun 2023 14:35:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686692035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sq4Gobht14PLhIrlUF3qoMat2z47BnhfNavxp+vbMx8=; b=VyhsikgXhgdK9GQKET4E1GvDKIe+RiZZ/8CMs3rOmE5Wid3I5r5E6Q0FubPAG7JS+sjNHV 3hFeF0Rhts70+RryaqHU1KAzlgSHZsutZlUUaS0G32kVT9YQixW1p7Gw8Y1zsy54CXrcyJ kvkgarpayhaa7zQ9QOpF4a12b8wHoC0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-26-n-lhBdEfO5-ebbjiGfLzWQ-1; Tue, 13 Jun 2023 17:33:52 -0400 X-MC-Unique: n-lhBdEfO5-ebbjiGfLzWQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5184F1C0512F; Tue, 13 Jun 2023 21:33:50 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id A7C0B140E951; Tue, 13 Jun 2023 21:33:47 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <431929.1686588681@warthog.procyon.org.uk> To: David Hildenbrand Cc: dhowells@redhat.com, Jens Axboe , kernel test robot , Christoph Hellwig , Andrew Morton , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Lorenzo Stoakes , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: Fix dio_bio_alloc() to set BIO_PAGE_PINNED MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1156282.1686692027.1@warthog.procyon.org.uk> Date: Tue, 13 Jun 2023 22:33:47 +0100 Message-ID: <1156283.1686692027@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Okay, it isn't this. The problem appears to be that __blockdev_direct_IO() calls dio_cleanup() twice if do_direct_IO() fails. David