Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
        Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
        Peilin Ye <yepeilin.cs@gmail.com>,
        Pedro Tammela <pctammela@mojatatu.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Zhengchao Shao <shaozhengchao@huawei.com>,
        Maxim Georgiev <glipus@gmail.com>
Subject: [PATCH v2 net-next 4/9] net/sched: taprio: delete misleading comment about preallocating child qdiscs
Date:   Wed, 14 Jun 2023 00:54:35 +0300
Message-Id: <20230613215440.2465708-5-vladimir.oltean@nxp.com>
In-Reply-To: <20230613215440.2465708-1-vladimir.oltean@nxp.com>
References: <20230613215440.2465708-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cwB2oh83J9gZYGfsweQ1lIcuhgPby99P0NI0Ufp+HOj32SFnBfUWu1vkexaX?=
 =?us-ascii?Q?2unCZjCgyvqU6gkRNdnJdvqaFtfOWYzmelnVQgS6NxIQGNJhZlA6CccKCecw?=
 =?us-ascii?Q?UI5GjhYxbu/OiPvSqoOqTTzCzN5y1y2SMQmS/tNJ2zw5eBa3gFj6rIxBQxwi?=
 =?us-ascii?Q?FcBRm7H9TvC8iFpABMEmvW+fv+nkl8PfdnPs9nCyry0Lw2sRLcgk2oMqYWRB?=
 =?us-ascii?Q?USPX4MkpVem3JcaxxCFZ0jQX8mFk3+QvUmLRK4LpUp7VfanNfv9ONR7g1KQc?=
 =?us-ascii?Q?CLF4CR/Bec3Cx/QVnGJCaNYBMn9QJ1sL2w85pq3U2snZV68PrH7pfhgoGnZR?=
 =?us-ascii?Q?giTAJ9QQVC0pewrQloNIQwjMqCLbOalDUHBs4DwiuGmUpckvYdYeiHRjLjXS?=
 =?us-ascii?Q?fxviKMM6LRsyN5NNIFe46ZLa7AuNxZVjrnZgkZweDZaR6wUoth/XhB/misD3?=
 =?us-ascii?Q?CyGb1LU3L4CElPE+vTOzQMlU3IYtcpXqndMrprUTmzMbvFat50KKu8Wh9xUD?=
 =?us-ascii?Q?swQrSABOU9aPPu5epfeqLwL2Qjqxmoc4+omWNVj7mnwZ5el2IlWz2jYv0lsF?=
 =?us-ascii?Q?/wSS8vRaJiulhR+HIU/9UjDkQ1V/0Cj88w+nVkdi7CJD8wYBcjaQ7CwHYqYf?=
 =?us-ascii?Q?gij3QTjW4vkvQK8wzxvaRNOv0m0Xq95efW78sLRDNA4vyXauf1PG2Zhb5pOe?=
 =?us-ascii?Q?jhGiAjES8qnUKHnDs31/LpIBINMMvI5+rA8aYz2r7GbnWUhd0ULMejY+1iVP?=
 =?us-ascii?Q?AnvHrp5fBDph9ZEyMyGwet4GhotFtWv5EYz9WT1cYz6YgB5EMUyeiMdU38Cs?=
 =?us-ascii?Q?cN0FLeu3eZYW7ARhPKLUMY2Uj067Q9xbDHU7HNKxExIvSyLtZ3bQl/i43qhC?=
 =?us-ascii?Q?iTZsiV2Hg8WcfoK0g66IKG57fUIwiuKY4JrEfhqTLi+YdQb2ti7UaE0ASnHt?=
 =?us-ascii?Q?5coaWywGnhEMuDG0ybIqPyxFtBfqIgpzbQgjVlV0nS0/5ML+OUxLYv+CJ/H0?=
 =?us-ascii?Q?jg0QHCWotk2jkXC6pivTSK3PUkVSmwwGnjWt7LakCJ2Rst+xHryYRSGT1cSV?=
 =?us-ascii?Q?jFWJl6D1rjkbohHHYgbYe+tD7B3QEUED92m+6txHx5rfObxuZk/h7Td/Rtzl?=
 =?us-ascii?Q?lEEuz1/dNC034epYXIg9BqPgrXBslc+qSgTXxEswG1A1qSE0w5/BhZTZUwMP?=
 =?us-ascii?Q?1ByeGTfUpPAXpnPHm46EOmcYnA0zC1NNMm1bAKtx9h1Awgoy8EnccqN+Upc+?=
 =?us-ascii?Q?iTJ8mSGycI8WbzECLECYQufMrvoclqPEcSWccrKJqv/C4ZoJnmFkGa6YDnP1?=
 =?us-ascii?Q?6UNLTnRtXFvbDmKOgd7JuH9e8AoZKiqOpjd1KxUnxRWwyOdTZcf8VN7qg+HR?=
 =?us-ascii?Q?YcapUXaR6AofLpOqkjES0XMWP9MSKvN/RkpLk4Nxk7tiy2JihceAgcvMfn80?=
 =?us-ascii?Q?kkuSK1NISeo4KbgzjhR+NK5DAvDmb9+EnjqYei4qhzxHASIj8AJFBVye76Dg?=
 =?us-ascii?Q?yoHwvk594smMqQ/jinSZqwFzioq4GJSuuY9q+Jf0vfxaF9ila6J4WJDZZG4O?=
 =?us-ascii?Q?IQhuL7LjUGYW0uec2U3a2sCcLhT89aFAHJiYoQSqG22d0qRJDG1QzYomgdVs?=
 =?us-ascii?Q?6Q=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b75d9ea6-635d-4cb0-9288-08db6c58d361
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 21:54:56.3762
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8IsLzGqMTTVFQgBKDmSaCMeKlO6ohyioGRpLy6bWyJaFOhZGVPAc+CXfFvae4AI9xT12UswM4jgg2Yv6JdgtDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8081
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

As mentioned in commit af7b29b1deaa ("Revert "net/sched: taprio: make
qdisc_leaf() see the per-netdev-queue pfifo child qdiscs"") - unlike
mqprio, taprio doesn't use q->qdiscs[] only as a temporary transport
between Qdisc_ops :: init() and Qdisc_ops :: attach().

Delete the comment, which is just stolen from mqprio, but there, the
usage patterns are a lot different, and this is nothing but confusing.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
v1->v2: none

 net/sched/sch_taprio.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
index 14d628926d61..c35e27d0e49e 100644
--- a/net/sched/sch_taprio.c
+++ b/net/sched/sch_taprio.c
@@ -2085,11 +2085,8 @@ static int taprio_init(struct Qdisc *sch, struct nlattr *opt,
 		return -EOPNOTSUPP;
 	}
 
-	/* pre-allocate qdisc, attachment can't fail */
-	q->qdiscs = kcalloc(dev->num_tx_queues,
-			    sizeof(q->qdiscs[0]),
+	q->qdiscs = kcalloc(dev->num_tx_queues, sizeof(q->qdiscs[0]),
 			    GFP_KERNEL);
-
 	if (!q->qdiscs)
 		return -ENOMEM;
 
-- 
2.34.1