Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1862480rwd; Tue, 13 Jun 2023 15:42:23 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7ny1LUe9TOe/cw0ioUhZjzMEcpTvAXuSqD2PZmTXxsLnaRdQDeLuMTJ9FN+W+vMmAjMO7d X-Received: by 2002:a17:90a:4b:b0:25b:d57f:1019 with SMTP id 11-20020a17090a004b00b0025bd57f1019mr40271pjb.44.1686696143177; Tue, 13 Jun 2023 15:42:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686696143; cv=none; d=google.com; s=arc-20160816; b=SXkaIWD2wS20tQwHG5gpV2iL3B47hnpiM47i6/hHn4BeQrmW+U8Yv+jGBPq6PtARHd sqg6CE/F1/GCw5/ep/gCg0GxERH8iN9L9dO4tkxf00Is3/e9nq68vvLyX1O44PLWpVUM 7Rs/WSuibxIxUaZ4n8EezA28vrzJG+spIlgN2z1ogNgRG6LMAYOTq2DVph9M9JUWNKcL kwQIX+jraLmb7kkidh/AGDiP0et6/KJt4oeWXA1l/gEPaeJK02Vwfs5a2Se6RL+ZSVOD kecpUxIuPftuZ3ZUPdw2VdTWzciqMjNDyPzhw5dVw3fpOJL2GxRb8/9g5dodqA3cNKba 9GMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=foeqoN2DcOHM/9J838OPIOMEQ6wjjp/SoAnTA42KwBw=; b=0BgvvmTRqSIPhSGKlm6A4hoj9YkOhblhCMeCZp0kqonaFabbqju7JEGdup3SLIDIKQ 3hAY8TKgpNDotKvbh0Z04bZjtQqvKOdUuGrTU0Gko8q/u/IaNEwnl9sG1mTKdDsgHr7w rZYK99PBZiwr8o1j3FaeJcPYfouQe7RTeqoFsJ34Z+YiJup0/eQ+WsvChKMufHkDkpb7 j/m3IoihYjYhYwNYcQpXNs6AcxgA9OLD4CP4JDGPp5mduHTQMwTlAtv/Wyh+IhKNbdXo fvERANCdC+nSwshyQRJEbbbKaeOuWH5C31QSTQhoMddxReBT3lf9wZ1wn5k8WxqlApDl x7bA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QQ1kPAxJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ls8-20020a17090b350800b00250a6b87c76si10269587pjb.142.2023.06.13.15.42.10; Tue, 13 Jun 2023 15:42:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QQ1kPAxJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241008AbjFMW20 (ORCPT + 99 others); Tue, 13 Jun 2023 18:28:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240276AbjFMW1t (ORCPT ); Tue, 13 Jun 2023 18:27:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BA881FEB; Tue, 13 Jun 2023 15:27:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CAA5363B99; Tue, 13 Jun 2023 22:27:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8467C61189; Tue, 13 Jun 2023 22:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686695250; bh=UfFq18SdE+0Yu8PGuObPISCOzDlEbYeLkDtsbj7uzTc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QQ1kPAxJurXn2qa0GiBAX4JjoPK//TYnrFCmaX0qJmhrdQ+2NgS0KWZsFcY9RsL8V mfjVSsIrPwCgqo3kyMXpXRgfiPY2/2uM7hRwwd89cmJA9+JbdJQySmHdMfpQqM+kH7 wNRE0pT4zlTPoqyfwfjEKuiMyuhubSwBTGx+bwp0438CkjtFiZZAinf9EIJg3NIiDB 9YnE5YtG/XD7+Yv8Gmwr/axLFiRDunwHwNYvqddz9vVlDZv29x9NLTc1c62UKUvhXE hyallG/3MU9VBVENmr59QsDAbZmHEorOgXYMF9SDMLBCkxBatH/t4iq6kdnVBYgr4t bLIEa0QgZANuA== From: Bjorn Andersson To: Konrad Dybcio , Melody Olvera , Bjorn Andersson , Gokul krishna Krishnakumar Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: qcom: mdt_loader: Fix split image detection Date: Tue, 13 Jun 2023 15:30:26 -0700 Message-Id: <168669542893.1315701.7917575988256964761.b4-ty@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230612215804.1883458-1-quic_bjorande@quicinc.com> References: <20230612215804.1883458-1-quic_bjorande@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Jun 2023 14:58:04 -0700, Bjorn Andersson wrote: > The enhanced detection introduced in commit '210d12c8197a ("soc: qcom: > mdt_loader: Enhance split binary detection")' requires that all segments > lies within the file on disk. > > But the Qualcomm firmware files consistently has a BSS-like segment at > the end, with a p_offset aligned to the next 4k boundary. As the p_size > is 0 and there's nothing to load, the image is not padded to cover this > (empty) segment. > > [...] Applied, thanks! [1/1] soc: qcom: mdt_loader: Fix split image detection commit: 0d25da8e7e1e35bdbb521d586be1954bdedd1cca Best regards, -- Bjorn Andersson