Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935959AbXJQAZc (ORCPT ); Tue, 16 Oct 2007 20:25:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760959AbXJQAZX (ORCPT ); Tue, 16 Oct 2007 20:25:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:60639 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751994AbXJQAZW (ORCPT ); Tue, 16 Oct 2007 20:25:22 -0400 To: David Miller Cc: arnd@arndb.de, Geert.Uytterhoeven@sonycom.com, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, jens.axboe@oracle.com Subject: Re: ioctl32: Unknown cmd References: <200710162150.37636.arnd@arndb.de> <20071016.152404.35664335.davem@davemloft.net> From: Andi Kleen Date: 17 Oct 2007 02:25:20 +0200 In-Reply-To: <20071016.152404.35664335.davem@davemloft.net> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 839 Lines: 18 David Miller writes: > From: Arnd Bergmann > Date: Tue, 16 Oct 2007 21:50:35 +0200 > > > The one point where it is expected to have changed now is when you > > try to do these ioctls on something that is not a block device. Are > > you sure that the files you tried them on were created correctly? > > Many many many programs do this exact sort of thing. > > It is one of the bad aspects of moving the compat handling > down into the file ops for a specific device. When this happens one should add respective IGNORE_IOCTL()s to compat_ioctl.c -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/