Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1995304rwd; Tue, 13 Jun 2023 18:08:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7S158J9gkIJp9QLdtZEY/6mh7INH49W4kzuObdkI8/2VqRTdTgF3HagocC1oB5VVsUwhtw X-Received: by 2002:a17:902:f68e:b0:1ae:50cc:455 with SMTP id l14-20020a170902f68e00b001ae50cc0455mr13005910plg.39.1686704904906; Tue, 13 Jun 2023 18:08:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686704904; cv=none; d=google.com; s=arc-20160816; b=Dcm6RyTH2roSyH5IMgTRv5rwVJb95vuHPDZCp5vyAHVdWXxeaVAEUZGQ8IeejVPX9z MEGNJIbhf+cTTp8qgF0/s46ZK4nlH1dDlilrhwWUWhmXqd26BUqN/1LI6iZREYhWxmds pl/7PcmkpEFdc6IBixwYmoD/2flHhpFubffUNc8xv2l4ZUl8KyhaC5DaCsPHRejSHR3E gf4YchcUD6Ea+E8cgqKG9tvFAk0Tsln2qU8MpgIuP6iS6yR4GlO4FhyihMXRFJZH24/s EIueJzzctZaPNgF+Vr/tyQQIZtSselZvWNQ5CtuxOuDEVcaWXcxpKW9Am3PdggmrWlCS O6zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=BPkeVu8OxPotzWhrp9aHUHfVrW4/Skp7NV1QkalCka0=; b=0ngOAYHGIAC6oKo4wJUOTKPjzXrF4X395lF+lyZQR/wySuxueGs61orDY6el9GjDJA XwNo1kQ0uLar2Tk3sX8NGB4V6mPy45fy7yfnXsv4Aq99SfmQWL77Yt6m1qHgJ3WrTg2W af7PCQ5ZdChb6BLsTV7VjUonneXhGuECkvJJ1SC0IVC4DqY2VktLNf69WPNGsy8UP0rM lFCIFKcuur1XINlEppSBtNT/2kmHuAm4pcrdoFiOAihlROkufSSES80ml+wI/tGoU/XW nz8y4UDaUuZpNuM2DjLndNoNYbQ+tAhida4CwhA9JkmWhsY5MShr79N99MNGQvs6UxSe T8nQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hMuC7m1k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t3-20020a170902bc4300b001ae38227983si9780990plz.199.2023.06.13.18.08.06; Tue, 13 Jun 2023 18:08:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hMuC7m1k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234663AbjFNAu5 (ORCPT + 99 others); Tue, 13 Jun 2023 20:50:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229955AbjFNAuz (ORCPT ); Tue, 13 Jun 2023 20:50:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25D32199C for ; Tue, 13 Jun 2023 17:50:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E4BBB634A3 for ; Wed, 14 Jun 2023 00:50:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0250EC433C8; Wed, 14 Jun 2023 00:50:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686703852; bh=BPkeVu8OxPotzWhrp9aHUHfVrW4/Skp7NV1QkalCka0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hMuC7m1k1oCYmdNL8W4eaq/Fvq7MovlhxOr/OnphL+JQKlG4/ZU3zJOb/L4gKtCys 2q2duUg4/aq3zcgK1ztZ6DigIO2B+rjDS3OLvJa/1V2dHQTF53Dt5BJugftKUECuaM gkHPShP4miWFR5HLA40hNR8MmqGZ2k7tBsjMbsAIz2Kg5GMbtyldxMLB4Z6Uv44yOU jQtmRmbCSWxZ90iy3aBDWsV65uhNc5Org6RcU2csRHj+h31HUiXztoV5VjmEPFcSpJ TV4zQPDg7SWfA1b/aeC2Oy7Kujl8dlWJgnsbDW4ybN26mE/HFGi70f8xVfDjwGDNlX YmaTJ5Y9EcqXA== Date: Tue, 13 Jun 2023 17:50:51 -0700 From: Jakub Kicinski To: Arkadiusz Kubalewski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, chuck.lever@oracle.com Subject: Re: [PATCH net-next] tools: ynl-gen: fix nested policy attribute type Message-ID: <20230613175051.32196c59@kernel.org> In-Reply-To: <20230613231709.150622-1-arkadiusz.kubalewski@intel.com> References: <20230613231709.150622-1-arkadiusz.kubalewski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Jun 2023 01:17:07 +0200 Arkadiusz Kubalewski wrote: > When nested multi-attribute is used in yaml spec, generated type in > the netlink policy is NLA_NEST, which is wrong as there is no such type. > Fix be adding `ed` sufix for policy generated for 'nest' type attribute > when the attribute is parsed as TypeMultiAttr class. I CCed you on my changes which address the same issue, they have already been merged: https://lore.kernel.org/all/20230612155920.1787579-1-kuba@kernel.org/ I think that covers the first two patches. What am I missing? :S